subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hyrum K Wright <hyrum.wri...@wandisco.com>
Subject Re: svn commit: r1291568 - /subversion/trunk/subversion/libsvn_ra_local/ra_plugin.c
Date Tue, 21 Feb 2012 03:15:55 GMT
On Mon, Feb 20, 2012 at 9:13 PM, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> hwright@apache.org wrote on Tue, Feb 21, 2012 at 03:02:03 -0000:
>> Author: hwright
>> Date: Tue Feb 21 03:02:03 2012
>> New Revision: 1291568
>>
>> URL: http://svn.apache.org/viewvc?rev=1291568&view=rev
>> Log:
>> Ev2 shims: Add a no-op shim callback registration function for ra_local.
>>
>> * subversion/libsvn_ra_local/ra_plugin.c
>>   (svn_ra_local__register_editor_shim_callbacks): New.
>>   (ra_local_vtable): Add new callback to the vtable.
>>
>> Modified:
>>     subversion/trunk/subversion/libsvn_ra_local/ra_plugin.c
>>
>> Modified: subversion/trunk/subversion/libsvn_ra_local/ra_plugin.c
>> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_local/ra_plugin.c?rev=1291568&r1=1291567&r2=1291568&view=diff
>> ==============================================================================
>> --- subversion/trunk/subversion/libsvn_ra_local/ra_plugin.c (original)
>> +++ subversion/trunk/subversion/libsvn_ra_local/ra_plugin.c Tue Feb 21 03:02:03 2012
>> @@ -1505,6 +1505,15 @@ svn_ra_local__get_deleted_rev(svn_ra_ses
>>    return SVN_NO_ERROR;
>>  }
>>
>> +static svn_error_t *
>> +svn_ra_local__register_editor_shim_callbacks(svn_ra_session_t *session,
>> +                                    svn_delta_shim_callbacks_t
*callbacks)
>> +{
>> +  /* This is currenly a no-op, since we don't provide our own editor, just
>> +     use the one the libsvn_repos hands back to us. */
>
>     *callbacks = NULL;
>
> ?

No.  callbacks in an input parameters, and even though this function
doesn't make use if it, it certainly should go modifying it.

-Hyrum

>
>> +  return SVN_NO_ERROR;
>> +}
>> +
>>  /*----------------------------------------------------------------*/
>>
>>  static const svn_version_t *
>> @@ -1551,7 +1560,8 @@ static const svn_ra__vtable_t ra_local_v
>>    svn_ra_local__replay,
>>    svn_ra_local__has_capability,
>>    svn_ra_local__replay_range,
>> -  svn_ra_local__get_deleted_rev
>> +  svn_ra_local__get_deleted_rev,
>> +  svn_ra_local__register_editor_shim_callbacks
>>  };
>>
>>
>>
>>



-- 

uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/

Mime
View raw message