subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hwri...@apache.org
Subject svn commit: r1227738 - /subversion/trunk/subversion/libsvn_repos/dump.c
Date Thu, 05 Jan 2012 18:44:07 GMT
Author: hwright
Date: Thu Jan  5 18:44:07 2012
New Revision: 1227738

URL: http://svn.apache.org/viewvc?rev=1227738&view=rev
Log:
Add a bit of strong typing.

* subversion/libsvn_repos/dump.c
  (fetch_base_func, svn_repos_dump_fs3, svn_repos_verify_fs2): Correctly type
    the editor baton, since we know what it is a priori.

Modified:
    subversion/trunk/subversion/libsvn_repos/dump.c

Modified: subversion/trunk/subversion/libsvn_repos/dump.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_repos/dump.c?rev=1227738&r1=1227737&r2=1227738&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_repos/dump.c (original)
+++ subversion/trunk/subversion/libsvn_repos/dump.c Thu Jan  5 18:44:07 2012
@@ -884,7 +884,7 @@ fetch_base_func(const char **filename,
 
 static svn_error_t *
 get_dump_editor(const svn_delta_editor_t **editor,
-                void **edit_baton,
+                struct edit_baton **edit_baton,
                 svn_fs_t *fs,
                 svn_revnum_t to_rev,
                 const char *root_path,
@@ -1024,7 +1024,7 @@ svn_repos_dump_fs3(svn_repos_t *repos,
                    apr_pool_t *pool)
 {
   const svn_delta_editor_t *dump_editor;
-  void *dump_edit_baton = NULL;
+  struct edit_baton *dump_edit_baton = NULL;
   svn_revnum_t i;
   svn_fs_t *fs = svn_repos_fs(repos);
   apr_pool_t *subpool = svn_pool_create(pool);
@@ -1176,9 +1176,9 @@ svn_repos_dump_fs3(svn_repos_t *repos,
 
       if (dump_edit_baton) /* We never get an edit baton for r0. */
         {
-          if (((struct edit_baton *)dump_edit_baton)->found_old_reference)
+          if (dump_edit_baton->found_old_reference)
             found_old_reference = TRUE;
-          if (((struct edit_baton *)dump_edit_baton)->found_old_mergeinfo)
+          if (dump_edit_baton->found_old_mergeinfo)
             found_old_mergeinfo = TRUE;
         }
     }
@@ -1338,7 +1338,7 @@ svn_repos_verify_fs2(svn_repos_t *repos,
   for (rev = start_rev; rev <= end_rev; rev++)
     {
       svn_delta_editor_t *dump_editor;
-      void *dump_edit_baton;
+      struct edit_baton *dump_edit_baton;
       const svn_delta_editor_t *cancel_editor;
       void *cancel_edit_baton;
       svn_fs_root_t *to_root;



Mime
View raw message