Mailing-List: contact commits-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@subversion.apache.org
Received-SPF: pass (nike.apache.org: local policy)
Message-Id: <1321014417.20808.140660997601793@webmail.messagingengine.com>
From: "Daniel Shahaf" <d.s@daniel.shahaf.name>
To: dev@subversion.apache.org
Cc: commits@subversion.apache.org
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"
In-Reply-To: <20111111120750.258E52388860@eris.apache.org>
References: <20111111120750.258E52388860@eris.apache.org>
Subject: Re: svn commit: r1200837 - in /subversion/trunk/subversion:
 svn/commit-cmd.c svn/copy-cmd.c svn/delete-cmd.c svn/import-cmd.c
 svn/mkdir-cmd.c svn/move-cmd.c tests/cmdline/basic_tests.py
Date: Fri, 11 Nov 2011 14:26:57 +0200

On Friday, November 11, 2011 12:07 PM, philip@apache.org wrote:
> Modified: subversion/trunk/subversion/svn/delete-cmd.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/delete-cmd.c?rev=1200837&r1=1200836&r2=1200837&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/svn/delete-cmd.c (original)
> +++ subversion/trunk/subversion/svn/delete-cmd.c Fri Nov 11 12:07:49 2011
> @@ -79,7 +79,9 @@ svn_cl__delete(apr_getopt_t *os,
>    SVN_ERR(svn_cl__eat_peg_revisions(&targets, targets, pool));
>  
>    err = svn_client_delete4(targets, opt_state->force, opt_state->keep_local,
> -                           opt_state->revprop_table, svn_cl__print_commit_info,
> +                           opt_state->revprop_table,
> +                           (opt_state->quiet
> +                            ? NULL : svn_cl__print_commit_info),
>                             NULL, ctx, pool);
>    if (err)
>      err = svn_cl__may_need_force(err);
> 
> Modified: subversion/trunk/subversion/svn/import-cmd.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/import-cmd.c?rev=1200837&r1=1200836&r2=1200837&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/svn/import-cmd.c (original)
> +++ subversion/trunk/subversion/svn/import-cmd.c Fri Nov 11 12:07:49 2011
> @@ -120,7 +120,8 @@ svn_cl__import(apr_getopt_t *os,
>                                opt_state->no_ignore,
>                                opt_state->force,
>                                opt_state->revprop_table,
> -                              svn_cl__print_commit_info,
> +                              (opt_state->quiet
> +                               ? NULL : svn_cl__print_commit_info),
>                                NULL,

For next time, perhaps it would be better to, instead, pass a baton and
let the callback figure out whether or not to print.  *shrug*