subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <...@daniel.shahaf.name>
Subject Re: svn commit: r1170836 - in /subversion/trunk/subversion: include/ libsvn_client/ libsvn_delta/ libsvn_ra_neon/ libsvn_ra_serf/ libsvn_ra_svn/ libsvn_repos/ libsvn_wc/ svnrdump/ svnsync/ tests/libsvn_delta/
Date Wed, 14 Sep 2011 22:06:49 GMT
hwright@apache.org wrote on Wed, Sep 14, 2011 at 20:28:39 -0000:
> @@ -240,12 +243,19 @@ ev2_change_dir_prop(void *dir_baton,
>                      apr_pool_t *scratch_pool)
>  {
>    struct ev2_dir_baton *db = dir_baton;
> -  struct prop_args *p_args = apr_palloc(db->eb->edit_pool, sizeof(*p_args));
>  
> -  p_args->name = apr_pstrdup(db->eb->edit_pool, name);
> -  p_args->value = value ? svn_string_dup(value, db->eb->edit_pool) : NULL;
> +  if (value)
> +    {
> +      struct prop_args *p_args = apr_palloc(db->eb->edit_pool, sizeof(*p_args));
> +
> +      p_args->name = apr_pstrdup(db->eb->edit_pool, name);
> +      p_args->value = value ? svn_string_dup(value, db->eb->edit_pool) : NULL;

The NULL will never be evaluated.  (also in ev2_change_file_prop())

The rest looks good.

Mime
View raw message