subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From danie...@apache.org
Subject svn commit: r1167528 - in /subversion/branches/fs-successor-ids/subversion: include/svn_fs.h libsvn_fs/fs-loader.c libsvn_fs/fs-loader.h libsvn_fs_base/tree.c libsvn_fs_fs/tree.c
Date Sat, 10 Sep 2011 14:56:44 GMT
Author: danielsh
Date: Sat Sep 10 14:56:44 2011
New Revision: 1167528

URL: http://svn.apache.org/viewvc?rev=1167528&view=rev
Log:
On the fs-successor-ids branch, fix an API signature for consistency.

* subversion/include/svn_fs.h (svn_fs_history_next),
* subversion/libsvn_fs/fs-loader.h (history_vtable_t.next),
* subversion/libsvn_fs/fs-loader.c (svn_fs_history_next),
* subversion/libsvn_fs_fs/tree.c (fs_history_next),
* subversion/libsvn_fs_base/tree.c (base_history_next):
    Remove a layer of indirection from the callback parameter.

[ That's the other side of the "C doesn't care whether you write
'callback(args)' or '(*callback)(args)'" coin. ]

Modified:
    subversion/branches/fs-successor-ids/subversion/include/svn_fs.h
    subversion/branches/fs-successor-ids/subversion/libsvn_fs/fs-loader.c
    subversion/branches/fs-successor-ids/subversion/libsvn_fs/fs-loader.h
    subversion/branches/fs-successor-ids/subversion/libsvn_fs_base/tree.c
    subversion/branches/fs-successor-ids/subversion/libsvn_fs_fs/tree.c

Modified: subversion/branches/fs-successor-ids/subversion/include/svn_fs.h
URL: http://svn.apache.org/viewvc/subversion/branches/fs-successor-ids/subversion/include/svn_fs.h?rev=1167528&r1=1167527&r2=1167528&view=diff
==============================================================================
--- subversion/branches/fs-successor-ids/subversion/include/svn_fs.h (original)
+++ subversion/branches/fs-successor-ids/subversion/include/svn_fs.h Sat Sep 10 14:56:44 2011
@@ -1271,7 +1271,7 @@ typedef svn_error_t *
  * @since New in 1.8.
  */
 svn_error_t *
-svn_fs_history_next(svn_fs_history_next_receiver_t *receiver,
+svn_fs_history_next(svn_fs_history_next_receiver_t receiver,
                     void *receiver_baton,
                     svn_fs_history_t *history,
                     apr_pool_t *pool);

Modified: subversion/branches/fs-successor-ids/subversion/libsvn_fs/fs-loader.c
URL: http://svn.apache.org/viewvc/subversion/branches/fs-successor-ids/subversion/libsvn_fs/fs-loader.c?rev=1167528&r1=1167527&r2=1167528&view=diff
==============================================================================
--- subversion/branches/fs-successor-ids/subversion/libsvn_fs/fs-loader.c (original)
+++ subversion/branches/fs-successor-ids/subversion/libsvn_fs/fs-loader.c Sat Sep 10 14:56:44
2011
@@ -1276,7 +1276,7 @@ svn_fs_history_prev(svn_fs_history_t **p
 }
 
 svn_error_t *
-svn_fs_history_next(svn_fs_history_next_receiver_t *receiver,
+svn_fs_history_next(svn_fs_history_next_receiver_t receiver,
                     void *receiver_baton,
                     svn_fs_history_t *history,
                     apr_pool_t *pool)

Modified: subversion/branches/fs-successor-ids/subversion/libsvn_fs/fs-loader.h
URL: http://svn.apache.org/viewvc/subversion/branches/fs-successor-ids/subversion/libsvn_fs/fs-loader.h?rev=1167528&r1=1167527&r2=1167528&view=diff
==============================================================================
--- subversion/branches/fs-successor-ids/subversion/libsvn_fs/fs-loader.h (original)
+++ subversion/branches/fs-successor-ids/subversion/libsvn_fs/fs-loader.h Sat Sep 10 14:56:44
2011
@@ -339,7 +339,7 @@ typedef struct history_vtable_t
   svn_error_t *(*prev)(svn_fs_history_t **prev_history_p,
                        svn_fs_history_t *history, svn_boolean_t cross_copies,
                        apr_pool_t *pool);
-  svn_error_t *(*next)(svn_fs_history_next_receiver_t *receiver,
+  svn_error_t *(*next)(svn_fs_history_next_receiver_t receiver,
                        void *receiver_baton,
                        svn_fs_history_t *history,
                        apr_pool_t *pool);

Modified: subversion/branches/fs-successor-ids/subversion/libsvn_fs_base/tree.c
URL: http://svn.apache.org/viewvc/subversion/branches/fs-successor-ids/subversion/libsvn_fs_base/tree.c?rev=1167528&r1=1167527&r2=1167528&view=diff
==============================================================================
--- subversion/branches/fs-successor-ids/subversion/libsvn_fs_base/tree.c (original)
+++ subversion/branches/fs-successor-ids/subversion/libsvn_fs_base/tree.c Sat Sep 10 14:56:44
2011
@@ -4472,7 +4472,7 @@ base_history_prev(svn_fs_history_t **pre
 
 /* Implement svn_fs_history_next(). */
 static svn_error_t *
-base_history_next(svn_fs_history_next_receiver_t *receiver,
+base_history_next(svn_fs_history_next_receiver_t receiver,
                   void *receiver_baton,
                   svn_fs_history_t *history,
                   apr_pool_t *pool)

Modified: subversion/branches/fs-successor-ids/subversion/libsvn_fs_fs/tree.c
URL: http://svn.apache.org/viewvc/subversion/branches/fs-successor-ids/subversion/libsvn_fs_fs/tree.c?rev=1167528&r1=1167527&r2=1167528&view=diff
==============================================================================
--- subversion/branches/fs-successor-ids/subversion/libsvn_fs_fs/tree.c (original)
+++ subversion/branches/fs-successor-ids/subversion/libsvn_fs_fs/tree.c Sat Sep 10 14:56:44
2011
@@ -3332,7 +3332,7 @@ fs_history_prev(svn_fs_history_t **prev_
 
 /* Implement svn_fs_history_next(). */
 static svn_error_t *
-fs_history_next(svn_fs_history_next_receiver_t *receiver,
+fs_history_next(svn_fs_history_next_receiver_t receiver,
                 void *receiver_baton,
                 svn_fs_history_t *history,
                 apr_pool_t *pool)



Mime
View raw message