subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ne...@apache.org
Subject svn commit: r1163372 - /subversion/trunk/subversion/libsvn_client/externals.c
Date Tue, 30 Aug 2011 20:53:02 GMT
Author: neels
Date: Tue Aug 30 20:53:02 2011
New Revision: 1163372

URL: http://svn.apache.org/viewvc?rev=1163372&view=rev
Log:
Fix wrong order of arguments. They currently are both always passed in as
SVN_INVALID_REVNUM, but a subsequent patch will fix that.

* subversion/libsvn_client/externals.c
  (switch_dir_external):
    Swap order of REVISION and PEG_REVISION so that it corresponds with
    switch_file_external().
  (handle_external_item_change):
    Adjust this caller to the new argument order. Note that another caller
    from this function used to erratically pass the arguments in the wrong
    order and "coincidentally" becomes correct with above argument swap.

Modified:
    subversion/trunk/subversion/libsvn_client/externals.c

Modified: subversion/trunk/subversion/libsvn_client/externals.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_client/externals.c?rev=1163372&r1=1163371&r2=1163372&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_client/externals.c (original)
+++ subversion/trunk/subversion/libsvn_client/externals.c Tue Aug 30 20:53:02 2011
@@ -126,8 +126,8 @@ relegate_dir_external(svn_wc_context_t *
 static svn_error_t *
 switch_dir_external(const char *local_abspath,
                     const char *url,
-                    const svn_opt_revision_t *revision,
                     const svn_opt_revision_t *peg_revision,
+                    const svn_opt_revision_t *revision,
                     const char *defining_abspath,
                     svn_boolean_t *timestamp_sleep,
                     svn_client_ctx_t *ctx,
@@ -945,8 +945,8 @@ handle_external_item_change(const struct
         {
         case svn_node_dir:
           SVN_ERR(switch_dir_external(local_abspath, new_url,
-                                      &(new_item->revision),
                                       &(new_item->peg_revision),
+                                      &(new_item->revision),
                                       parent_dir_abspath,
                                       eb->timestamp_sleep, eb->ctx,
                                       scratch_pool));



Mime
View raw message