subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject svn commit: r1155313 - /subversion/trunk/subversion/bindings/ctypes-python/csvn/
Date Tue, 09 Aug 2011 11:28:11 GMT
Author: julianfoad
Date: Tue Aug  9 11:28:11 2011
New Revision: 1155313

Remove unused broken code in the ctypes-python bindings.

* subversion/bindings/ctypes-python/csvn/
  (_fs): Remove the txn() method, which was unused and referred to
    '_fs_root' which doesn't exist. Thus avoid storing a reference to the
    'repos' object during __init__(), which was a circular reference because
    this '_fs' object is itself stored within the 'repos' object.


Modified: subversion/trunk/subversion/bindings/ctypes-python/csvn/
--- subversion/trunk/subversion/bindings/ctypes-python/csvn/ (original)
+++ subversion/trunk/subversion/bindings/ctypes-python/csvn/ Tue Aug  9 11:28:11 2011
@@ -541,7 +541,6 @@ class _fs(object):
        This class represents an svn_fs_t object"""
     def __init__(self, repos):
-        self.repos = repos
         self.iterpool = Pool()
         self._as_parameter_ = svn_repos_fs(repos)
@@ -572,13 +571,6 @@ class _fs(object):
            temporary allocations."""
         return _fs_root(self, rev, txn, pool, iterpool)
-    def txn(self, message, base_rev=None):
-        """Open a new transaction for commit to the specified
-           repository, assuming that our data is up to date as
-           of base_rev. Setup the author and commit message
-           revprops."""
-        return _fs_txn(self.repos, message, base_rev)
 class _fs_root(object):
     """NOTE: This is a private class. Don't use it outside of
        this module. Use the Repos.txn() method instead.

View raw message