Return-Path: X-Original-To: apmail-subversion-commits-archive@minotaur.apache.org Delivered-To: apmail-subversion-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5BD356782 for ; Sat, 9 Jul 2011 00:56:06 +0000 (UTC) Received: (qmail 71363 invoked by uid 500); 9 Jul 2011 00:56:06 -0000 Delivered-To: apmail-subversion-commits-archive@subversion.apache.org Received: (qmail 71298 invoked by uid 500); 9 Jul 2011 00:56:05 -0000 Mailing-List: contact commits-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@subversion.apache.org Delivered-To: mailing list commits@subversion.apache.org Received: (qmail 71291 invoked by uid 99); 9 Jul 2011 00:56:05 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Jul 2011 00:56:05 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Jul 2011 00:56:02 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id E822F2388980 for ; Sat, 9 Jul 2011 00:55:41 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1144562 - /subversion/branches/revprop-packing/subversion/libsvn_fs_fs/fs_fs.c Date: Sat, 09 Jul 2011 00:55:41 -0000 To: commits@subversion.apache.org From: danielsh@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20110709005541.E822F2388980@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: danielsh Date: Sat Jul 9 00:55:41 2011 New Revision: 1144562 URL: http://svn.apache.org/viewvc?rev=1144562&view=rev Log: On the revprop-packing branch: Fix a memory overread bug parsing the manifest. * subversion/libsvn_fs_fs/fs_fs.c (revision_proplist): Terminate BUF by NUL. Modified: subversion/branches/revprop-packing/subversion/libsvn_fs_fs/fs_fs.c Modified: subversion/branches/revprop-packing/subversion/libsvn_fs_fs/fs_fs.c URL: http://svn.apache.org/viewvc/subversion/branches/revprop-packing/subversion/libsvn_fs_fs/fs_fs.c?rev=1144562&r1=1144561&r2=1144562&view=diff ============================================================================== --- subversion/branches/revprop-packing/subversion/libsvn_fs_fs/fs_fs.c (original) +++ subversion/branches/revprop-packing/subversion/libsvn_fs_fs/fs_fs.c Sat Jul 9 00:55:41 2011 @@ -3264,6 +3264,7 @@ revision_proplist(apr_hash_t **proplist_ /* Read the revprop offset. */ SVN_ERR(svn_stream_read(svn_stream_from_aprfile2(pack_file, TRUE, pool), buf, &len)); + buf[len] = '\0'; /* Seek to the revprop offset, and read the props. */ offset = REVPROP_MANIFEST_FIELD_WIDTH * ffd->max_files_per_dir