subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject svn commit: r1148374 - /subversion/trunk/subversion/libsvn_subr/dso.c
Date Tue, 19 Jul 2011 14:58:56 GMT
Author: stsp
Date: Tue Jul 19 14:58:55 2011
New Revision: 1148374

Wrap a debug fprintf() call added in r877783 in #if 0 instead of SVN_DEBUG.

Initially added by Arfrever in r877783, it was amended by Julian and
Greg in r879959 and r879960 to use SVN_DBG() instead of fprintf() to
work around test suite failures. It was later flipped back to fprintf()
by Arfrever in r880496 for an unspecified reason.

The error message printed, in my case, was 'File not found' on a single
line, with no context information whatsoever. This is very irritating.

* subversion/libsvn_subr/dso.c
  (svn_dso_load): Don't print a confusing error message to stderr.
   The message is only useful for people who want to debug the dso loading
   code, not everyone compiling debug builds.


Modified: subversion/trunk/subversion/libsvn_subr/dso.c
--- subversion/trunk/subversion/libsvn_subr/dso.c (original)
+++ subversion/trunk/subversion/libsvn_subr/dso.c Tue Jul 19 14:58:55 2011
@@ -105,7 +105,7 @@ svn_dso_load(apr_dso_handle_t **dso, con
       status = apr_dso_load(dso, fname, dso_pool);
       if (status)
-#ifdef SVN_DEBUG
+#if 0
           char buf[1024];
           fprintf(stderr, "%s\n", apr_dso_error(*dso, buf, 1024));

View raw message