Return-Path: X-Original-To: apmail-subversion-commits-archive@minotaur.apache.org Delivered-To: apmail-subversion-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1DEA56DAC for ; Mon, 20 Jun 2011 22:38:25 +0000 (UTC) Received: (qmail 77987 invoked by uid 500); 20 Jun 2011 22:38:25 -0000 Delivered-To: apmail-subversion-commits-archive@subversion.apache.org Received: (qmail 77955 invoked by uid 500); 20 Jun 2011 22:38:25 -0000 Mailing-List: contact commits-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@subversion.apache.org Delivered-To: mailing list commits@subversion.apache.org Received: (qmail 77948 invoked by uid 99); 20 Jun 2011 22:38:24 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Jun 2011 22:38:24 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Jun 2011 22:38:24 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id C3F0C23889DA; Mon, 20 Jun 2011 22:38:03 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1137808 - /subversion/trunk/subversion/libsvn_fs_fs/rep-cache.c Date: Mon, 20 Jun 2011 22:38:03 -0000 To: commits@subversion.apache.org From: philip@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20110620223803.C3F0C23889DA@eris.apache.org> Author: philip Date: Mon Jun 20 22:38:03 2011 New Revision: 1137808 URL: http://svn.apache.org/viewvc?rev=1137808&view=rev Log: * subversion/libsvn_fs_fs/rep-cache.c (svn_fs_fs__set_rep_reference): Tweak comments. Modified: subversion/trunk/subversion/libsvn_fs_fs/rep-cache.c Modified: subversion/trunk/subversion/libsvn_fs_fs/rep-cache.c URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_fs/rep-cache.c?rev=1137808&r1=1137807&r2=1137808&view=diff ============================================================================== --- subversion/trunk/subversion/libsvn_fs_fs/rep-cache.c (original) +++ subversion/trunk/subversion/libsvn_fs_fs/rep-cache.c Mon Jun 20 22:38:03 2011 @@ -178,10 +178,10 @@ svn_fs_fs__set_rep_reference(svn_fs_t *f svn_error_clear(err); - /* Check to see if we already have a mapping for - REP->SHA1_CHECKSUM. If so, and the value is the same one we - were about to write, that's cool -- just do nothing. If, - however, the value is *different*, that's a red flag! */ + /* Constraint failed so the mapping for SHA1_CHECKSUM->REP + should exist. If so, and the value is the same one we were + about to write, that's cool -- just do nothing. If, however, + the value is *different*, that's a red flag! */ SVN_ERR(svn_fs_fs__get_rep_reference(&old_rep, fs, rep->sha1_checksum, pool)); @@ -207,6 +207,10 @@ svn_fs_fs__set_rep_reference(svn_fs_t *f else return SVN_NO_ERROR; } + + /* Something really odd at this point, we failed to insert the + checksum AND failed to read an existing checksum. Do we need + to flag this? */ } return SVN_NO_ERROR;