Return-Path: 
 <commits-return-12884-apmail-subversion-commits-archive=subversion.apache.org@subversion.apache.org>
X-Original-To: apmail-subversion-commits-archive@minotaur.apache.org
Delivered-To: apmail-subversion-commits-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id E3F824380
	for <apmail-subversion-commits-archive@minotaur.apache.org>;
 Mon,  6 Jun 2011 09:17:34 +0000 (UTC)
Received: (qmail 48578 invoked by uid 500); 6 Jun 2011 09:17:34 -0000
Delivered-To: apmail-subversion-commits-archive@subversion.apache.org
Received: (qmail 48517 invoked by uid 500); 6 Jun 2011 09:17:34 -0000
Mailing-List: contact commits-help@subversion.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@subversion.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@subversion.apache.org>
List-Post: <mailto:commits@subversion.apache.org>
List-Id: <commits.subversion.apache.org>
Reply-To: dev@subversion.apache.org
Delivered-To: mailing list commits@subversion.apache.org
Received: (qmail 48416 invoked by uid 99); 6 Jun 2011 09:17:34 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Jun 2011 09:17:34 +0000
X-ASF-Spam-Status: No, hits=-0.0 required=5.0
	tests=RCVD_IN_DNSWL_LOW,SPF_NEUTRAL
X-Spam-Check-By: apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Received: from [74.125.82.47] (HELO mail-ww0-f47.google.com) (74.125.82.47)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Jun 2011 09:17:26 +0000
Received: by wwk4 with SMTP id 4so2884059wwk.16
        for <multiple recipients>; Mon, 06 Jun 2011 02:17:05 -0700 (PDT)
Received: by 10.227.204.205 with SMTP id fn13mr4684123wbb.10.1307351824928;
        Mon, 06 Jun 2011 02:17:04 -0700 (PDT)
Received: from [192.168.1.5]
 (cpc3-newt6-0-0-cust796.newt.cable.virginmedia.com [82.32.203.29])
        by mx.google.com with ESMTPS id ej7sm2714182wbb.36.2011.06.06.02.17.03
        (version=SSLv3 cipher=OTHER);
        Mon, 06 Jun 2011 02:17:04 -0700 (PDT)
Subject: Re: svn commit: r1131442 -
 /subversion/trunk/tools/client-side/svnmucc/svnmucc.c
From: Julian Foad <julian.foad@wandisco.com>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: Bert Huijben <bert@qqmail.nl>, dev@subversion.apache.org,
 commits@subversion.apache.org
In-Reply-To: <20110604174241.GA20853@daniel3.local>
References: <20110604171247.84E6823889ED@eris.apache.org>
	 <00f101cc22dc$8e019680$aa04c380$@qqmail.nl>
	 <20110604174241.GA20853@daniel3.local>
Content-Type: text/plain; charset="UTF-8"
Date: Mon, 06 Jun 2011 10:17:01 +0100
Message-ID: <1307351821.20888.2478.camel@edith>
Mime-Version: 1.0
X-Mailer: Evolution 2.30.3 
Content-Transfer-Encoding: 7bit

On Sat, 2011-06-04, Daniel Shahaf wrote:
> Bert Huijben wrote on Sat, Jun 04, 2011 at 19:26:33 +0200:
> > > -----Original Message-----
> > > From: danielsh@apache.org [mailto:danielsh@apache.org]
> > > Log:
> > > * tools/client-side/svnmucc/svnmucc.c
> > >   (main): Allow for leading 'r' when parsing the revnum in the 'cp' action.

> > > +              while (*rev_str == 'r')
> > > +                ++rev_str;
> > 
> > Why do you allow rrrrrrrrr12 ?
> > 
> > I think it should just error out here if you pass more than one r.
> 
> Because svn allows multiple 'r's too without erroring.

FWIW the original reasoning is in Karl's comment in parse_one_rev():

  /* Allow any number of 'r's to prefix a revision number, because
     that way if a script pastes svn output into another svn command
     (like "svn log -r${REV_COPIED_FROM_OUTPUT}"), it'll Just Work,
     even when compounded.

I guess that means "even if one script, when given 'r123' as input, were
to print 'rr123' as output, then we could still pass in that output as
'-r rr123' and it would still work".

It seems bogus (unnecessary) to me.

- Julian