subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <...@daniel.shahaf.name>
Subject Re: svn commit: r1131442 - /subversion/trunk/tools/client-side/svnmucc/svnmucc.c
Date Sat, 04 Jun 2011 17:42:41 GMT
Bert Huijben wrote on Sat, Jun 04, 2011 at 19:26:33 +0200:
> 
> 
> > -----Original Message-----
> > From: danielsh@apache.org [mailto:danielsh@apache.org]
> > Sent: zaterdag 4 juni 2011 19:13
> > To: commits@subversion.apache.org
> > Subject: svn commit: r1131442 - /subversion/trunk/tools/client-
> > side/svnmucc/svnmucc.c
> > 
> > Author: danielsh
> > Date: Sat Jun  4 17:12:47 2011
> > New Revision: 1131442
> > 
> > URL: http://svn.apache.org/viewvc?rev=1131442&view=rev
> > Log:
> > * tools/client-side/svnmucc/svnmucc.c
> >   (main): Allow for leading 'r' when parsing the revnum in the 'cp' action.
> > 
> > Modified:
> >     subversion/trunk/tools/client-side/svnmucc/svnmucc.c
> > 
> > Modified: subversion/trunk/tools/client-side/svnmucc/svnmucc.c
> > URL: http://svn.apache.org/viewvc/subversion/trunk/tools/client-
> > side/svnmucc/svnmucc.c?rev=1131442&r1=1131441&r2=1131442&view=diff
> > ==========================================================
> > ====================
> > --- subversion/trunk/tools/client-side/svnmucc/svnmucc.c (original)
> > +++ subversion/trunk/tools/client-side/svnmucc/svnmucc.c Sat Jun  4
> > 17:12:47 2011
> > @@ -1006,6 +1006,10 @@ main(int argc, const char **argv)
> >            else
> >              {
> >                char *end;
> > +
> > +              while (*rev_str == 'r')
> > +                ++rev_str;
> > +
> 
> Why do you allow rrrrrrrrr12 ?
> 
> >                action->rev = strtol(rev_str, &end, 0);
> >                if (*end)
> >                  handle_error(svn_error_createf(SVN_ERR_INCORRECT_PARAMS,
> > NULL,
> > 
> 
> 
> I think it should just error out here if you pass more than one r.
> 

Because svn allows multiple 'r's too without erroring.

> 	Bert
> 

Mime
View raw message