subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Julian Foad <julian.f...@wandisco.com>
Subject Re: svn commit: r1131442 - /subversion/trunk/tools/client-side/svnmucc/svnmucc.c
Date Mon, 06 Jun 2011 09:17:01 GMT
On Sat, 2011-06-04, Daniel Shahaf wrote:
> Bert Huijben wrote on Sat, Jun 04, 2011 at 19:26:33 +0200:
> > > -----Original Message-----
> > > From: danielsh@apache.org [mailto:danielsh@apache.org]
> > > Log:
> > > * tools/client-side/svnmucc/svnmucc.c
> > >   (main): Allow for leading 'r' when parsing the revnum in the 'cp' action.

> > > +              while (*rev_str == 'r')
> > > +                ++rev_str;
> > 
> > Why do you allow rrrrrrrrr12 ?
> > 
> > I think it should just error out here if you pass more than one r.
> 
> Because svn allows multiple 'r's too without erroring.

FWIW the original reasoning is in Karl's comment in parse_one_rev():

  /* Allow any number of 'r's to prefix a revision number, because
     that way if a script pastes svn output into another svn command
     (like "svn log -r${REV_COPIED_FROM_OUTPUT}"), it'll Just Work,
     even when compounded.

I guess that means "even if one script, when given 'r123' as input, were
to print 'rr123' as output, then we could still pass in that output as
'-r rr123' and it would still work".

It seems bogus (unnecessary) to me.

- Julian



Mime
View raw message