Return-Path: 
 <commits-return-12167-apmail-subversion-commits-archive=subversion.apache.org@subversion.apache.org>
X-Original-To: apmail-subversion-commits-archive@minotaur.apache.org
Delivered-To: apmail-subversion-commits-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 77E314F88
	for <apmail-subversion-commits-archive@minotaur.apache.org>;
 Tue, 17 May 2011 14:48:34 +0000 (UTC)
Received: (qmail 26411 invoked by uid 500); 17 May 2011 14:48:34 -0000
Delivered-To: apmail-subversion-commits-archive@subversion.apache.org
Received: (qmail 26372 invoked by uid 500); 17 May 2011 14:48:34 -0000
Mailing-List: contact commits-help@subversion.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@subversion.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@subversion.apache.org>
List-Post: <mailto:commits@subversion.apache.org>
List-Id: <commits.subversion.apache.org>
Reply-To: dev@subversion.apache.org
Delivered-To: mailing list commits@subversion.apache.org
Received: (qmail 26359 invoked by uid 99); 17 May 2011 14:48:34 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 May 2011 14:48:34 +0000
X-ASF-Spam-Status: No, hits=-0.7 required=5.0
	tests=RCVD_IN_DNSWL_LOW,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: local policy)
Received: from [66.111.4.27] (HELO out3.smtp.messagingengine.com)
 (66.111.4.27)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 May 2011 14:48:27 +0000
Received: from compute3.internal (compute3.nyi.mail.srv.osa [10.202.2.43])
	by gateway1.messagingengine.com (Postfix) with ESMTP id 953D6207F0;
	Tue, 17 May 2011 10:48:06 -0400 (EDT)
Received: from frontend1.messagingengine.com ([10.202.2.160])
  by compute3.internal (MEProxy); Tue, 17 May 2011 10:48:06 -0400
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=messagingengine.com;
 h=date:from:to:cc:subject:message-id:references:mime-version:content-type:in-reply-to;
 s=smtpout; bh=G3PDTk35AYPi+2Ga58LoY/3RyB0=;
 b=UuyKaLHTqNIMXGtyEvz8Ms4X9Wxuqj4oWCp+tOE+vTgSTIZSgxyjso4yTKXvln/Zr6HRFRbb58BB7RXRAwpBiJJWbJif2Imp4p/oUjncHMpVJ/ka/y66MYDS4AnBZARhw0LI0mk8cJVPEm+w29zhv4uR0Hbg0m9Hc9043vOCbQg=
X-Sasl-enc: VO0vyDUIb+laKnlMof+B/DoLl66C9RQlGp8Kh6UdQ4wYBcGR4jAW877ZcdeFDg
 1305643686
Received: from lp-shahaf.local (i59F7870A.versanet.de [89.247.135.10])
	by mail.messagingengine.com (Postfix) with ESMTPSA id CFEF9406E98;
	Tue, 17 May 2011 10:48:05 -0400 (EDT)
Date: Tue, 17 May 2011 16:46:05 +0200
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: dev@subversion.apache.org
Cc: commits@subversion.apache.org
Subject: Re: svn commit: r1101738 - in
	/subversion/trunk/subversion/libsvn_wc: wc-queries.sql wc_db.c
Message-ID: <20110517144605.GA14326@lp-shahaf.local>
References: <20110511040657.DADF72388A19@eris.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110511040657.DADF72388A19@eris.apache.org>
User-Agent: Mutt/1.5.18 (2008-05-17)

gstein@apache.org wrote on Wed, May 11, 2011 at 04:06:57 -0000:
> +static svn_error_t *
> +with_finalization(void *baton,

@a BATON is unused.

Could you add a docstring please?  It seems that you call TXN_CB within
a txn, then call WORK_CB (odd name IMO) with NOTIFY_FUNC, then run
the FINALIZE_IDXth statement...