subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hyrum K Wright <hy...@hyrumwright.org>
Subject Re: svn commit: r1125327 - /subversion/trunk/subversion/svndumpfilter/main.c
Date Fri, 20 May 2011 22:36:29 GMT
This may be picking nits, but is the format for size_t and apr_size_t
guaranteed to be the same on all platforms?

-Hyrum

On Fri, May 20, 2011 at 4:17 AM,  <philip@apache.org> wrote:
> Author: philip
> Date: Fri May 20 11:17:58 2011
> New Revision: 1125327
>
> URL: http://svn.apache.org/viewvc?rev=1125327&view=rev
> Log:
> * subversion/svndumpfilter/main.c
>  (write_prop_to_stringbuf): Followup to r1125288, make format match type.
>
> Modified:
>    subversion/trunk/subversion/svndumpfilter/main.c
>
> Modified: subversion/trunk/subversion/svndumpfilter/main.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/svndumpfilter/main.c?rev=1125327&r1=1125326&r2=1125327&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/svndumpfilter/main.c (original)
> +++ subversion/trunk/subversion/svndumpfilter/main.c Fri May 20 11:17:58 2011
> @@ -90,7 +90,7 @@ write_prop_to_stringbuf(svn_stringbuf_t
>   namelen = strlen(name);
>   svn_stringbuf_appendbytes(*strbuf, "K ", 2);
>
> -  bytes_used = apr_snprintf(buf, sizeof(buf), "%d", namelen);
> +  bytes_used = apr_snprintf(buf, sizeof(buf), "%" APR_SIZE_T_FMT, namelen);
>   svn_stringbuf_appendbytes(*strbuf, buf, bytes_used);
>   svn_stringbuf_appendbyte(*strbuf, '\n');
>
>
>
>

Mime
View raw message