subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Julian Foad <julian.f...@wandisco.com>
Subject Re: svn commit: r1101091 - /subversion/trunk/subversion/libsvn_subr/cache-membuffer.c
Date Mon, 09 May 2011 16:40:58 GMT
stefan2@apache.org wrote:
> * subversion/libsvn_subr/cache-membuffer.c
>   (MIN_SEGMENT_SIZE): ensure that cache sizes > 4GB work
>   (svn_cache__membuffer_cache_create): formatting fixes; add missing cast

>    /* allocate cache as an array of segments / cache objects */
> -  c = apr_palloc(pool, segment_count * sizeof(*c));
> +  c = (svn_membuffer_t *)apr_palloc(pool, segment_count * sizeof(*c));

Hi Stefan.  In contrast to C++, in C it's a handy convenience that we
don't need to cast "void *" pointers before assigning them.  This is the
only such cast in the code base.

- Julian




Mime
View raw message