subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <...@daniel.shahaf.name>
Subject Re: svn commit: r979002 - in /subversion/branches/svnrload/subversion/svnrload: ./ load_editor.c load_editor.h parse_dumpstream.c svnrload.c
Date Sun, 25 Jul 2010 09:53:41 GMT
artagnon@apache.org wrote on Sun, 25 Jul 2010 at 11:44 -0000:
> Author: artagnon
> Date: Sun Jul 25 08:44:21 2010
> New Revision: 979002
> 
> URL: http://svn.apache.org/viewvc?rev=979002&view=rev
> Log:
> Add svnrload: currently a heavy WIP, with most of the code imported
> from svnrdump
> 
> * subversion/svnrload
> * subversion/svnrload/load_editor.c: From svnrdump/dump_editor.c
> * subversion/svnrload/svnrload.c: From svnrdump/svnrdump.c
> * subversion/svnrload/load_editor.h: From svnrdump/dump_editor.h
> * subversion/svnrload/parse_dumpstream.c: Functionality to parse a
>   dumpstream
> 
> Added:
>     subversion/branches/svnrload/subversion/svnrload/
>     subversion/branches/svnrload/subversion/svnrload/load_editor.c
>     subversion/branches/svnrload/subversion/svnrload/load_editor.h
>     subversion/branches/svnrload/subversion/svnrload/parse_dumpstream.c
>     subversion/branches/svnrload/subversion/svnrload/svnrload.c
> 
> Added: subversion/branches/svnrload/subversion/svnrload/load_editor.c
> URL: http://svn.apache.org/viewvc/subversion/branches/svnrload/subversion/svnrload/load_editor.c?rev=979002&view=auto
> ==============================================================================
> --- subversion/branches/svnrload/subversion/svnrload/load_editor.c (added)
> +++ subversion/branches/svnrload/subversion/svnrload/load_editor.c Sun Jul 25 08:44:21
2010
> @@ -0,0 +1,780 @@
> +/*
> + *  dump_editor.c: The svn_delta_editor_t editor used by svnrdump
> + *

Wrong header.

And, by the way, the new files you added were added "without history";
was that a concious decision, or were you not aware of the option to add
them with copyfrom information?

i.e., you could have done 'svn cp ../svnrdump/svnrdump.c svnrload.c',
and similarly for the other files.  The benefits of this would be
reviewability (the diff would be far shorter than the current 1533
lines) and historical linkage (future 'svn log', and other, commands
would trace through the copy).

Daniel
(not reviewing the rest of this; 1533 lines is too much)

Mime
View raw message