Return-Path: Delivered-To: apmail-subversion-commits-archive@minotaur.apache.org Received: (qmail 33556 invoked from network); 23 Apr 2010 23:49:49 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 23 Apr 2010 23:49:49 -0000 Received: (qmail 8032 invoked by uid 500); 23 Apr 2010 23:49:49 -0000 Delivered-To: apmail-subversion-commits-archive@subversion.apache.org Received: (qmail 8008 invoked by uid 500); 23 Apr 2010 23:49:49 -0000 Mailing-List: contact commits-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@subversion.apache.org Delivered-To: mailing list commits@subversion.apache.org Received: (qmail 8001 invoked by uid 99); 23 Apr 2010 23:49:49 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Apr 2010 23:49:49 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Apr 2010 23:49:47 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 21ADC23888EC; Fri, 23 Apr 2010 23:49:04 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r937554 - /subversion/trunk/subversion/include/private/svn_skel.h Date: Fri, 23 Apr 2010 23:49:04 -0000 To: commits@subversion.apache.org From: gstein@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20100423234904.21ADC23888EC@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: gstein Date: Fri Apr 23 23:49:03 2010 New Revision: 937554 URL: http://svn.apache.org/viewvc?rev=937554&view=rev Log: Update docstring to warn about gotchas. * subversion/include/private/svn_skel.h: (svn_skel_append): add hints Modified: subversion/trunk/subversion/include/private/svn_skel.h Modified: subversion/trunk/subversion/include/private/svn_skel.h URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/private/svn_skel.h?rev=937554&r1=937553&r2=937554&view=diff ============================================================================== --- subversion/trunk/subversion/include/private/svn_skel.h (original) +++ subversion/trunk/subversion/include/private/svn_skel.h Fri Apr 23 23:49:03 2010 @@ -138,7 +138,10 @@ svn_skel_t *svn_skel__make_empty_list(ap void svn_skel__prepend(svn_skel_t *skel, svn_skel_t *list); -/* Append SKEL to LIST. */ +/* Append SKEL to LIST. Note: this must traverse the LIST, so you + generally want to use svn_skel__prepend(). + + NOTE: careful of the argument order here. */ void svn_skel__append(svn_skel_t *list, const svn_skel_t *skel);