Return-Path: Delivered-To: apmail-subversion-commits-archive@minotaur.apache.org Received: (qmail 96935 invoked from network); 14 Mar 2010 11:41:10 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 14 Mar 2010 11:41:10 -0000 Received: (qmail 8608 invoked by uid 500); 14 Mar 2010 11:40:27 -0000 Delivered-To: apmail-subversion-commits-archive@subversion.apache.org Received: (qmail 8588 invoked by uid 500); 14 Mar 2010 11:40:27 -0000 Mailing-List: contact commits-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@subversion.apache.org Delivered-To: mailing list commits@subversion.apache.org Received: (qmail 8581 invoked by uid 99); 14 Mar 2010 11:40:27 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 14 Mar 2010 11:40:27 +0000 X-ASF-Spam-Status: No, hits=-1001.3 required=10.0 tests=ALL_TRUSTED,AWL X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 14 Mar 2010 11:40:26 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 52C1123888BD; Sun, 14 Mar 2010 11:40:06 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r922816 - /subversion/trunk/subversion/libsvn_ra_svn/client.c Date: Sun, 14 Mar 2010 11:40:06 -0000 To: commits@subversion.apache.org From: stsp@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20100314114006.52C1123888BD@eris.apache.org> Author: stsp Date: Sun Mar 14 11:40:05 2010 New Revision: 922816 URL: http://svn.apache.org/viewvc?rev=922816&view=rev Log: Revert r922533. As discussed with Bert, suggesting the default config file location can be more misleading then helpful, depending on the client setup. So we'll just assume that people know what we mean when we talk about the "Subversion configuration file". Modified: subversion/trunk/subversion/libsvn_ra_svn/client.c Modified: subversion/trunk/subversion/libsvn_ra_svn/client.c URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_svn/client.c?rev=922816&r1=922815&r2=922816&view=diff ============================================================================== --- subversion/trunk/subversion/libsvn_ra_svn/client.c (original) +++ subversion/trunk/subversion/libsvn_ra_svn/client.c Sun Mar 14 11:40:05 2010 @@ -519,28 +519,12 @@ static svn_error_t *make_tunnel(const ch *conn = svn_ra_svn_create_conn(NULL, proc->out, proc->in, pool); err = svn_ra_svn_skip_leading_garbage(*conn, pool); if (err) - { - svn_error_t *err2; - const char *config_path; + return svn_error_quick_wrap( + err, + _("To better debug SSH connection problems, remove the -q " + "option from 'ssh' in the [tunnels] section of your " + "Subversion configuration file.")); - err2 = svn_config_get_user_config_path(&config_path, NULL, - SVN_CONFIG_CATEGORY_CONFIG, pool); - if (err2) - return svn_error_compose_create(err, err2); - else - { - const char *msg; - msg = apr_psprintf( - pool, - _("Subversion runs SSH with the -q option by default. " - "This may suppress some SSH error messages. " - "To better debug SSH connection problems, set " - "'ssh = $SVN_SSH ssh' (without a -q option) " - "in the [tunnels] section of %s"), - config_path); - return svn_error_quick_wrap(err, msg); - } - } return SVN_NO_ERROR; }