subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From julianf...@apache.org
Subject svn commit: r927959 - in /subversion/trunk/subversion: include/svn_wc.h libsvn_wc/wc.h
Date Fri, 26 Mar 2010 16:37:15 GMT
Author: julianfoad
Date: Fri Mar 26 16:37:14 2010
New Revision: 927959

URL: http://svn.apache.org/viewvc?rev=927959&view=rev
Log:
Add some queries in two doc strings.

* subversion/include/svn_wc.h
  (svn_wc_queue_committed3): Add some queries in the doc string.

* subversion/libsvn_wc/wc.h
  (svn_wc__process_committed_internal): Add some queries in the doc string.

Modified:
    subversion/trunk/subversion/include/svn_wc.h
    subversion/trunk/subversion/libsvn_wc/wc.h

Modified: subversion/trunk/subversion/include/svn_wc.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_wc.h?rev=927959&r1=927958&r2=927959&view=diff
==============================================================================
--- subversion/trunk/subversion/include/svn_wc.h (original)
+++ subversion/trunk/subversion/include/svn_wc.h Fri Mar 26 16:37:14 2010
@@ -4755,8 +4755,9 @@ svn_wc_committed_queue_create(apr_pool_t
  * If non-NULL, @a wcprop_changes is an array of <tt>svn_prop_t *</tt>
  * changes to wc properties; if an #svn_prop_t->value is NULL, then
  * that property is deleted.
- *   ### A prop whose value is NULL is ignored, not deleted.  (Maybe this
- *   ### isn't a set of changes but rather the new complete set of props?)
+ *   ### [JAF]  No, a prop whose value is NULL is ignored, not deleted.  This
+ *   ### seems to be not a set of changes but rather the new complete set of
+ *   ### props.  And it's renamed to 'new_dav_cache' inside; why?
  *
  * If @a remove_lock is @c TRUE, any entryprops related to a repository
  * lock will be removed.
@@ -4767,6 +4768,8 @@ svn_wc_committed_queue_create(apr_pool_t
  * If @a local_abspath is a file and @a checksum is non-NULL, use @a checksum
  * as the checksum for the new text base. Otherwise, calculate the checksum
  * if needed.
+ *   ### [JAF]  No, it doesn't calculate the checksum, it stores null in wc.db:
+ *   ### see svn_wc__process_committed_internal().
  *
  * If @a recurse is TRUE and @a local_abspath is a directory, then bump every
  * versioned object at or under @a path.  This is usually done for

Modified: subversion/trunk/subversion/libsvn_wc/wc.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_wc/wc.h?rev=927959&r1=927958&r2=927959&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_wc/wc.h (original)
+++ subversion/trunk/subversion/libsvn_wc/wc.h Fri Mar 26 16:37:14 2010
@@ -204,6 +204,8 @@ svn_wc__get_committed_queue_pool(const s
  *
  * @a new_dav_cache is a hash of dav property changes to be made to
  * the @a local_abspath.
+ *   ### [JAF]  Is it? See svn_wc_queue_committed3(). It ends up being
+ *   ### assigned as a whole to wc.db:BASE_NODE:dav_cache.
  *
  * If @a no_unlock is set, don't release any user locks on @a
  * local_abspath; otherwise release them as part of this processing.
@@ -214,6 +216,7 @@ svn_wc__get_committed_queue_pool(const s
  * If @a local_abspath is a file and @a checksum is non-NULL, use @a checksum
  * as the checksum for the new text base. Otherwise, calculate the checksum
  * if needed.
+ *   ### [JAF]  No, it doesn't calculate the checksum, it stores null in wc.db.
  */
 svn_error_t *
 svn_wc__process_committed_internal(svn_wc__db_t *db,



Mime
View raw message