subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cmpil...@apache.org
Subject svn commit: r905705 - /subversion/trunk/subversion/libsvn_ra_serf/util.c
Date Tue, 02 Feb 2010 16:55:03 GMT
Author: cmpilato
Date: Tue Feb  2 16:54:58 2010
New Revision: 905705

URL: http://svn.apache.org/viewvc?rev=905705&view=rev
Log:
Back in r894014, we started using serf_request_bucket_request_create()
to create request buckets.  That function adds a "Host" header, so the
fix in r896247 to stop adding our own "Host" header when using Serf
0.4.0 or better was incomplete -- we should never be adding our own
"Host" header.

(lgo is planning to document this fact in the Serf API, too.)

* subversion/libsvn_ra_serf/util.c
  (svn_ra_serf__setup_serf_req): Unconditionally stop adding "Host"
    headers.

Modified:
    subversion/trunk/subversion/libsvn_ra_serf/util.c

Modified: subversion/trunk/subversion/libsvn_ra_serf/util.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/util.c?rev=905705&r1=905704&r2=905705&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/util.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/util.c Tue Feb  2 16:54:58 2010
@@ -504,14 +504,13 @@
 {
   serf_bucket_t *hdrs_bkt;
 
+  /* Create a request bucket.  Note that this sucker is kind enough to
+     add a "Host" header for us.  */
   *req_bkt =
     serf_request_bucket_request_create(request, method, url, body_bkt,
                                        serf_request_get_alloc(request));
 
   hdrs_bkt = serf_bucket_request_get_headers(*req_bkt);
-#if ! SERF_VERSION_AT_LEAST(0, 4, 0)
-  serf_bucket_headers_setn(hdrs_bkt, "Host", conn->hostinfo);
-#endif
   serf_bucket_headers_setn(hdrs_bkt, "User-Agent", conn->useragent);
 
   if (content_type)



Mime
View raw message