submarine-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [submarine] yuanzac commented on a change in pull request #117: SUBMARINE-303. Submarine client submit job to submarine server by grpc.
Date Tue, 03 Dec 2019 09:20:48 GMT
yuanzac commented on a change in pull request #117: SUBMARINE-303. Submarine client submit
job to submarine server by grpc.
URL: https://github.com/apache/submarine/pull/117#discussion_r353061041
 
 

 ##########
 File path: bin/submarine-daemon.sh
 ##########
 @@ -36,9 +36,9 @@ cd ${BIN}/>/dev/null
 SUBMARINE_SERVER_NAME="Submarine Server"
 SUBMARINE_SERVER_LOGFILE="${SUBMARINE_LOG_DIR}/submarine.log"
 SUBMARINE_SERVER_MAIN=org.apache.submarine.server.SubmarineServer
-JAVA_OPTS+=" -Dsubmarine.log.file=${SUBMARINE_SERVER_LOGFILE}"
+JAVA_OPTS+="${SUBMARINE_SERVER_JAVA_OPTS} ${SUBMARINE_SERVER_MEM} -Dsubmarine.log.file=${SUBMARINE_SERVER_LOGFILE}"
 
-add_jar_in_dir "${BIN}/../lib"
+add_each_jar_in_dir_recursive "${BIN}/../lib"
 
 Review comment:
   For now, let's just use ${BIN}/../lib, as I'm not sure about the conflicts with SUBMARINE_HOME
in submarine-env.sh
   @hhhizzz, If you have the bandwidth, help us to optimize it~

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org


Mime
View raw message