From user-return-219068-archive-asf-public=cust-asf.ponee.io@struts.apache.org Wed Aug 22 06:53:52 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5D93E180662 for ; Wed, 22 Aug 2018 06:53:52 +0200 (CEST) Received: (qmail 69465 invoked by uid 500); 22 Aug 2018 04:53:46 -0000 Mailing-List: contact user-help@struts.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Struts Users Mailing List" Reply-To: "Struts Users Mailing List" Delivered-To: mailing list user@struts.apache.org Received: (qmail 69454 invoked by uid 99); 22 Aug 2018 04:53:46 -0000 Received: from mail-relay.apache.org (HELO mailrelay1-lw-us.apache.org) (207.244.88.152) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Aug 2018 04:53:46 +0000 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id 246A24EEF for ; Wed, 22 Aug 2018 04:53:45 +0000 (UTC) Received: by mail-lj1-f172.google.com with SMTP id u83-v6so442229lje.12 for ; Tue, 21 Aug 2018 21:53:44 -0700 (PDT) X-Gm-Message-State: AOUpUlF4PGapSWCTomhbHeVt7vFwCT9ifkPVsGS1n8R8ayAO5iPE5p+P geSjqTlKJjr+Zj30qmiMQ338hAD5GR292htuuL4= X-Google-Smtp-Source: ANB0VdZ5BmspJO1bkIbWPHhj2EmmDFrC6r0erKwSh/Rrr9omo+Kz9Jznef+xqflwIRpwSz0Bue88bdEslhNaq6d7zgg= X-Received: by 2002:a2e:4089:: with SMTP id r9-v6mr4575790lje.2.1534913623632; Tue, 21 Aug 2018 21:53:43 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Lukasz Lenart Date: Wed, 22 Aug 2018 06:53:32 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Is HttpParameters Supposed to be Immutable To: Struts Users Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable wt., 21 sie 2018 o 18:32 Paul Zepernick napisa=C5=82(a): > Which is removing the parameter from the object, I would have expected th= at this return a modified copy? Yes, you are right. > Just wondering the intentions of the class, and if this should be logged = as a bug? I would say it's a bug. Raw http parameters are immutable by definition so this class should reflect the same behaviour, that was my intention. Feel free to register an issue and open a PR :) Regards --=20 =C5=81ukasz + 48 606 323 122 http://www.lenart.org.pl/ --------------------------------------------------------------------- To unsubscribe, e-mail: user-unsubscribe@struts.apache.org For additional commands, e-mail: user-help@struts.apache.org