Mailing-List: contact user-help@struts.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Struts Users Mailing List" <user@struts.apache.org>
MIME-Version: 1.0
In-Reply-To: <0ec060bb-db62-8da7-30cd-252a23eba037@uta.fi>
References: <0ec060bb-db62-8da7-30cd-252a23eba037@uta.fi>
From: Lukasz Lenart <lukaszlenart@apache.org>
Date: Sat, 11 Mar 2017 08:20:06 +0100
Message-ID: <CAMopvkNFEtKKf7YkBgf62re-c3dqbwYK07ECm164sW2_W_gF6Q@mail.gmail.com>
Subject: Re: Problem reading a resource file (migrating 2.3.29 --> 2.5.10)
To: Struts Users Mailing List <user@struts.apache.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
archived-at: Sat, 11 Mar 2017 07:20:30 -0000

2017-03-11 0:21 GMT+01:00 Heikki Hyyr=C3=B6 <heikki.hyyro@uta.fi>:
> Hi,
>
> I decided to migrate a Struts-based application from Struts 2.3.x to 2.5.=
x.
> The application worked without problems with Struts version 2.3.29. After
> updating to 2.5.10, the application no longer seems to be able to read a
> root-level resource file "package.properties": calling
> getText("some.needed.property") results in an exception.
>
> Since this problem did not happen with 2.3.29, I wonder if the 2.5.x
> versions have introduced a fundamental change in how the resource files a=
re
> handled? I was not able to find such information in the 2.3 --> 2.5
> migration guide.
>
> The problem occurs in the constructor of a database connection manager cl=
ass
> that tries to retrieve database information (driver information, database
> url, and so on) from package.properties. A rough sketch of the class is
> something like:
>
> public class DbConnectionManager extends ActionSupport
> {
>   private DbConnectionManager()
>   {
>     String driverNames =3D getText("database.drivers");  // This throws a=
n
> exception in 2.5.10, but was ok in 2.3.29.
>     ...
>   }
> }
>
> I suppose this problem could have something to do with the fact that this=
 is
> a singleton class that is initialized only once during the lifetime of th=
e
> application? If this is the case, then what would a simple way to fix the
> problem? A related question would be: how should I access resource files
> from a non-action context (e.g. read resources in static initialization),=
 if
> ActionSupport no longer permits it?

This is do the changes in ActionSupport's dependencies, you must
inject them first to have access to resource bundles.

Instead your approach with singleton you can use something like this

public class DbConnectionManager {

  public DbConnectionManager(@Inject TextProvider textProvider) {
    String driverNames =3D textProvider.getText("database.drivers");
    ...
  }
}

and then

public class MyAction extends ActionSupport {

  public String execute() {
    DbConnectionManager mgr =3D container.inject(DbConnectionManager.class)
    ....
  }
}

but perhaps the best option would be to disconnect your DAO layer from
Web layer, you have coupled two different layers which is a "bad
design" =E2=84=A2


Regards
--=20
=C5=81ukasz
+ 48 606 323 122 http://www.lenart.org.pl/

---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org