struts-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christian Grobmeier <grobme...@apache.org>
Subject Re: LocaleProvder not unique
Date Wed, 15 Mar 2017 08:49:41 GMT
thank you, will look at it and report on dev

On Wed, Mar 15, 2017, at 09:23, Lukasz Lenart wrote:
> Christian
> 
> Change is here https://github.com/apache/struts/pull/122
> 
> 2017-03-14 10:16 GMT+01:00 Lukasz Lenart <lukaszlenart@apache.org>:
> > Feel free to register an issue with your case
> >
> > 2017-03-14 10:13 GMT+01:00 Christian Grobmeier <grobmeier@apache.org>:
> >> Yes, actually I think you are right: LocaleProvider and TextProvider
> >> have both the same issue. It's just popping up for me with
> >> LocaleProvider first, but TextProvider will surely follow.
> >>
> >> I try to read more dev list again, so feel free to ping me whenever you
> >> want me to test/help
> >>
> >> On Tue, Mar 14, 2017, at 06:57, Lukasz Lenart wrote:
> >>> https://issues.apache.org/jira/browse/WW-4756
> >>>
> >>> I know that this is for TextProvider but the same approach I can use
> >>> for LocaleProvider
> >>>
> >>> 2017-03-14 6:53 GMT+01:00 Lukasz Lenart <lukaszlenart@apache.org>:
> >>> > 2017-03-13 21:51 GMT+01:00 Christian Grobmeier <grobmeier@apache.org>:
> >>> >> OK, using component scan i had success with using DefaultLocaleProvider
> >>> >> as default in my applicationContext.xml:
> >>> >> <bean name="localeProvider"
> >>> >> class="com.opensymphony.xwork2.DefaultLocaleProvider" primary="true"
/>
> >>> >>
> >>> >> (mind the primary)
> >>> >>
> >>> >> So far it makes halfway sense to me. A few tests fail still because
they
> >>> >> access getText and do no receive a context. Digging into this
> >>> >
> >>> > Hmm... I think I see your point and this is somehow aligned with what
> >>> > I want to do with TextProvider layer. I mean, there is already a
> >>> > TextProviderFactory that is used to create custom TextProviders so
I
> >>> > think I will used instead of TextProvider to inject as a dependency.
> >>> > This will allow to have TextProvider implemented by the ActionSupport
> >>> > and use TextProviderFactory as a dependency and there be type
> >>> > conflicts.
> >>> >
> >>> > Here is a first step to do so
> >>> > https://github.com/apache/struts/pull/121
> >>> >
> >>> > I will start another PR soon to replace TextProvider with
> >>> > TextProviderFactory, if you could test this approach it would be cool
> >>> > :)
> >>> >
> >>> >
> >>> > Regards
> >>> > --
> >>> > Ɓukasz
> >>> > + 48 606 323 122 http://www.lenart.org.pl/
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
> >>> For additional commands, e-mail: user-help@struts.apache.org
> >>>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
> >> For additional commands, e-mail: user-help@struts.apache.org
> >>
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
> For additional commands, e-mail: user-help@struts.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org


Mime
View raw message