Mailing-List: contact user-help@struts.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Struts Users Mailing List" <user@struts.apache.org>
Received-SPF: pass (nike.apache.org: local policy includes SPF record at
 spf.trusted-forwarder.org)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=btinternet.com;
  h=X-YMail-OSG:Received:X-Rocket-MIMEInfo:X-Mailer:References:Message-ID:Date:From:Reply-To:Subject:To:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding;
  b=bvzEpb9BNiEnHptsl7diyDKDA/d6Exj038J0USvjNpSD36o4XfTPUJbSXpJMMCJFmE3NZGopGHvY+D8X31SkUui9FXFBQ1xZ7hqYyPkRou9VbWaftC5Egp8jbs/slo8NX3bVTuOuAB0BVH4c42IHmbV/jC/IEGXriuChcbhY11c=;
References: <1397044856.17303.YahooMailNeo@web87801.mail.ir2.yahoo.com>
 <CAMopvkOvrCvdkeSSb_8h=HHM8G0k3pjv6HyO0ft2oK79c-eJ3w@mail.gmail.com>
 <CAMopvkNLMWiPMtL3E-_Qe3xvAR=ZMvyySe5tHNw_srjpK2U89A@mail.gmail.com>
 <1397055203.65024.YahooMailNeo@web87806.mail.ir2.yahoo.com>
 <CAMopvkPdKsgaOnwLRknB34RozpN5zL30bk4D+n5x41frkDPu7g@mail.gmail.com>
Message-ID: <1398155865.18888.YahooMailNeo@web87804.mail.ir2.yahoo.com>
Date: Tue, 22 Apr 2014 09:37:45 +0100 (BST)
From: Stuart James <ravenholm@btinternet.com>
Reply-To: Stuart James <ravenholm@btinternet.com>
Subject: Re: I would like help with the template theme changes in 2.3.16.1
To: Struts Users Mailing List <user@struts.apache.org>
In-Reply-To: 
 <CAMopvkPdKsgaOnwLRknB34RozpN5zL30bk4D+n5x41frkDPu7g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi Lukasz,=0AThat's a great solution, thanks for your assistance.=0A=0ARega=
rds=0ASteve=0A=0A=0A=0A=0A----- Original Message -----=0AFrom: Lukasz Lenar=
t <lukaszlenart@apache.org>=0ATo: Struts Users Mailing List <user@struts.ap=
ache.org>; Stuart James <ravenholm@btinternet.com>=0ACc: =0ASent: Monday, 1=
4 April 2014, 20:03=0ASubject: Re: I would like help with the template them=
e changes in 2.3.16.1=0A=0AI have posted the solution, you can simple add m=
issing templates by=0Adefining them under 'webapp/jquery/template'=0A=0A=0A=
Regards=0A-- =0A=C5=81ukasz=0A+ 48 606 323 122 http://www.lenart.org.pl/=0A=
=0A2014-04-09 16:53 GMT+02:00 Stuart James <ravenholm@btinternet.com>:=0A> =
Hi Lukasz,=0A> I have raised an issue=0A> https://issues.apache.org/jira/br=
owse/WW-4319=0A> and included an demo app.=0A> Please let me know if there =
are any problems with the demo.=0A>=0A> Thanks=0A> Steve=0A> ----- Original=
 Message -----=0A> From: Lukasz Lenart <lukaszlenart@apache.org>=0A> To: St=
ruts Users Mailing List <user@struts.apache.org>; Stuart James <ravenholm@b=
tinternet.com>=0A> Cc:=0A> Sent: Wednesday, 9 April 2014, 13:11=0A> Subject=
: Re: I would like help with the template theme changes in 2.3.16.1=0A>=0A>=
 And register an issue?=0A>=0A> 2014-04-09 14:10 GMT+02:00 Lukasz Lenart <l=
ukaszlenart@apache.org>:=0A>> Can you prepare a small Maven based demo app?=
=0A>>=0A>> 2014-04-09 14:00 GMT+02:00 Stuart James <ravenholm@btinternet.co=
m>:=0A>>> Hi,=0A>>> I am developing an application which has been predomina=
ntly written with Struts2 version 2.3.15.3 and the struts2-jquery-plugin ve=
rsion 3.6.1.=0A>>> I have recently upgraded to Struts2 version 2.3.16.1 and=
 struts2-jquery-plugin version 3.7.0.=0A>>> The application has used the cs=
s_xhtml theme throughout, defined in struts.xml.=0A>>> Since the upgrade, t=
he HTML markup of the struts2-jquery-plugin (sj:) components has been adver=
sly affected.=0A>>> I have debugged the application and found that the issu=
e is caused by the changes made to themes under WW-4145.=0A>>> The situatio=
n appears to be this:=0A>>> The struts2-jquery-plugin has implemented custo=
m tags for their components and these classes will return the value of 'jqu=
ery' in response to the getTheme() method. They do appear to correctly stor=
e a 'parentTheme' parameter with the correct value (in my case from the par=
ent form element) of 'css_xhtml'.=0A>>> The struts2-jquery-plugin custom te=
mplates are successfully found on the templates/jquery path, but some of th=
em contain 'include' statements, for example, the datepicker.ftl contains t=
he following snippet:=0A>>>=0A>>>=C2=A0 <#if parameters.parentTheme =3D=3D =
'css_xhtml'>=0A>>>=C2=A0 <#include "/${parameters.templateDir}/css_xhtml/co=
ntrolheader.ftl" />=0A>>>=C2=A0 </#if>=0A>>>=0A>>> So, at this point, all i=
s well, the correct controlheader.ftl template for the css_xhtml theme is f=
ound and included, however this template (now) contains the following inclu=
de:=0A>>>=0A>>> <#include "/${parameters.templateDir}/${parameters.expandTh=
eme}/controlheader-core.ftl">=0A>>>=0A>>> And this is where it starts to go=
 wrong. The ${parameters.expandTheme} resolves to '~~~jquery' and, after re=
ading the WW-4145 change info, I understand that this will cause the ThemeM=
anager to load the template from the parent theme as defined in the theme.p=
roperties file. This, in the case of the struts2-jquery-plugin, is defiend =
as 'xhtml' and NOT 'css_xhtml' as discovered from the parent form component=
. Consequently, the wrong controlheader-core.ftl template is included, and =
the resulting HTML includes incorrect <tr> and <td> tags which ultimately b=
reak the page.=0A>>>=0A>>> Other than hacking the templates, I cannot see a=
 satisfactory way of resolving this problem, so any assistance would be gra=
tefully received.=0A>>>=0A>>> Thanks=0A>>> Steve=0A>>>=0A>>> --------------=
-------------------------------------------------------=0A>>> To unsubscrib=
e, e-mail: user-unsubscribe@struts.apache.org=0A>>> For additional commands=
, e-mail: user-help@struts.apache.org=0A>>>=0A>=0A> -----------------------=
----------------------------------------------=0A> To unsubscribe, e-mail: =
user-unsubscribe@struts.apache.org=0A> For additional commands, e-mail: use=
r-help@struts.apache.org=0A>=0A> ------------------------------------------=
---------------------------=0A> To unsubscribe, e-mail: user-unsubscribe@st=
ruts.apache.org=0A> For additional commands, e-mail: user-help@struts.apach=
e.org=0A>=0A=0A------------------------------------------------------------=
---------=0ATo unsubscribe, e-mail: user-unsubscribe@struts.apache.org=0AFo=
r additional commands, e-mail: user-help@struts.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org