struts-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Wes Wannemacher <w...@wantii.com>
Subject Re: ActionMapper Wiki doc error
Date Tue, 22 Sep 2009 19:12:03 GMT
We had renamed the redirectAction result a while back but a lot of
that logic was hard-coded into the default action mapper. I had it
open to fix some bug (https://issues.apache.org/struts/browse/WW-3129)
so I went ahead and updated it to use the camelCase as well. This
changed happened after 2.1.6 and it will be in the release notes of
2.1.8 (if 2.1.8 is the next GA version).

-Wes

On Tue, Sep 22, 2009 at 2:58 PM, Greg Lindholm <greg.lindholm@gmail.com> wrote:
> Nope. I'm running 2.1.6 and looking at the 2.1.6 DefaultActionMapper source
> code and it says "redirect-action".
>
> There were other changes like the "redirectAction" result name that happened
> as part of the 2.1.6 release.
>
> On Tue, Sep 22, 2009 at 1:56 PM, Musachy Barroso <musachy@gmail.com> wrote:
>
>> wasn't that changed before 2.1.6?
>>
>> On Tue, Sep 22, 2009 at 10:25 AM, Greg Lindholm <greg.lindholm@gmail.com>
>> wrote:
>> > OK so this is a change.  Since the wiki isn't versioned I suggest it
>> needs a
>> > note explaining in 2.1.6 and earlier the prefix is "redirect-action".
>> (I
>> > also hope this change gets noted in the release notes when it is released
>> > since it will break existing code.)
>> >
>> >
>> > On Tue, Sep 22, 2009 at 12:50 PM, Wes Wannemacher <wesw@wantii.com>
>> wrote:
>> >
>> >> This changed between 2.1.6 and now... I updated DefaultActionMapper to
>> >> use redirectAction (since everywhere else refers to it that way). The
>> >> docs are wrong because it is a snippet that points to the source.
>> >>
>> >> -Wes
>> >>
>> >> On Tue, Sep 22, 2009 at 12:10 PM, Musachy Barroso <musachy@gmail.com>
>> >> wrote:
>> >> > Hi Greg, I could edit it, but I want to get this permission problem
>> >> > sorted out, can you try again and let me know if you can edit?
>> >> >
>> >> > thanks
>> >> > musachy
>> >> >
>> >> > On Tue, Sep 22, 2009 at 8:50 AM, Greg Lindholm <
>> greg.lindholm@gmail.com>
>> >> wrote:
>> >> >> The wiki doc for ActionMapper [1] appears to have an error: the
>> Redirect
>> >> >> Action prefix is documented as "redirectAction" where the 2.1.6
>> >> >> DefaultActionMapper source code and javadoc [2] has it as
>> >> "redirect-action".
>> >> >>
>> >> >> I tried to edit and fix the wiki but permission was denied.
>> >> >> Can someone with permission fix the wiki please.
>> >> >>
>> >> >>
>> >> >> [1] http://cwiki.apache.org/WW/actionmapper.html
>> >> >> [2]
>> >> >>
>> >>
>> http://struts.apache.org/2.1.6/struts2-core/apidocs/org/apache/struts2/dispatcher/mapper/DefaultActionMapper.html
>> >> >>
>> >> >
>> >> >
>> >> >
>> >> > --
>> >> > "Hey you! Would you help me to carry the stone?" Pink Floyd
>> >> >
>> >> > ---------------------------------------------------------------------
>> >> > To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
>> >> > For additional commands, e-mail: user-help@struts.apache.org
>> >> >
>> >> >
>> >>
>> >>
>> >>
>> >> --
>> >> Wes Wannemacher
>> >>
>> >> Head Engineer, WanTii, Inc.
>> >> Need Training? Struts, Spring, Maven, Tomcat...
>> >> Ask me for a quote!
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
>> >> For additional commands, e-mail: user-help@struts.apache.org
>> >>
>> >>
>> >
>>
>>
>>
>> --
>> "Hey you! Would you help me to carry the stone?" Pink Floyd
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
>> For additional commands, e-mail: user-help@struts.apache.org
>>
>>
>



-- 
Wes Wannemacher

Head Engineer, WanTii, Inc.
Need Training? Struts, Spring, Maven, Tomcat...
Ask me for a quote!

---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org


Mime
View raw message