struts-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dave Newton <newton.d...@yahoo.com>
Subject Re: OGNL in HTML tags
Date Thu, 30 Apr 2009 21:34:39 GMT
Dave Newton wrote:
> <tr class="<s:property value="%{getStatus(deviceID)}"/>">

Minor addendum:

IMO when iterating over a collection of model objects a status lookup 
like this would be a matter of querying the device, rather than 
providing a lookup based on the device ID.

If device statuses need to be mapped to CSS classnames I'd pass the 
device itself to a utility translation method rather than forcing the 
translator to look up the device.

This moves the generation of view-level data out of the device model, 
eliminates the need to look up a device that already exists as a model, 
and provides a measure of type safety (Java's OOP, after all).

The utility class could be used as shown, or in a JSP-based custom tag, 
which can significantly clean up the view layer depending on your 
requirements and/or implementation.

Dave


---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org


Mime
View raw message