issues@struts.apache.org Archives

[jira] Created: (WW-3348) IndexOutOfBoundsException in ValueStackDataSource

2009-12-04T20:03:13Z

IndexOutOfBoundsException in ValueStackDataSource
-------------------------------------------------

                 Key: WW-3348
                 URL: https://issues.apache.org/struts/browse/WW-3348
             Project: Struts 2
          Issue Type: Bug
          Components: Plugin - JasperReports
    Affects Versions: 2.1.8
         Environment: WinXP, Tomcat
            Reporter: Mark Gorokhov


Scenario: 
  - Jasper report with 4 subreports. 
  - Subreports content is provided from org.apache.struts2.views.jasperreports.ValueStackDataSource

Exception 
   java.lang.IndexOutOfBoundsException: Index: 0, Size: 0
is thrown from:
    public boolean next() throws JRException {
        if (firstTimeThrough) {
            firstTimeThrough = false;
        } else {
                valueStack.pop(); <== throws exception
        }
        . . .
    }

Exception is thrown if the last row from subreport fits the current page and a new page is
started. Thus the exception is data dependent.

The following workaround works nicely:
            if (valueStack.size() > 0) {
                valueStack.pop();
            }

Please test and implement in the next release.

The following does not work (cuts off the main report on empty valueStack condition):
            if (valueStack.size() == 0) {
                return false;
            }
            valueStack.pop();


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Created: (STR-3194) Need more thorough documentation of struts-config.xml

2009-12-04T15:59:13Z

Need more thorough documentation of struts-config.xml
-----------------------------------------------------

                 Key: STR-3194
                 URL: https://issues.apache.org/struts/browse/STR-3194
             Project: Struts 1
          Issue Type: Improvement
          Components: Documentation
    Affects Versions: 1.3.10
         Environment: N/A
            Reporter: Michael Cox
            Priority: Minor


Being new to Struts, I've searched all over the documentation here:

http://struts.apache.org/1.x/index.html

But it's nearly impossible to get just a basic understanding of the struts-config.xml file
and its inner workings.  As one example, the "input" attribute of the "action" element is
included in several examples but is not actually documented anywhere.  Other websites say
that the "input" attribute describes where to forward if there is a validation error.  Since
it is extremely unintuitive that a validation error page is specified by an attribute called
"input" (rather than, say, "errorpage"), and since the official documentation should be reasonably
thorough when covering the basics of Struts, we really need to have a better description of
the Struts configuration XML file.  The documentation should contain a thorough explanation
of every element and attribute, as well as how the values can map to other elements.  (i.e.
how an action can be specified in the "path" attribute of a "forward" element by using "actionName.do",
how a "forward" attribute of an "action" element can point to a tiles definition in tiles-defs.xml,
etc.  This wiring of values is very confusing to beginners -- especially since the names that
were chosen are often misleading -- and seems to be poorly documented in the official pages.)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (WW-3329) ${Parameters.xxx} in freemarker view is broken

2009-12-04T03:31:14Z


    [ https://issues.apache.org/struts/browse/WW-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47132#action_47132
] 

zhouyanming commented on WW-3329:
---------------------------------

does patch applied to trunk?

> ${Parameters.xxx} in freemarker view is broken
> ----------------------------------------------
>
>                 Key: WW-3329
>                 URL: https://issues.apache.org/struts/browse/WW-3329
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Other
>    Affects Versions: 2.2.0
>            Reporter: zhouyanming
>            Assignee: Musachy Barroso
>            Priority: Blocker
>             Fix For: 2.2.0
>
>         Attachments: patch.diff
>
>
> "Parameters" was instead by ".freemarker.RequestParameters" in FreemakerManager
> protected ScopesHashModel buildScopesHashModel(
> 			ServletContext servletContext, HttpServletRequest request,
> 			HttpServletResponse response, ObjectWrapper wrapper,
> 			ValueStack stack) ;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WW-3248) IP Clearance for XWork Code Integration

2009-12-03T21:31:13Z


     [ https://issues.apache.org/struts/browse/WW-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Rene Gielen updated WW-3248:
----------------------------

    Affects Version/s:     (was: 2.1.8)
                       2.2.x
        Fix Version/s: 2.2.x
             Assignee: Martin Cooper  (was: Rene Gielen)

As far as I can see, the submission process can be started. Handing over to Martin.

> IP Clearance for XWork Code Integration
> ---------------------------------------
>
>                 Key: WW-3248
>                 URL: https://issues.apache.org/struts/browse/WW-3248
>             Project: Struts 2
>          Issue Type: Task
>          Components: Integration
>    Affects Versions: 2.2.x
>            Reporter: Rene Gielen
>            Assignee: Martin Cooper
>             Fix For: 2.2.x
>
>         Attachments: OpenSymphony XWork Grant.PDF, opensymphony-xwork_20091203_rev2082.tar.bz2,
opensymphony-xwork_20091203_rev2082.tar.bz2.asc, opensymphony-xwork_20091203_rev2082.tar.bz2.md5,
opensymphony-xwork_20091203_rev2082.tar.bz2.md5.asc, struts2-xwork.xml, XWork_IP Clearance
_ Incubation - Status, Questions & Next Steps.eml
>
>
> This is the task for the IP clearance of the XWork code integration into the Struts 2
codebase
> Website: http://www.opensymphony.com/xwork/
> Subversion repository: https://svn.opensymphony.com/svn/xwork/trunk
> Additional resources
> IP clearence process, templates and completed processes
> http://incubator.apache.org/ip-clearance/index.html
> List of Apache committers and filed CLAs:
> http://people.apache.org/~jim/committers.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WW-3248) IP Clearance for XWork Code Integration

2009-12-03T21:29:13Z


     [ https://issues.apache.org/struts/browse/WW-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Rene Gielen updated WW-3248:
----------------------------

    Attachment: opensymphony-xwork_20091203_rev2082.tar.bz2.md5.asc

The XWork codebase as of revision 2082 to be donated, along with matching MD5 checksum and
signatures.

> IP Clearance for XWork Code Integration
> ---------------------------------------
>
>                 Key: WW-3248
>                 URL: https://issues.apache.org/struts/browse/WW-3248
>             Project: Struts 2
>          Issue Type: Task
>          Components: Integration
>    Affects Versions: 2.1.8
>            Reporter: Rene Gielen
>            Assignee: Rene Gielen
>         Attachments: OpenSymphony XWork Grant.PDF, opensymphony-xwork_20091203_rev2082.tar.bz2,
opensymphony-xwork_20091203_rev2082.tar.bz2.asc, opensymphony-xwork_20091203_rev2082.tar.bz2.md5,
opensymphony-xwork_20091203_rev2082.tar.bz2.md5.asc, struts2-xwork.xml, XWork_IP Clearance
_ Incubation - Status, Questions & Next Steps.eml
>
>
> This is the task for the IP clearance of the XWork code integration into the Struts 2
codebase
> Website: http://www.opensymphony.com/xwork/
> Subversion repository: https://svn.opensymphony.com/svn/xwork/trunk
> Additional resources
> IP clearence process, templates and completed processes
> http://incubator.apache.org/ip-clearance/index.html
> List of Apache committers and filed CLAs:
> http://people.apache.org/~jim/committers.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WW-3248) IP Clearance for XWork Code Integration

2009-12-03T21:27:14Z


     [ https://issues.apache.org/struts/browse/WW-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Rene Gielen updated WW-3248:
----------------------------

    Attachment: opensymphony-xwork_20091203_rev2082.tar.bz2.md5
                opensymphony-xwork_20091203_rev2082.tar.bz2.asc
                opensymphony-xwork_20091203_rev2082.tar.bz2

The XWork codebase as of revision 2082 to be donated, along with matching MD5 checksum and
signatures.

> IP Clearance for XWork Code Integration
> ---------------------------------------
>
>                 Key: WW-3248
>                 URL: https://issues.apache.org/struts/browse/WW-3248
>             Project: Struts 2
>          Issue Type: Task
>          Components: Integration
>    Affects Versions: 2.1.8
>            Reporter: Rene Gielen
>            Assignee: Rene Gielen
>         Attachments: OpenSymphony XWork Grant.PDF, opensymphony-xwork_20091203_rev2082.tar.bz2,
opensymphony-xwork_20091203_rev2082.tar.bz2.asc, opensymphony-xwork_20091203_rev2082.tar.bz2.md5,
struts2-xwork.xml, XWork_IP Clearance _ Incubation - Status, Questions & Next Steps.eml
>
>
> This is the task for the IP clearance of the XWork code integration into the Struts 2
codebase
> Website: http://www.opensymphony.com/xwork/
> Subversion repository: https://svn.opensymphony.com/svn/xwork/trunk
> Additional resources
> IP clearence process, templates and completed processes
> http://incubator.apache.org/ip-clearance/index.html
> List of Apache committers and filed CLAs:
> http://people.apache.org/~jim/committers.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WW-3248) IP Clearance for XWork Code Integration

2009-12-03T21:23:14Z


     [ https://issues.apache.org/struts/browse/WW-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Rene Gielen updated WW-3248:
----------------------------

    Attachment: XWork_IP Clearance _ Incubation - Status, Questions & Next Steps.eml
                OpenSymphony XWork Grant.PDF

The software grant signed by Patrick Lightbody as managing director of Opensymphony

> IP Clearance for XWork Code Integration
> ---------------------------------------
>
>                 Key: WW-3248
>                 URL: https://issues.apache.org/struts/browse/WW-3248
>             Project: Struts 2
>          Issue Type: Task
>          Components: Integration
>    Affects Versions: 2.1.8
>            Reporter: Rene Gielen
>            Assignee: Rene Gielen
>         Attachments: OpenSymphony XWork Grant.PDF, struts2-xwork.xml, XWork_IP Clearance
_ Incubation - Status, Questions & Next Steps.eml
>
>
> This is the task for the IP clearance of the XWork code integration into the Struts 2
codebase
> Website: http://www.opensymphony.com/xwork/
> Subversion repository: https://svn.opensymphony.com/svn/xwork/trunk
> Additional resources
> IP clearence process, templates and completed processes
> http://incubator.apache.org/ip-clearance/index.html
> List of Apache committers and filed CLAs:
> http://people.apache.org/~jim/committers.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WW-3248) IP Clearance for XWork Code Integration

2009-12-03T21:21:14Z


     [ https://issues.apache.org/struts/browse/WW-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Rene Gielen updated WW-3248:
----------------------------

    Attachment: struts2-xwork.xml

The submission form completed as far as possible for Martin to review and commit, along with
the signed codebase

> IP Clearance for XWork Code Integration
> ---------------------------------------
>
>                 Key: WW-3248
>                 URL: https://issues.apache.org/struts/browse/WW-3248
>             Project: Struts 2
>          Issue Type: Task
>          Components: Integration
>    Affects Versions: 2.1.8
>            Reporter: Rene Gielen
>            Assignee: Rene Gielen
>         Attachments: struts2-xwork.xml
>
>
> This is the task for the IP clearance of the XWork code integration into the Struts 2
codebase
> Website: http://www.opensymphony.com/xwork/
> Subversion repository: https://svn.opensymphony.com/svn/xwork/trunk
> Additional resources
> IP clearence process, templates and completed processes
> http://incubator.apache.org/ip-clearance/index.html
> List of Apache committers and filed CLAs:
> http://people.apache.org/~jim/committers.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WW-3248) IP Clearance for XWork Code Integration

2009-12-03T21:17:14Z


     [ https://issues.apache.org/struts/browse/WW-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Rene Gielen updated WW-3248:
----------------------------

    Attachment:     (was: struts2-xwork.xml)

> IP Clearance for XWork Code Integration
> ---------------------------------------
>
>                 Key: WW-3248
>                 URL: https://issues.apache.org/struts/browse/WW-3248
>             Project: Struts 2
>          Issue Type: Task
>          Components: Integration
>    Affects Versions: 2.1.8
>            Reporter: Rene Gielen
>            Assignee: Rene Gielen
>
> This is the task for the IP clearance of the XWork code integration into the Struts 2
codebase
> Website: http://www.opensymphony.com/xwork/
> Subversion repository: https://svn.opensymphony.com/svn/xwork/trunk
> Additional resources
> IP clearence process, templates and completed processes
> http://incubator.apache.org/ip-clearance/index.html
> List of Apache committers and filed CLAs:
> http://people.apache.org/~jim/committers.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (WW-2970) Param set on chained action is re-set on all actions in chain

2009-12-03T19:29:15Z


     [ https://issues.apache.org/struts/browse/WW-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Musachy Barroso resolved WW-2970.
---------------------------------

    Resolution: Won't Fix

ok, this became the side effect of something else which I am not sure what it was. Here is
the problem:
When StaticParamsInterceptor runs on action1 then the static param is added to the request
param list, when chaining happens all fields are copied from action1 to action2, and the field
is set as expected, but when the params interceptor runs on action2, then it "sees" the static
param as a request param because the StaticParamsInterceptor added it to the request params,
and then it sets the field in action2 to the static value.

Take a look at :
http://jira.opensymphony.com/browse/XW-709

The solution is to configure your "staticParams" interceptor and set the "merge" attribute
to false.

> Param set on chained action is re-set on all actions in chain
> -------------------------------------------------------------
>
>                 Key: WW-2970
>                 URL: https://issues.apache.org/struts/browse/WW-2970
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Interceptors
>    Affects Versions: 2.1.6
>         Environment: Windows XP SP2.  WebLogic Server 10.0 MP1.  Java HotSpot(TM) Server
VM Version 1.5.0_11-b03
>            Reporter: David
>             Fix For: 2.2.0
>
>         Attachments: chainapp.zip
>
>
> If a param is set on an action in a chain through struts.xml, it will be set on all subsequent
actions in the chain, thus overwriting any values that may have been set by the actions themselves.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (WW-2970) Param set on chained action is re-set on all actions in chain

2009-12-03T16:09:14Z


    [ https://issues.apache.org/struts/browse/WW-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47125#action_47125
] 

Musachy Barroso commented on WW-2970:
-------------------------------------

this seems weird, if it is broken then parameter copying in chaining is broken in 2.1.6+.

> Param set on chained action is re-set on all actions in chain
> -------------------------------------------------------------
>
>                 Key: WW-2970
>                 URL: https://issues.apache.org/struts/browse/WW-2970
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Interceptors
>    Affects Versions: 2.1.6
>         Environment: Windows XP SP2.  WebLogic Server 10.0 MP1.  Java HotSpot(TM) Server
VM Version 1.5.0_11-b03
>            Reporter: David
>             Fix For: 2.2.0
>
>         Attachments: chainapp.zip
>
>
> If a param is set on an action in a chain through struts.xml, it will be set on all subsequent
actions in the chain, thus overwriting any values that may have been set by the actions themselves.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WW-2970) Param set on chained action is re-set on all actions in chain

2009-12-03T16:07:51Z


     [ https://issues.apache.org/struts/browse/WW-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Musachy Barroso updated WW-2970:
--------------------------------

    Fix Version/s: 2.2.0

> Param set on chained action is re-set on all actions in chain
> -------------------------------------------------------------
>
>                 Key: WW-2970
>                 URL: https://issues.apache.org/struts/browse/WW-2970
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Interceptors
>    Affects Versions: 2.1.6
>         Environment: Windows XP SP2.  WebLogic Server 10.0 MP1.  Java HotSpot(TM) Server
VM Version 1.5.0_11-b03
>            Reporter: David
>             Fix For: 2.2.0
>
>         Attachments: chainapp.zip
>
>
> If a param is set on an action in a chain through struts.xml, it will be set on all subsequent
actions in the chain, thus overwriting any values that may have been set by the actions themselves.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (WW-2970) Param set on chained action is re-set on all actions in chain

2009-12-03T13:51:13Z


    [ https://issues.apache.org/struts/browse/WW-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47124#action_47124
] 

Antoine W commented on WW-2970:
-------------------------------

It looks like I have the same behavior with tomcat. Params interceptor is re-setting all parameters
from get/post, before each chained action is called.
So if action1 updates one parameter, then chains to action2, action2 will still get the initial
value reseted by Params.
This is quite annoying... 

> Param set on chained action is re-set on all actions in chain
> -------------------------------------------------------------
>
>                 Key: WW-2970
>                 URL: https://issues.apache.org/struts/browse/WW-2970
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Interceptors
>    Affects Versions: 2.1.6
>         Environment: Windows XP SP2.  WebLogic Server 10.0 MP1.  Java HotSpot(TM) Server
VM Version 1.5.0_11-b03
>            Reporter: David
>         Attachments: chainapp.zip
>
>
> If a param is set on an action in a chain through struts.xml, it will be set on all subsequent
actions in the chain, thus overwriting any values that may have been set by the actions themselves.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Created: (WW-3347) autocompleter

2009-12-03T01:45:13Z

autocompleter
-------------

                 Key: WW-3347
                 URL: https://issues.apache.org/struts/browse/WW-3347
             Project: Struts 2
          Issue Type: Temp
          Components: Plugin - Dojo Tags
    Affects Versions: 2.1.8
         Environment: windows vista,oracle 10g database
            Reporter: Dasari Taraka Rajendra Prasad


based on a tutorial,i created an action called AutoCompleteCityAction and configured in struts.xml
like
.....Action.java
package ajaxstruts;

import java.util.List;
import java.util.Map;
import java.util.HashMap;

import com.opensymphony.xwork2.ActionSupport;

public class AutoCompleteCityAction extends ActionSupport {
  Map json;
  String city;
  CitiesDAO  dao;
  public Map getJson () {
    return json;
   }

  public void setJson (Map json ) {
    this.json = json;
  }

  public String getCity () {
    return city;
  }

  public void setCity (String city ) {
    this.city = city;
  }  
  
  public AutoCompleteCityAction() {
   	  
  }
  
  public String execute()throws Exception {
  	return SUCCESS;
  }
  
  public String getCities() {
	  if(city != null && (!city.isEmpty())) {
	    json = new HashMap();
	    dao = new CitiesDAO();
	    List list = dao.getCities(city);
	    for(City city: list) {
	     json.put(""+city.getCityId(),city.getCityName()+","+city.getStateName());   
	    }
	  }
	  return SUCCESS;
  } 
  
}



   
    
    
          json
    

   
  
then written as .jsp

<%@ taglib prefix="s" uri="/struts-tags" %>
<%@ taglib prefix="sx" uri="/struts-dojo-tags" %>
 

  
    
  
  
   
    
    
    
   
    
  


when i am running 
the text box is showing
"message
type
number"
but no auto completion  [even after adding autoComplete="true" ]

please look into

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WW-3346) ValidatorSupport turns empty defaultMessage to null causing field error to include "null" for visitor validators with empty messages

2009-12-01T19:14:13Z


     [ https://issues.apache.org/struts/browse/WW-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Musachy Barroso updated WW-3346:
--------------------------------

    Affects Version/s:     (was: 2.1.8)
                       2.2.0

> ValidatorSupport turns empty defaultMessage to null causing field error to include "null"
for visitor validators with empty messages
> ------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WW-3346
>                 URL: https://issues.apache.org/struts/browse/WW-3346
>             Project: Struts 2
>          Issue Type: Bug
>          Components: XML Validators
>    Affects Versions: 2.2.0
>         Environment: struts 2.1.8, xwork 2.1.6, jdk 1.6 
>            Reporter: Haroon Rafique
>            Assignee: Musachy Barroso
>         Attachments: XW-737-null-defaultMessage.patch
>
>
> I reported this as http://jira.opensymphony.com/browse/XW-737 and I was asked to report
this here as well.
> Upon upgrading to struts 2.1.8 (from 2.0.14) with xwork 2.1.6, I started getting field
errors which included the string null in them for field visitor validators.
> Using a visitor validator as follows:
>     
>         
>             
>         
>     
> and a required string validator on the actual field as follows:
>     
>         
>             Description is required
>         
>      
> I was expecting the field for residenceRoom.description to contain "Description is required"
but instead it contained "nullDescription is required". Presumably this happens because of
line 202 in VisitorFieldValidator.java
> super.addFieldError(getFullFieldName(fieldName), message + errorMessage);
> The fix for me seems to be to fix ValidatorSupport to not nullify defaultMessage when
message is null or empty. I will attach a patch shortly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WW-3346) ValidatorSupport turns empty defaultMessage to null causing field error to include "null" for visitor validators with empty messages

2009-12-01T19:06:13Z


     [ https://issues.apache.org/struts/browse/WW-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Haroon Rafique updated WW-3346:
-------------------------------

    Attachment: XW-737-null-defaultMessage.patch

Fix for "null" being included verbatim in visitor field errors.

> ValidatorSupport turns empty defaultMessage to null causing field error to include "null"
for visitor validators with empty messages
> ------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WW-3346
>                 URL: https://issues.apache.org/struts/browse/WW-3346
>             Project: Struts 2
>          Issue Type: Bug
>          Components: XML Validators
>    Affects Versions: 2.1.8
>         Environment: struts 2.1.8, xwork 2.1.6, jdk 1.6 
>            Reporter: Haroon Rafique
>            Assignee: Musachy Barroso
>         Attachments: XW-737-null-defaultMessage.patch
>
>
> I reported this as http://jira.opensymphony.com/browse/XW-737 and I was asked to report
this here as well.
> Upon upgrading to struts 2.1.8 (from 2.0.14) with xwork 2.1.6, I started getting field
errors which included the string null in them for field visitor validators.
> Using a visitor validator as follows:
>     
>         
>             
>         
>     
> and a required string validator on the actual field as follows:
>     
>         
>             Description is required
>         
>      
> I was expecting the field for residenceRoom.description to contain "Description is required"
but instead it contained "nullDescription is required". Presumably this happens because of
line 202 in VisitorFieldValidator.java
> super.addFieldError(getFullFieldName(fieldName), message + errorMessage);
> The fix for me seems to be to fix ValidatorSupport to not nullify defaultMessage when
message is null or empty. I will attach a patch shortly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Created: (WW-3346) ValidatorSupport turns empty defaultMessage to null causing field error to include "null" for visitor validators with empty messages

2009-12-01T19:04:13Z

ValidatorSupport turns empty defaultMessage to null causing field error to include "null" for
visitor validators with empty messages
------------------------------------------------------------------------------------------------------------------------------------

                 Key: WW-3346
                 URL: https://issues.apache.org/struts/browse/WW-3346
             Project: Struts 2
          Issue Type: Bug
          Components: XML Validators
    Affects Versions: 2.1.8
         Environment: struts 2.1.8, xwork 2.1.6, jdk 1.6 
            Reporter: Haroon Rafique
            Assignee: Musachy Barroso


I reported this as http://jira.opensymphony.com/browse/XW-737 and I was asked to report this
here as well.

Upon upgrading to struts 2.1.8 (from 2.0.14) with xwork 2.1.6, I started getting field errors
which included the string null in them for field visitor validators.

Using a visitor validator as follows:

    
        
            
        
    

and a required string validator on the actual field as follows:
    
        
            Description is required
        
     

I was expecting the field for residenceRoom.description to contain "Description is required"
but instead it contained "nullDescription is required". Presumably this happens because of
line 202 in VisitorFieldValidator.java

super.addFieldError(getFullFieldName(fieldName), message + errorMessage);

The fix for me seems to be to fix ValidatorSupport to not nullify defaultMessage when message
is null or empty. I will attach a patch shortly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (WW-3339) Form data lost (null) when using post method with Internet Explorer 7. Get method works fine and post works fine with Firefox.

2009-12-01T16:18:13Z


     [ https://issues.apache.org/struts/browse/WW-3339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Musachy Barroso resolved WW-3339.
---------------------------------

    Resolution: Not A Problem

thanks for the research and reporting Bryan. 

> Form data lost (null) when using post method with Internet Explorer 7.  Get method works
fine and post works fine with Firefox. 
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WW-3339
>                 URL: https://issues.apache.org/struts/browse/WW-3339
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.1.8
>         Environment: Tomcat 5.5.28 on IBM ISeries, IE 7, Struts2, Java 5
>            Reporter: Bryan Tartt
>            Assignee: Bryan Tartt
>
> Every form that I have created has a problem retrieving data (returns null) in the Action
when using Internet Explorer 6 and form method is post.  I have not tested against other versions
of IE but FireFox works without any problems.  When I use get as the form method, the data
is passed in IE and FireFox.  I don't know if this is an IE and ISeries issue or a Struts
configuration (Interceptors) problem.  I have been searching for an answer on this problem
for weeks without any luck. 
> form
> <%@ page language="java" contentType="text/html; charset=UTF-8" pageEncoding="UTF-8"
%>
> <%@ page import="com.expensereport.*" %>
> <%--@ page errorPage="/ExpRepErrorHandler.jsp" --%>
> <%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core" %>
> <%@ taglib prefix="fmt" uri="http://java.sun.com/jsp/jstl/fmt" %>
> <%@ taglib prefix="s" uri="/struts-tags" %>
> <%@ taglib prefix="sx" uri="/struts-dojo-tags" %>
> 
> 
> 			
> 		Expense Reports
> 		
> 		
> 		" type="text/css">
> 		
> 		
> 	
> 
> 
> 
> 	
> 		
> 					
> 		   
> 			
> 			
> 		  
> 		  
> 			
> 			
> 		  
> 		
> 	Receipt Upload

> 
> 
> 
> struts.xml
>      "-//Apache Software Foundation//DTD Struts Configuration 2.1.7//EN"
>     "http://struts.apache.org/dtds/struts-2.1.7.dtd">
> 
> 		
> 		
> 		 		
> 		
> 		
> 		
> 			/ExpRepBadQueue.jsp
> 			/index.html
> 			/ExpRepBadQueue.jsp
> 		
> 		
> 			
> 		
> 		
> 			
>         

>         	
> 	        
>         	/ExpRepEntry.jsp
>         	/ExpRepEntry.jsp
>         
>         
>         	/ExpRepEntry.jsp
>         
>         
>         	/ExpRepDeleteConfirmation.jsp
>         	
>         		/ReportQueue
>         		EMPLOYEE
>         		ALL
>         	
>           
>         
>         	/AttendeeInput.jsp
>             
>         
>         	/AjaxRemoteForm.jsp
>         
> 		
> 
> Action
> package com.expensereport;
> import java.io.BufferedReader;
> import java.io.File;
> import java.io.FileInputStream;
> import java.io.FileNotFoundException;
> import java.io.FileOutputStream;
> import java.io.FileWriter;
> import java.io.IOException;
> import java.util.HashMap;
> import java.util.Iterator;
> import java.util.List;
> import java.util.Map;
> import javax.servlet.http.HttpServletRequest;
> import javax.servlet.http.HttpServletResponse;
> import org.apache.commons.fileupload.FileItem;
> import org.apache.commons.fileupload.FileItemFactory;
> import org.apache.commons.fileupload.FileUploadException;
> import org.apache.commons.fileupload.FileUploadBase.SizeLimitExceededException;
> import org.apache.commons.fileupload.disk.DiskFileItemFactory;
> import org.apache.commons.fileupload.servlet.ServletFileUpload;
> import org.apache.commons.fileupload.servlet.ServletRequestContext;
> import org.apache.struts2.ServletActionContext;
> import org.apache.struts2.dispatcher.multipart.MultiPartRequestWrapper;
> import org.apache.struts2.interceptor.ServletRequestAware;
> import org.apache.struts2.interceptor.ServletResponseAware;
> import org.apache.struts2.interceptor.SessionAware;
> import com.expensereport.EasyLog;
> import com.opensymphony.xwork2.ActionContext;
> import com.opensymphony.xwork2.ActionSupport;
> import com.opensymphony.xwork2.Preparable;
> public class ReceiptUpload extends ActionSupport implements SessionAware, Preparable
{
> 	
> 	/**
> 	 * 
> 	 */
> 	private static final long serialVersionUID = -2387150538575396408L;
> 	private File file;
> 	private String contentType;// The content type of the file
> 	private String fileName;// The uploaded file name and path
> 	private Map session;
> 	EasyLog log = new EasyLog();	
> 		
> 	
> 	public String execute(){
> 		
> 				
> 			getReceiptContentType();
> 			log.info("receiptContentType = " + contentType);
> 			getReceiptFileName();
> 			log.info("receiptFileName = " + fileName);
> 			getReceipt();		
> 			log.info("Receipt getName = " + file.getName());
> 					
> 			session = ActionContext.getContext().getSession();	 
> 			String reportID = "0000000";
> 			
> 			ExpenseReport er = (ExpenseReport) session.get("er");
> 			log.info("reportID = " + er.getErh().getReportID());
> 			
> 			if ((er.getErh().getReportID() == null) || (er.getErh().getReportID().trim().length()
< 1)){
> 				er.getErh().setReportID(reportID);		
> 			}
> 			
> 			if (file != null){
> 				log.info("Creating a new file");
> 				boolean renamed = file.renameTo(new File("/home/tomdev/ObjectCache/Expense Reports/"
+ fileName));
> 			} else {
> 				log.error("Attachment was null");
> 			}
> 			
> 			log.info("return success");
> 			return SUCCESS;
> 	}
>        public void prepare() throws Exception {
> 		
> 	}
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WW-3339) Form data lost (null) when using post method with Internet Explorer 7. Get method works fine and post works fine with Firefox.

2009-12-01T14:16:13Z


     [ https://issues.apache.org/struts/browse/WW-3339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Bryan Tartt updated WW-3339:
----------------------------


Ended up being an IE bug with authentication.  See http://support.microsoft.com/?id=251404

> Form data lost (null) when using post method with Internet Explorer 7.  Get method works
fine and post works fine with Firefox. 
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WW-3339
>                 URL: https://issues.apache.org/struts/browse/WW-3339
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.1.8
>         Environment: Tomcat 5.5.28 on IBM ISeries, IE 7, Struts2, Java 5
>            Reporter: Bryan Tartt
>            Assignee: Bryan Tartt
>
> Every form that I have created has a problem retrieving data (returns null) in the Action
when using Internet Explorer 6 and form method is post.  I have not tested against other versions
of IE but FireFox works without any problems.  When I use get as the form method, the data
is passed in IE and FireFox.  I don't know if this is an IE and ISeries issue or a Struts
configuration (Interceptors) problem.  I have been searching for an answer on this problem
for weeks without any luck. 
> form
> <%@ page language="java" contentType="text/html; charset=UTF-8" pageEncoding="UTF-8"
%>
> <%@ page import="com.expensereport.*" %>
> <%--@ page errorPage="/ExpRepErrorHandler.jsp" --%>
> <%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core" %>
> <%@ taglib prefix="fmt" uri="http://java.sun.com/jsp/jstl/fmt" %>
> <%@ taglib prefix="s" uri="/struts-tags" %>
> <%@ taglib prefix="sx" uri="/struts-dojo-tags" %>
> 
> 
> 			
> 		Expense Reports
> 		
> 		
> 		" type="text/css">
> 		
> 		
> 	
> 
> 
> 
> 	
> 		
> 					
> 		   
> 			
> 			
> 		  
> 		  
> 			
> 			
> 		  
> 		
> 	Receipt Upload

> 
> 
> 
> struts.xml
>      "-//Apache Software Foundation//DTD Struts Configuration 2.1.7//EN"
>     "http://struts.apache.org/dtds/struts-2.1.7.dtd">
> 
> 		
> 		
> 		 		
> 		
> 		
> 		
> 			/ExpRepBadQueue.jsp
> 			/index.html
> 			/ExpRepBadQueue.jsp
> 		
> 		
> 			
> 		
> 		
> 			
>         

>         	
> 	        
>         	/ExpRepEntry.jsp
>         	/ExpRepEntry.jsp
>         
>         
>         	/ExpRepEntry.jsp
>         
>         
>         	/ExpRepDeleteConfirmation.jsp
>         	
>         		/ReportQueue
>         		EMPLOYEE
>         		ALL
>         	
>           
>         
>         	/AttendeeInput.jsp
>             
>         
>         	/AjaxRemoteForm.jsp
>         
> 		
> 
> Action
> package com.expensereport;
> import java.io.BufferedReader;
> import java.io.File;
> import java.io.FileInputStream;
> import java.io.FileNotFoundException;
> import java.io.FileOutputStream;
> import java.io.FileWriter;
> import java.io.IOException;
> import java.util.HashMap;
> import java.util.Iterator;
> import java.util.List;
> import java.util.Map;
> import javax.servlet.http.HttpServletRequest;
> import javax.servlet.http.HttpServletResponse;
> import org.apache.commons.fileupload.FileItem;
> import org.apache.commons.fileupload.FileItemFactory;
> import org.apache.commons.fileupload.FileUploadException;
> import org.apache.commons.fileupload.FileUploadBase.SizeLimitExceededException;
> import org.apache.commons.fileupload.disk.DiskFileItemFactory;
> import org.apache.commons.fileupload.servlet.ServletFileUpload;
> import org.apache.commons.fileupload.servlet.ServletRequestContext;
> import org.apache.struts2.ServletActionContext;
> import org.apache.struts2.dispatcher.multipart.MultiPartRequestWrapper;
> import org.apache.struts2.interceptor.ServletRequestAware;
> import org.apache.struts2.interceptor.ServletResponseAware;
> import org.apache.struts2.interceptor.SessionAware;
> import com.expensereport.EasyLog;
> import com.opensymphony.xwork2.ActionContext;
> import com.opensymphony.xwork2.ActionSupport;
> import com.opensymphony.xwork2.Preparable;
> public class ReceiptUpload extends ActionSupport implements SessionAware, Preparable
{
> 	
> 	/**
> 	 * 
> 	 */
> 	private static final long serialVersionUID = -2387150538575396408L;
> 	private File file;
> 	private String contentType;// The content type of the file
> 	private String fileName;// The uploaded file name and path
> 	private Map session;
> 	EasyLog log = new EasyLog();	
> 		
> 	
> 	public String execute(){
> 		
> 				
> 			getReceiptContentType();
> 			log.info("receiptContentType = " + contentType);
> 			getReceiptFileName();
> 			log.info("receiptFileName = " + fileName);
> 			getReceipt();		
> 			log.info("Receipt getName = " + file.getName());
> 					
> 			session = ActionContext.getContext().getSession();	 
> 			String reportID = "0000000";
> 			
> 			ExpenseReport er = (ExpenseReport) session.get("er");
> 			log.info("reportID = " + er.getErh().getReportID());
> 			
> 			if ((er.getErh().getReportID() == null) || (er.getErh().getReportID().trim().length()
< 1)){
> 				er.getErh().setReportID(reportID);		
> 			}
> 			
> 			if (file != null){
> 				log.info("Creating a new file");
> 				boolean renamed = file.renameTo(new File("/home/tomdev/ObjectCache/Expense Reports/"
+ fileName));
> 			} else {
> 				log.error("Attachment was null");
> 			}
> 			
> 			log.info("return success");
> 			return SUCCESS;
> 	}
>        public void prepare() throws Exception {
> 		
> 	}
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Work started: (WW-3339) Form data lost (null) when using post method with Internet Explorer 7. Get method works fine and post works fine with Firefox.

2009-12-01T14:14:13Z


     [ https://issues.apache.org/struts/browse/WW-3339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Work on WW-3339 started by Bryan Tartt.

> Form data lost (null) when using post method with Internet Explorer 7.  Get method works
fine and post works fine with Firefox. 
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WW-3339
>                 URL: https://issues.apache.org/struts/browse/WW-3339
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.1.8
>         Environment: Tomcat 5.5.28 on IBM ISeries, IE 7, Struts2, Java 5
>            Reporter: Bryan Tartt
>            Assignee: Bryan Tartt
>
> Every form that I have created has a problem retrieving data (returns null) in the Action
when using Internet Explorer 6 and form method is post.  I have not tested against other versions
of IE but FireFox works without any problems.  When I use get as the form method, the data
is passed in IE and FireFox.  I don't know if this is an IE and ISeries issue or a Struts
configuration (Interceptors) problem.  I have been searching for an answer on this problem
for weeks without any luck. 
> form
> <%@ page language="java" contentType="text/html; charset=UTF-8" pageEncoding="UTF-8"
%>
> <%@ page import="com.expensereport.*" %>
> <%--@ page errorPage="/ExpRepErrorHandler.jsp" --%>
> <%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core" %>
> <%@ taglib prefix="fmt" uri="http://java.sun.com/jsp/jstl/fmt" %>
> <%@ taglib prefix="s" uri="/struts-tags" %>
> <%@ taglib prefix="sx" uri="/struts-dojo-tags" %>
> 
> 
> 			
> 		Expense Reports
> 		
> 		
> 		" type="text/css">
> 		
> 		
> 	
> 
> 
> 
> 	
> 		
> 					
> 		   
> 			
> 			
> 		  
> 		  
> 			
> 			
> 		  
> 		
> 	Receipt Upload

> 
> 
> 
> struts.xml
>      "-//Apache Software Foundation//DTD Struts Configuration 2.1.7//EN"
>     "http://struts.apache.org/dtds/struts-2.1.7.dtd">
> 
> 		
> 		
> 		 		
> 		
> 		
> 		
> 			/ExpRepBadQueue.jsp
> 			/index.html
> 			/ExpRepBadQueue.jsp
> 		
> 		
> 			
> 		
> 		
> 			
>         

>         	
> 	        
>         	/ExpRepEntry.jsp
>         	/ExpRepEntry.jsp
>         
>         
>         	/ExpRepEntry.jsp
>         
>         
>         	/ExpRepDeleteConfirmation.jsp
>         	
>         		/ReportQueue
>         		EMPLOYEE
>         		ALL
>         	
>           
>         
>         	/AttendeeInput.jsp
>             
>         
>         	/AjaxRemoteForm.jsp
>         
> 		
> 
> Action
> package com.expensereport;
> import java.io.BufferedReader;
> import java.io.File;
> import java.io.FileInputStream;
> import java.io.FileNotFoundException;
> import java.io.FileOutputStream;
> import java.io.FileWriter;
> import java.io.IOException;
> import java.util.HashMap;
> import java.util.Iterator;
> import java.util.List;
> import java.util.Map;
> import javax.servlet.http.HttpServletRequest;
> import javax.servlet.http.HttpServletResponse;
> import org.apache.commons.fileupload.FileItem;
> import org.apache.commons.fileupload.FileItemFactory;
> import org.apache.commons.fileupload.FileUploadException;
> import org.apache.commons.fileupload.FileUploadBase.SizeLimitExceededException;
> import org.apache.commons.fileupload.disk.DiskFileItemFactory;
> import org.apache.commons.fileupload.servlet.ServletFileUpload;
> import org.apache.commons.fileupload.servlet.ServletRequestContext;
> import org.apache.struts2.ServletActionContext;
> import org.apache.struts2.dispatcher.multipart.MultiPartRequestWrapper;
> import org.apache.struts2.interceptor.ServletRequestAware;
> import org.apache.struts2.interceptor.ServletResponseAware;
> import org.apache.struts2.interceptor.SessionAware;
> import com.expensereport.EasyLog;
> import com.opensymphony.xwork2.ActionContext;
> import com.opensymphony.xwork2.ActionSupport;
> import com.opensymphony.xwork2.Preparable;
> public class ReceiptUpload extends ActionSupport implements SessionAware, Preparable
{
> 	
> 	/**
> 	 * 
> 	 */
> 	private static final long serialVersionUID = -2387150538575396408L;
> 	private File file;
> 	private String contentType;// The content type of the file
> 	private String fileName;// The uploaded file name and path
> 	private Map session;
> 	EasyLog log = new EasyLog();	
> 		
> 	
> 	public String execute(){
> 		
> 				
> 			getReceiptContentType();
> 			log.info("receiptContentType = " + contentType);
> 			getReceiptFileName();
> 			log.info("receiptFileName = " + fileName);
> 			getReceipt();		
> 			log.info("Receipt getName = " + file.getName());
> 					
> 			session = ActionContext.getContext().getSession();	 
> 			String reportID = "0000000";
> 			
> 			ExpenseReport er = (ExpenseReport) session.get("er");
> 			log.info("reportID = " + er.getErh().getReportID());
> 			
> 			if ((er.getErh().getReportID() == null) || (er.getErh().getReportID().trim().length()
< 1)){
> 				er.getErh().setReportID(reportID);		
> 			}
> 			
> 			if (file != null){
> 				log.info("Creating a new file");
> 				boolean renamed = file.renameTo(new File("/home/tomdev/ObjectCache/Expense Reports/"
+ fileName));
> 			} else {
> 				log.error("Attachment was null");
> 			}
> 			
> 			log.info("return success");
> 			return SUCCESS;
> 	}
>        public void prepare() throws Exception {
> 		
> 	}
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Work stopped: (WW-3339) Form data lost (null) when using post method with Internet Explorer 7. Get method works fine and post works fine with Firefox.

2009-12-01T14:12:13Z


     [ https://issues.apache.org/struts/browse/WW-3339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Work on WW-3339 stopped by Bryan Tartt.

> Form data lost (null) when using post method with Internet Explorer 7.  Get method works
fine and post works fine with Firefox. 
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WW-3339
>                 URL: https://issues.apache.org/struts/browse/WW-3339
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.1.8
>         Environment: Tomcat 5.5.28 on IBM ISeries, IE 7, Struts2, Java 5
>            Reporter: Bryan Tartt
>            Assignee: Bryan Tartt
>
> Every form that I have created has a problem retrieving data (returns null) in the Action
when using Internet Explorer 6 and form method is post.  I have not tested against other versions
of IE but FireFox works without any problems.  When I use get as the form method, the data
is passed in IE and FireFox.  I don't know if this is an IE and ISeries issue or a Struts
configuration (Interceptors) problem.  I have been searching for an answer on this problem
for weeks without any luck. 
> form
> <%@ page language="java" contentType="text/html; charset=UTF-8" pageEncoding="UTF-8"
%>
> <%@ page import="com.expensereport.*" %>
> <%--@ page errorPage="/ExpRepErrorHandler.jsp" --%>
> <%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core" %>
> <%@ taglib prefix="fmt" uri="http://java.sun.com/jsp/jstl/fmt" %>
> <%@ taglib prefix="s" uri="/struts-tags" %>
> <%@ taglib prefix="sx" uri="/struts-dojo-tags" %>
> 
> 
> 			
> 		Expense Reports
> 		
> 		
> 		" type="text/css">
> 		
> 		
> 	
> 
> 
> 
> 	
> 		
> 					
> 		   
> 			
> 			
> 		  
> 		  
> 			
> 			
> 		  
> 		
> 	Receipt Upload

> 
> 
> 
> struts.xml
>      "-//Apache Software Foundation//DTD Struts Configuration 2.1.7//EN"
>     "http://struts.apache.org/dtds/struts-2.1.7.dtd">
> 
> 		
> 		
> 		 		
> 		
> 		
> 		
> 			/ExpRepBadQueue.jsp
> 			/index.html
> 			/ExpRepBadQueue.jsp
> 		
> 		
> 			
> 		
> 		
> 			
>         

>         	
> 	        
>         	/ExpRepEntry.jsp
>         	/ExpRepEntry.jsp
>         
>         
>         	/ExpRepEntry.jsp
>         
>         
>         	/ExpRepDeleteConfirmation.jsp
>         	
>         		/ReportQueue
>         		EMPLOYEE
>         		ALL
>         	
>           
>         
>         	/AttendeeInput.jsp
>             
>         
>         	/AjaxRemoteForm.jsp
>         
> 		
> 
> Action
> package com.expensereport;
> import java.io.BufferedReader;
> import java.io.File;
> import java.io.FileInputStream;
> import java.io.FileNotFoundException;
> import java.io.FileOutputStream;
> import java.io.FileWriter;
> import java.io.IOException;
> import java.util.HashMap;
> import java.util.Iterator;
> import java.util.List;
> import java.util.Map;
> import javax.servlet.http.HttpServletRequest;
> import javax.servlet.http.HttpServletResponse;
> import org.apache.commons.fileupload.FileItem;
> import org.apache.commons.fileupload.FileItemFactory;
> import org.apache.commons.fileupload.FileUploadException;
> import org.apache.commons.fileupload.FileUploadBase.SizeLimitExceededException;
> import org.apache.commons.fileupload.disk.DiskFileItemFactory;
> import org.apache.commons.fileupload.servlet.ServletFileUpload;
> import org.apache.commons.fileupload.servlet.ServletRequestContext;
> import org.apache.struts2.ServletActionContext;
> import org.apache.struts2.dispatcher.multipart.MultiPartRequestWrapper;
> import org.apache.struts2.interceptor.ServletRequestAware;
> import org.apache.struts2.interceptor.ServletResponseAware;
> import org.apache.struts2.interceptor.SessionAware;
> import com.expensereport.EasyLog;
> import com.opensymphony.xwork2.ActionContext;
> import com.opensymphony.xwork2.ActionSupport;
> import com.opensymphony.xwork2.Preparable;
> public class ReceiptUpload extends ActionSupport implements SessionAware, Preparable
{
> 	
> 	/**
> 	 * 
> 	 */
> 	private static final long serialVersionUID = -2387150538575396408L;
> 	private File file;
> 	private String contentType;// The content type of the file
> 	private String fileName;// The uploaded file name and path
> 	private Map session;
> 	EasyLog log = new EasyLog();	
> 		
> 	
> 	public String execute(){
> 		
> 				
> 			getReceiptContentType();
> 			log.info("receiptContentType = " + contentType);
> 			getReceiptFileName();
> 			log.info("receiptFileName = " + fileName);
> 			getReceipt();		
> 			log.info("Receipt getName = " + file.getName());
> 					
> 			session = ActionContext.getContext().getSession();	 
> 			String reportID = "0000000";
> 			
> 			ExpenseReport er = (ExpenseReport) session.get("er");
> 			log.info("reportID = " + er.getErh().getReportID());
> 			
> 			if ((er.getErh().getReportID() == null) || (er.getErh().getReportID().trim().length()
< 1)){
> 				er.getErh().setReportID(reportID);		
> 			}
> 			
> 			if (file != null){
> 				log.info("Creating a new file");
> 				boolean renamed = file.renameTo(new File("/home/tomdev/ObjectCache/Expense Reports/"
+ fileName));
> 			} else {
> 				log.error("Attachment was null");
> 			}
> 			
> 			log.info("return success");
> 			return SUCCESS;
> 	}
>        public void prepare() throws Exception {
> 		
> 	}
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Work started: (WW-3339) Form data lost (null) when using post method with Internet Explorer 7. Get method works fine and post works fine with Firefox.

2009-12-01T14:10:13Z


     [ https://issues.apache.org/struts/browse/WW-3339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Work on WW-3339 started by Bryan Tartt.

> Form data lost (null) when using post method with Internet Explorer 7.  Get method works
fine and post works fine with Firefox. 
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WW-3339
>                 URL: https://issues.apache.org/struts/browse/WW-3339
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.1.8
>         Environment: Tomcat 5.5.28 on IBM ISeries, IE 7, Struts2, Java 5
>            Reporter: Bryan Tartt
>            Assignee: Bryan Tartt
>
> Every form that I have created has a problem retrieving data (returns null) in the Action
when using Internet Explorer 6 and form method is post.  I have not tested against other versions
of IE but FireFox works without any problems.  When I use get as the form method, the data
is passed in IE and FireFox.  I don't know if this is an IE and ISeries issue or a Struts
configuration (Interceptors) problem.  I have been searching for an answer on this problem
for weeks without any luck. 
> form
> <%@ page language="java" contentType="text/html; charset=UTF-8" pageEncoding="UTF-8"
%>
> <%@ page import="com.expensereport.*" %>
> <%--@ page errorPage="/ExpRepErrorHandler.jsp" --%>
> <%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core" %>
> <%@ taglib prefix="fmt" uri="http://java.sun.com/jsp/jstl/fmt" %>
> <%@ taglib prefix="s" uri="/struts-tags" %>
> <%@ taglib prefix="sx" uri="/struts-dojo-tags" %>
> 
> 
> 			
> 		Expense Reports
> 		
> 		
> 		" type="text/css">
> 		
> 		
> 	
> 
> 
> 
> 	
> 		
> 					
> 		   
> 			
> 			
> 		  
> 		  
> 			
> 			
> 		  
> 		
> 	Receipt Upload

> 
> 
> 
> struts.xml
>      "-//Apache Software Foundation//DTD Struts Configuration 2.1.7//EN"
>     "http://struts.apache.org/dtds/struts-2.1.7.dtd">
> 
> 		
> 		
> 		 		
> 		
> 		
> 		
> 			/ExpRepBadQueue.jsp
> 			/index.html
> 			/ExpRepBadQueue.jsp
> 		
> 		
> 			
> 		
> 		
> 			
>         

>         	
> 	        
>         	/ExpRepEntry.jsp
>         	/ExpRepEntry.jsp
>         
>         
>         	/ExpRepEntry.jsp
>         
>         
>         	/ExpRepDeleteConfirmation.jsp
>         	
>         		/ReportQueue
>         		EMPLOYEE
>         		ALL
>         	
>           
>         
>         	/AttendeeInput.jsp
>             
>         
>         	/AjaxRemoteForm.jsp
>         
> 		
> 
> Action
> package com.expensereport;
> import java.io.BufferedReader;
> import java.io.File;
> import java.io.FileInputStream;
> import java.io.FileNotFoundException;
> import java.io.FileOutputStream;
> import java.io.FileWriter;
> import java.io.IOException;
> import java.util.HashMap;
> import java.util.Iterator;
> import java.util.List;
> import java.util.Map;
> import javax.servlet.http.HttpServletRequest;
> import javax.servlet.http.HttpServletResponse;
> import org.apache.commons.fileupload.FileItem;
> import org.apache.commons.fileupload.FileItemFactory;
> import org.apache.commons.fileupload.FileUploadException;
> import org.apache.commons.fileupload.FileUploadBase.SizeLimitExceededException;
> import org.apache.commons.fileupload.disk.DiskFileItemFactory;
> import org.apache.commons.fileupload.servlet.ServletFileUpload;
> import org.apache.commons.fileupload.servlet.ServletRequestContext;
> import org.apache.struts2.ServletActionContext;
> import org.apache.struts2.dispatcher.multipart.MultiPartRequestWrapper;
> import org.apache.struts2.interceptor.ServletRequestAware;
> import org.apache.struts2.interceptor.ServletResponseAware;
> import org.apache.struts2.interceptor.SessionAware;
> import com.expensereport.EasyLog;
> import com.opensymphony.xwork2.ActionContext;
> import com.opensymphony.xwork2.ActionSupport;
> import com.opensymphony.xwork2.Preparable;
> public class ReceiptUpload extends ActionSupport implements SessionAware, Preparable
{
> 	
> 	/**
> 	 * 
> 	 */
> 	private static final long serialVersionUID = -2387150538575396408L;
> 	private File file;
> 	private String contentType;// The content type of the file
> 	private String fileName;// The uploaded file name and path
> 	private Map session;
> 	EasyLog log = new EasyLog();	
> 		
> 	
> 	public String execute(){
> 		
> 				
> 			getReceiptContentType();
> 			log.info("receiptContentType = " + contentType);
> 			getReceiptFileName();
> 			log.info("receiptFileName = " + fileName);
> 			getReceipt();		
> 			log.info("Receipt getName = " + file.getName());
> 					
> 			session = ActionContext.getContext().getSession();	 
> 			String reportID = "0000000";
> 			
> 			ExpenseReport er = (ExpenseReport) session.get("er");
> 			log.info("reportID = " + er.getErh().getReportID());
> 			
> 			if ((er.getErh().getReportID() == null) || (er.getErh().getReportID().trim().length()
< 1)){
> 				er.getErh().setReportID(reportID);		
> 			}
> 			
> 			if (file != null){
> 				log.info("Creating a new file");
> 				boolean renamed = file.renameTo(new File("/home/tomdev/ObjectCache/Expense Reports/"
+ fileName));
> 			} else {
> 				log.error("Attachment was null");
> 			}
> 			
> 			log.info("return success");
> 			return SUCCESS;
> 	}
>        public void prepare() throws Exception {
> 		
> 	}
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WW-3339) Form data lost (null) when using post method with Internet Explorer 7. Get method works fine and post works fine with Firefox.

2009-12-01T14:08:13Z


     [ https://issues.apache.org/struts/browse/WW-3339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Bryan Tartt updated WW-3339:
----------------------------

    Assignee: Bryan Tartt

> Form data lost (null) when using post method with Internet Explorer 7.  Get method works
fine and post works fine with Firefox. 
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WW-3339
>                 URL: https://issues.apache.org/struts/browse/WW-3339
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.1.8
>         Environment: Tomcat 5.5.28 on IBM ISeries, IE 7, Struts2, Java 5
>            Reporter: Bryan Tartt
>            Assignee: Bryan Tartt
>
> Every form that I have created has a problem retrieving data (returns null) in the Action
when using Internet Explorer 6 and form method is post.  I have not tested against other versions
of IE but FireFox works without any problems.  When I use get as the form method, the data
is passed in IE and FireFox.  I don't know if this is an IE and ISeries issue or a Struts
configuration (Interceptors) problem.  I have been searching for an answer on this problem
for weeks without any luck. 
> form
> <%@ page language="java" contentType="text/html; charset=UTF-8" pageEncoding="UTF-8"
%>
> <%@ page import="com.expensereport.*" %>
> <%--@ page errorPage="/ExpRepErrorHandler.jsp" --%>
> <%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core" %>
> <%@ taglib prefix="fmt" uri="http://java.sun.com/jsp/jstl/fmt" %>
> <%@ taglib prefix="s" uri="/struts-tags" %>
> <%@ taglib prefix="sx" uri="/struts-dojo-tags" %>
> 
> 
> 			
> 		Expense Reports
> 		
> 		
> 		" type="text/css">
> 		
> 		
> 	
> 
> 
> 
> 	
> 		
> 					
> 		   
> 			
> 			
> 		  
> 		  
> 			
> 			
> 		  
> 		
> 	Receipt Upload

> 
> 
> 
> struts.xml
>      "-//Apache Software Foundation//DTD Struts Configuration 2.1.7//EN"
>     "http://struts.apache.org/dtds/struts-2.1.7.dtd">
> 
> 		
> 		
> 		 		
> 		
> 		
> 		
> 			/ExpRepBadQueue.jsp
> 			/index.html
> 			/ExpRepBadQueue.jsp
> 		
> 		
> 			
> 		
> 		
> 			
>         

>         	
> 	        
>         	/ExpRepEntry.jsp
>         	/ExpRepEntry.jsp
>         
>         
>         	/ExpRepEntry.jsp
>         
>         
>         	/ExpRepDeleteConfirmation.jsp
>         	
>         		/ReportQueue
>         		EMPLOYEE
>         		ALL
>         	
>           
>         
>         	/AttendeeInput.jsp
>             
>         
>         	/AjaxRemoteForm.jsp
>         
> 		
> 
> Action
> package com.expensereport;
> import java.io.BufferedReader;
> import java.io.File;
> import java.io.FileInputStream;
> import java.io.FileNotFoundException;
> import java.io.FileOutputStream;
> import java.io.FileWriter;
> import java.io.IOException;
> import java.util.HashMap;
> import java.util.Iterator;
> import java.util.List;
> import java.util.Map;
> import javax.servlet.http.HttpServletRequest;
> import javax.servlet.http.HttpServletResponse;
> import org.apache.commons.fileupload.FileItem;
> import org.apache.commons.fileupload.FileItemFactory;
> import org.apache.commons.fileupload.FileUploadException;
> import org.apache.commons.fileupload.FileUploadBase.SizeLimitExceededException;
> import org.apache.commons.fileupload.disk.DiskFileItemFactory;
> import org.apache.commons.fileupload.servlet.ServletFileUpload;
> import org.apache.commons.fileupload.servlet.ServletRequestContext;
> import org.apache.struts2.ServletActionContext;
> import org.apache.struts2.dispatcher.multipart.MultiPartRequestWrapper;
> import org.apache.struts2.interceptor.ServletRequestAware;
> import org.apache.struts2.interceptor.ServletResponseAware;
> import org.apache.struts2.interceptor.SessionAware;
> import com.expensereport.EasyLog;
> import com.opensymphony.xwork2.ActionContext;
> import com.opensymphony.xwork2.ActionSupport;
> import com.opensymphony.xwork2.Preparable;
> public class ReceiptUpload extends ActionSupport implements SessionAware, Preparable
{
> 	
> 	/**
> 	 * 
> 	 */
> 	private static final long serialVersionUID = -2387150538575396408L;
> 	private File file;
> 	private String contentType;// The content type of the file
> 	private String fileName;// The uploaded file name and path
> 	private Map session;
> 	EasyLog log = new EasyLog();	
> 		
> 	
> 	public String execute(){
> 		
> 				
> 			getReceiptContentType();
> 			log.info("receiptContentType = " + contentType);
> 			getReceiptFileName();
> 			log.info("receiptFileName = " + fileName);
> 			getReceipt();		
> 			log.info("Receipt getName = " + file.getName());
> 					
> 			session = ActionContext.getContext().getSession();	 
> 			String reportID = "0000000";
> 			
> 			ExpenseReport er = (ExpenseReport) session.get("er");
> 			log.info("reportID = " + er.getErh().getReportID());
> 			
> 			if ((er.getErh().getReportID() == null) || (er.getErh().getReportID().trim().length()
< 1)){
> 				er.getErh().setReportID(reportID);		
> 			}
> 			
> 			if (file != null){
> 				log.info("Creating a new file");
> 				boolean renamed = file.renameTo(new File("/home/tomdev/ObjectCache/Expense Reports/"
+ fileName));
> 			} else {
> 				log.error("Attachment was null");
> 			}
> 			
> 			log.info("return success");
> 			return SUCCESS;
> 	}
>        public void prepare() throws Exception {
> 		
> 	}
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WW-3339) Form data lost (null) when using post method with Internet Explorer 7. Get method works fine and post works fine with Firefox.

2009-11-30T20:45:13Z


     [ https://issues.apache.org/struts/browse/WW-3339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Bryan Tartt updated WW-3339:
----------------------------

    Environment: Tomcat 5.5.28 on IBM ISeries, IE 7, Struts2, Java 5  (was: Tomcat 5.5.28
on IBM ISeries, IE 7, Struts2, Java 1.5)

> Form data lost (null) when using post method with Internet Explorer 7.  Get method works
fine and post works fine with Firefox. 
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WW-3339
>                 URL: https://issues.apache.org/struts/browse/WW-3339
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.1.8
>         Environment: Tomcat 5.5.28 on IBM ISeries, IE 7, Struts2, Java 5
>            Reporter: Bryan Tartt
>
> Every form that I have created has a problem retrieving data (returns null) in the Action
when using Internet Explorer 6 and form method is post.  I have not tested against other versions
of IE but FireFox works without any problems.  When I use get as the form method, the data
is passed in IE and FireFox.  I don't know if this is an IE and ISeries issue or a Struts
configuration (Interceptors) problem.  I have been searching for an answer on this problem
for weeks without any luck. 
> form
> <%@ page language="java" contentType="text/html; charset=UTF-8" pageEncoding="UTF-8"
%>
> <%@ page import="com.expensereport.*" %>
> <%--@ page errorPage="/ExpRepErrorHandler.jsp" --%>
> <%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core" %>
> <%@ taglib prefix="fmt" uri="http://java.sun.com/jsp/jstl/fmt" %>
> <%@ taglib prefix="s" uri="/struts-tags" %>
> <%@ taglib prefix="sx" uri="/struts-dojo-tags" %>
> 
> 
> 			
> 		Expense Reports
> 		
> 		
> 		" type="text/css">
> 		
> 		
> 	
> 
> 
> 
> 	
> 		
> 					
> 		   
> 			
> 			
> 		  
> 		  
> 			
> 			
> 		  
> 		
> 	Receipt Upload

> 
> 
> 
> struts.xml
>      "-//Apache Software Foundation//DTD Struts Configuration 2.1.7//EN"
>     "http://struts.apache.org/dtds/struts-2.1.7.dtd">
> 
> 		
> 		
> 		 		
> 		
> 		
> 		
> 			/ExpRepBadQueue.jsp
> 			/index.html
> 			/ExpRepBadQueue.jsp
> 		
> 		
> 			
> 		
> 		
> 			
>         

>         	
> 	        
>         	/ExpRepEntry.jsp
>         	/ExpRepEntry.jsp
>         
>         
>         	/ExpRepEntry.jsp
>         
>         
>         	/ExpRepDeleteConfirmation.jsp
>         	
>         		/ReportQueue
>         		EMPLOYEE
>         		ALL
>         	
>           
>         
>         	/AttendeeInput.jsp
>             
>         
>         	/AjaxRemoteForm.jsp
>         
> 		
> 
> Action
> package com.expensereport;
> import java.io.BufferedReader;
> import java.io.File;
> import java.io.FileInputStream;
> import java.io.FileNotFoundException;
> import java.io.FileOutputStream;
> import java.io.FileWriter;
> import java.io.IOException;
> import java.util.HashMap;
> import java.util.Iterator;
> import java.util.List;
> import java.util.Map;
> import javax.servlet.http.HttpServletRequest;
> import javax.servlet.http.HttpServletResponse;
> import org.apache.commons.fileupload.FileItem;
> import org.apache.commons.fileupload.FileItemFactory;
> import org.apache.commons.fileupload.FileUploadException;
> import org.apache.commons.fileupload.FileUploadBase.SizeLimitExceededException;
> import org.apache.commons.fileupload.disk.DiskFileItemFactory;
> import org.apache.commons.fileupload.servlet.ServletFileUpload;
> import org.apache.commons.fileupload.servlet.ServletRequestContext;
> import org.apache.struts2.ServletActionContext;
> import org.apache.struts2.dispatcher.multipart.MultiPartRequestWrapper;
> import org.apache.struts2.interceptor.ServletRequestAware;
> import org.apache.struts2.interceptor.ServletResponseAware;
> import org.apache.struts2.interceptor.SessionAware;
> import com.expensereport.EasyLog;
> import com.opensymphony.xwork2.ActionContext;
> import com.opensymphony.xwork2.ActionSupport;
> import com.opensymphony.xwork2.Preparable;
> public class ReceiptUpload extends ActionSupport implements SessionAware, Preparable
{
> 	
> 	/**
> 	 * 
> 	 */
> 	private static final long serialVersionUID = -2387150538575396408L;
> 	private File file;
> 	private String contentType;// The content type of the file
> 	private String fileName;// The uploaded file name and path
> 	private Map session;
> 	EasyLog log = new EasyLog();	
> 		
> 	
> 	public String execute(){
> 		
> 				
> 			getReceiptContentType();
> 			log.info("receiptContentType = " + contentType);
> 			getReceiptFileName();
> 			log.info("receiptFileName = " + fileName);
> 			getReceipt();		
> 			log.info("Receipt getName = " + file.getName());
> 					
> 			session = ActionContext.getContext().getSession();	 
> 			String reportID = "0000000";
> 			
> 			ExpenseReport er = (ExpenseReport) session.get("er");
> 			log.info("reportID = " + er.getErh().getReportID());
> 			
> 			if ((er.getErh().getReportID() == null) || (er.getErh().getReportID().trim().length()
< 1)){
> 				er.getErh().setReportID(reportID);		
> 			}
> 			
> 			if (file != null){
> 				log.info("Creating a new file");
> 				boolean renamed = file.renameTo(new File("/home/tomdev/ObjectCache/Expense Reports/"
+ fileName));
> 			} else {
> 				log.error("Attachment was null");
> 			}
> 			
> 			log.info("return success");
> 			return SUCCESS;
> 	}
>        public void prepare() throws Exception {
> 		
> 	}
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Created: (WW-3345) Disabled select lists

2009-11-30T13:57:13Z

Disabled select lists
---------------------

                 Key: WW-3345
                 URL: https://issues.apache.org/struts/browse/WW-3345
             Project: Struts 2
          Issue Type: Bug
    Affects Versions: 2.1.8
            Reporter: Diego Trombetta


Upgrading from version 2.1.2 to version 2.1.8 the behavior of disabled select lists have been
broken:
when a select list is disabled a hidden input field is generated to keep track of the value
in the form submits.
Having added the 'disabled' attribute to the hidden.ftl this field disabeld, so it is unuseful!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Created: (WW-3344) a wrong statement in the optiontransferselect documentation page

2009-11-30T12:53:13Z

a wrong statement in the optiontransferselect documentation page
----------------------------------------------------------------

                 Key: WW-3344
                 URL: https://issues.apache.org/struts/browse/WW-3344
             Project: Struts 2
          Issue Type: Bug
          Components: Documentation
    Affects Versions: 2.1.8
            Reporter: Ankit Garg
            Priority: Minor


On the last line of the description section of the page: http://struts.apache.org/2.x/docs/optiontransferselect.html
, it says

"The generated id and doubleId will be _
and _ respectively."
_________________________________________________________|----------------|

but it should be

"The generated id and doubleId will be _ and
_ respectively."
_________________________________________________________|-------|

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Issue Comment Edited: (WW-2132) Add support for JSP tag library dynamic attributes

2009-11-29T16:34:13Z


    [ https://issues.apache.org/struts/browse/WW-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47120#action_47120
] 

Rajeev kumar edited comment on WW-2132 at 11/29/09 4:33 PM:
------------------------------------------------------------

As ww-2092 contains patch.txt, can someone please provide me patch for src struts 2.0.11 for
above mentioned 1-7 steps.
At present I can't migrate to 2.1 series. So, please provide me patch for 1-7 steps.


      was (Author: rajeev):
    As ww-2092 contains patch.txt, can someone please provide me patch for src for struts
2.0.11 for above mentioned 1-7 steps.
  
> Add support for JSP tag library dynamic attributes
> --------------------------------------------------
>
>                 Key: WW-2132
>                 URL: https://issues.apache.org/struts/browse/WW-2132
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Documentation
>    Affects Versions: 2.1.0
>            Reporter: James Holmes
>            Assignee: James Holmes
>             Fix For: 2.1.3
>
>
> Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes
to Struts 2.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (WW-2132) Add support for JSP tag library dynamic attributes

2009-11-29T16:32:13Z


    [ https://issues.apache.org/struts/browse/WW-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47120#action_47120
] 

Rajeev kumar commented on WW-2132:
----------------------------------

As ww-2092 contains patch.txt, can someone please provide me patch for src for struts 2.0.11
for above mentioned 1-7 steps.

> Add support for JSP tag library dynamic attributes
> --------------------------------------------------
>
>                 Key: WW-2132
>                 URL: https://issues.apache.org/struts/browse/WW-2132
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Documentation
>    Affects Versions: 2.1.0
>            Reporter: James Holmes
>            Assignee: James Holmes
>             Fix For: 2.1.3
>
>
> Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes
to Struts 2.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (WW-3343) multiple forms on a single page renders wrong namespace in form action url

2009-11-27T21:15:13Z


    [ https://issues.apache.org/struts/browse/WW-3343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47119#action_47119
] 

Wes Wannemacher commented on WW-3343:
-------------------------------------

this may be a false alarm, the test I uploaded is wrong, but I am going to check to see if
I can reproduce in the project where I am having the problem.

> multiple forms on a single page renders wrong namespace in form action url
> --------------------------------------------------------------------------
>
>                 Key: WW-3343
>                 URL: https://issues.apache.org/struts/browse/WW-3343
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Actions
>    Affects Versions: 2.1.8.1
>            Reporter: Wes Wannemacher
>         Attachments: testForm.zip
>
>
> so, this has been bugging me for a while, I decided to test it out. A JSP like that contains
something like the following - 
> <%@ taglib uri="/struts-tags" prefix="s" %>
> 
> 
> Hello World!
> 
> 
> 
> 
> 
> 
> 
> 
> When the page is rendered, the second form will not respect the /baz namespace. I created
a sample app and will upload it here. I suspect the ServletUrlRenderer is the culprit, but
I'll research more. If someone gets this fixed before me, that's fine, I wanted to post it
to JIRA quick because this bug is a pain in my tuches. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WW-3343) multiple forms on a single page renders wrong namespace in form action url

2009-11-27T18:15:13Z


     [ https://issues.apache.org/struts/browse/WW-3343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Wes Wannemacher updated WW-3343:
--------------------------------

    Attachment: testForm.zip

this is a simple web-app to demonstrate the problem. You can unzip it and `mvn tomcat:run`
it to see the problem. Go to http://localhost:8080/testForm/index.action and then view the
source. Compare it against the JSP and what you would expect.

> multiple forms on a single page renders wrong namespace in form action url
> --------------------------------------------------------------------------
>
>                 Key: WW-3343
>                 URL: https://issues.apache.org/struts/browse/WW-3343
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Actions
>    Affects Versions: 2.1.8.1
>            Reporter: Wes Wannemacher
>         Attachments: testForm.zip
>
>
> so, this has been bugging me for a while, I decided to test it out. A JSP like that contains
something like the following - 
> <%@ taglib uri="/struts-tags" prefix="s" %>
> 
> 
> Hello World!
> 
> 
> 
> 
> 
> 
> 
> 
> When the page is rendered, the second form will not respect the /baz namespace. I created
a sample app and will upload it here. I suspect the ServletUrlRenderer is the culprit, but
I'll research more. If someone gets this fixed before me, that's fine, I wanted to post it
to JIRA quick because this bug is a pain in my tuches. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Created: (WW-3343) multiple forms on a single page renders wrong namespace in form action url

2009-11-27T18:13:13Z

multiple forms on a single page renders wrong namespace in form action url
--------------------------------------------------------------------------

                 Key: WW-3343
                 URL: https://issues.apache.org/struts/browse/WW-3343
             Project: Struts 2
          Issue Type: Bug
          Components: Core Actions
    Affects Versions: 2.1.8.1
            Reporter: Wes Wannemacher


so, this has been bugging me for a while, I decided to test it out. A JSP like that contains
something like the following - 

<%@ taglib uri="/struts-tags" prefix="s" %>


Hello World!









When the page is rendered, the second form will not respect the /baz namespace. I created
a sample app and will upload it here. I suspect the ServletUrlRenderer is the culprit, but
I'll research more. If someone gets this fixed before me, that's fine, I wanted to post it
to JIRA quick because this bug is a pain in my tuches. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (WW-3342) FilterDispatcher URL Pattren

2009-11-26T16:50:13Z


    [ https://issues.apache.org/struts/browse/WW-3342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47117#action_47117
] 

Lukasz Lenart commented on WW-3342:
-----------------------------------

Please ask question on Struts User Group - user@struts.apache.org

and you can use following mapping:

    
      struts2
      *.action
    

but please then remember to extract static files from struts-core.jar (the struts folder)


Regards
--
Lukasz

> FilterDispatcher URL Pattren
> ----------------------------
>
>                 Key: WW-3342
>                 URL: https://issues.apache.org/struts/browse/WW-3342
>             Project: Struts 2
>          Issue Type: Task
>          Components: Dispatch Filter
>    Affects Versions: 2.1.6
>         Environment: Weblogic 10.3
> ICEFaces 1.8.1
>            Reporter: kishore kumar
>            Priority: Blocker
>
> Hi,
> Is there a way to change the FilterDispatcher URL Pattren other than /*?
> I am using ICEFaces and struts2 togeather but due to struts2 URL Pattren ICEFaces requests
are being ignored.
> Can i use url-pattren /*.action  ?
> As per the struts documentation it says to use following
> 
>       struts2
>       org.apache.struts2.dispatcher.FilterDispatcher
>     
>     
>       struts2
>       /*
>     

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Closed: (WW-3342) FilterDispatcher URL Pattren

2009-11-26T16:50:13Z


     [ https://issues.apache.org/struts/browse/WW-3342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Lukasz Lenart closed WW-3342.
-----------------------------

    Resolution: Not A Problem
      Assignee: Lukasz Lenart

> FilterDispatcher URL Pattren
> ----------------------------
>
>                 Key: WW-3342
>                 URL: https://issues.apache.org/struts/browse/WW-3342
>             Project: Struts 2
>          Issue Type: Task
>          Components: Dispatch Filter
>    Affects Versions: 2.1.6
>         Environment: Weblogic 10.3
> ICEFaces 1.8.1
>            Reporter: kishore kumar
>            Assignee: Lukasz Lenart
>            Priority: Blocker
>
> Hi,
> Is there a way to change the FilterDispatcher URL Pattren other than /*?
> I am using ICEFaces and struts2 togeather but due to struts2 URL Pattren ICEFaces requests
are being ignored.
> Can i use url-pattren /*.action  ?
> As per the struts documentation it says to use following
> 
>       struts2
>       org.apache.struts2.dispatcher.FilterDispatcher
>     
>     
>       struts2
>       /*
>     

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Created: (WW-3342) FilterDispatcher URL Pattren

2009-11-26T14:52:13Z

FilterDispatcher URL Pattren
----------------------------

                 Key: WW-3342
                 URL: https://issues.apache.org/struts/browse/WW-3342
             Project: Struts 2
          Issue Type: Task
          Components: Dispatch Filter
    Affects Versions: 2.1.6
         Environment: Weblogic 10.3
ICEFaces 1.8.1
            Reporter: kishore kumar
            Priority: Blocker


Hi,

Is there a way to change the FilterDispatcher URL Pattren other than /*?
I am using ICEFaces and struts2 togeather but due to struts2 URL Pattren ICEFaces requests
are being ignored.

Can i use url-pattren /*.action  ?

As per the struts documentation it says to use following


      struts2
      org.apache.struts2.dispatcher.FilterDispatcher
    
    
      struts2
      /*
    


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (WW-3308) javassist trouble on JBoss 5.1

2009-11-26T09:00:13Z


    [ https://issues.apache.org/struts/browse/WW-3308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47116#action_47116
] 

Mykyta Kostovskyy commented on WW-3308:
---------------------------------------

Well, I am using struts with JBoss 5 and new version of xworks contains javassist which is
also included in the JBoss itself. So on one of the places it has to be removed to avoid the
conflict.

let me know if you have any questions and I would be glad to help.

> javassist trouble on JBoss 5.1
> ------------------------------
>
>                 Key: WW-3308
>                 URL: https://issues.apache.org/struts/browse/WW-3308
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Other
>    Affects Versions: 2.1.8
>         Environment: JBoss 5.1 GA, Struts 2.1.8
>            Reporter: Mykyta Kostovskyy
>            Assignee: Lukasz Lenart
>            Priority: Critical
>
> While deploying application that contains Struts 2.1.8 get the following error:
> 17:28:34,437 ERROR [BasicLazyInitializer] Javassist Enhancement failed: hello.Message
> java.lang.RuntimeException: java.lang.IllegalArgumentException: Can not set static javassist.util.proxy.MethodFilter
field hello.Message_$$_javassist_14._method_filter to org.hibernate.proxy.pojo.javassist.JavassistLazyInitializer$1
> 	at javassist.util.proxy.ProxyFactory.setField(ProxyFactory.java:358)
> 	at javassist.util.proxy.ProxyFactory.createClass3(ProxyFactory.java:341)
> 	at javassist.util.proxy.ProxyFactory.createClass2(ProxyFactory.java:314)
> 	at javassist.util.proxy.ProxyFactory.createClass(ProxyFactory.java:273)
> 	at org.hibernate.proxy.pojo.javassist.JavassistLazyInitializer.getProxyFactory(JavassistLazyInitializer.java:162)
> 	at org.hibernate.proxy.pojo.javassist.JavassistProxyFactory.postInstantiate(JavassistProxyFactory.java:66)
> 	at org.hibernate.tuple.entity.PojoEntityTuplizer.buildProxyFactory(PojoEntityTuplizer.java:183)
> 	at org.hibernate.tuple.entity.AbstractEntityTuplizer.(AbstractEntityTuplizer.java:158)
> 	at org.hibernate.tuple.entity.PojoEntityTuplizer.(PojoEntityTuplizer.java:76)
> 	at org.hibernate.tuple.entity.EntityEntityModeToTuplizerMapping.(EntityEntityModeToTuplizerMapping.java:80)
> 	at org.hibernate.tuple.entity.EntityMetamodel.(EntityMetamodel.java:325)
> 	at org.hibernate.persister.entity.AbstractEntityPersister.(AbstractEntityPersister.java:457)
> 	at org.hibernate.persister.entity.SingleTableEntityPersister.(SingleTableEntityPersister.java:131)
> 	at org.hibernate.persister.PersisterFactory.createClassPersister(PersisterFactory.java:84)
> 	at org.hibernate.impl.SessionFactoryImpl.(SessionFactoryImpl.java:261)
> 	at org.hibernate.cfg.Configuration.buildSessionFactory(Configuration.java:1327)
> 	at org.hibernate.cfg.AnnotationConfiguration.buildSessionFactory(AnnotationConfiguration.java:867)
> 	at org.hibernate.ejb.Ejb3Configuration.buildEntityManagerFactory(Ejb3Configuration.java:669)
> 	at org.hibernate.ejb.HibernatePersistence.createContainerEntityManagerFactory(HibernatePersistence.java:132)
> 	at org.springframework.orm.jpa.LocalContainerEntityManagerFactoryBean.createNativeEntityManagerFactory(LocalContainerEntityManagerFactoryBean.java:224)
> 	at org.springframework.orm.jpa.AbstractEntityManagerFactoryBean.afterPropertiesSet(AbstractEntityManagerFactoryBean.java:291)
> 	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.invokeInitMethods(AbstractAutowireCapableBeanFactory.java:1369)
> 	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.initializeBean(AbstractAutowireCapableBeanFactory.java:1335)
> 	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:473)
> 	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory$1.run(AbstractAutowireCapableBeanFactory.java:409)
> 	at java.security.AccessController.doPrivileged(Native Method)
> 	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:380)
> 	at org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:264)
> 	at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:222)
> 	at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:261)
> 	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:185)
> 	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:164)
> 	at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:423)
> 	at org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:728)
> 	at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:380)
> 	at org.springframework.web.context.ContextLoader.createWebApplicationContext(ContextLoader.java:255)
> 	at org.springframework.web.context.ContextLoader.initWebApplicationContext(ContextLoader.java:199)
> 	at org.springframework.web.context.ContextLoaderListener.contextInitialized(ContextLoaderListener.java:45)
> 	at org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:3910)
> 	at org.apache.catalina.core.StandardContext.start(StandardContext.java:4393)
> 	at org.jboss.web.tomcat.service.deployers.TomcatDeployment.performDeployInternal(TomcatDeployment.java:310)
> 	at org.jboss.web.tomcat.service.deployers.TomcatDeployment.performDeploy(TomcatDeployment.java:142)
> 	at org.jboss.web.deployers.AbstractWarDeployment.start(AbstractWarDeployment.java:461)
> 	at org.jboss.web.deployers.WebModule.startModule(WebModule.java:118)
> 	at org.jboss.web.deployers.WebModule.start(WebModule.java:97)
> 	at sun.reflect.GeneratedMethodAccessor381.invoke(Unknown Source)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> 	at java.lang.reflect.Method.invoke(Method.java:597)
> 	at org.jboss.mx.interceptor.ReflectedDispatcher.invoke(ReflectedDispatcher.java:157)
> 	at org.jboss.mx.server.Invocation.dispatch(Invocation.java:96)
> 	at org.jboss.mx.server.Invocation.invoke(Invocation.java:88)
> 	at org.jboss.mx.server.AbstractMBeanInvoker.invoke(AbstractMBeanInvoker.java:264)
> 	at org.jboss.mx.server.MBeanServerImpl.invoke(MBeanServerImpl.java:668)
> 	at org.jboss.system.microcontainer.ServiceProxy.invoke(ServiceProxy.java:206)
> 	at $Proxy38.start(Unknown Source)
> 	at org.jboss.system.microcontainer.StartStopLifecycleAction.installAction(StartStopLifecycleAction.java:42)
> 	at org.jboss.system.microcontainer.StartStopLifecycleAction.installAction(StartStopLifecycleAction.java:37)
> 	at org.jboss.dependency.plugins.action.SimpleControllerContextAction.simpleInstallAction(SimpleControllerContextAction.java:62)
> 	at org.jboss.dependency.plugins.action.AccessControllerContextAction.install(AccessControllerContextAction.java:71)
> 	at org.jboss.dependency.plugins.AbstractControllerContextActions.install(AbstractControllerContextActions.java:51)
> 	at org.jboss.dependency.plugins.AbstractControllerContext.install(AbstractControllerContext.java:348)
> 	at org.jboss.system.microcontainer.ServiceControllerContext.install(ServiceControllerContext.java:286)
> 	at org.jboss.dependency.plugins.AbstractController.install(AbstractController.java:1631)
> 	at org.jboss.dependency.plugins.AbstractController.incrementState(AbstractController.java:934)
> 	at org.jboss.dependency.plugins.AbstractController.resolveContexts(AbstractController.java:1082)
> 	at org.jboss.dependency.plugins.AbstractController.resolveContexts(AbstractController.java:984)
> 	at org.jboss.dependency.plugins.AbstractController.change(AbstractController.java:822)
> 	at org.jboss.dependency.plugins.AbstractController.change(AbstractController.java:553)
> 	at org.jboss.system.ServiceController.doChange(ServiceController.java:688)
> 	at org.jboss.system.ServiceController.start(ServiceController.java:460)
> 	at org.jboss.system.deployers.ServiceDeployer.start(ServiceDeployer.java:163)
> 	at org.jboss.system.deployers.ServiceDeployer.deploy(ServiceDeployer.java:99)
> 	at org.jboss.system.deployers.ServiceDeployer.deploy(ServiceDeployer.java:46)
> 	at org.jboss.deployers.spi.deployer.helpers.AbstractSimpleRealDeployer.internalDeploy(AbstractSimpleRealDeployer.java:62)
> 	at org.jboss.deployers.spi.deployer.helpers.AbstractRealDeployer.deploy(AbstractRealDeployer.java:50)
> 	at org.jboss.deployers.plugins.deployers.DeployerWrapper.deploy(DeployerWrapper.java:171)
> 	at org.jboss.deployers.plugins.deployers.DeployersImpl.doDeploy(DeployersImpl.java:1439)
> 	at org.jboss.deployers.plugins.deployers.DeployersImpl.doInstallParentFirst(DeployersImpl.java:1157)
> 	at org.jboss.deployers.plugins.deployers.DeployersImpl.doInstallParentFirst(DeployersImpl.java:1178)
> 	at org.jboss.deployers.plugins.deployers.DeployersImpl.install(DeployersImpl.java:1098)
> 	at org.jboss.dependency.plugins.AbstractControllerContext.install(AbstractControllerContext.java:348)
> 	at org.jboss.dependency.plugins.AbstractController.install(AbstractController.java:1631)
> 	at org.jboss.dependency.plugins.AbstractController.incrementState(AbstractController.java:934)
> 	at org.jboss.dependency.plugins.AbstractController.resolveContexts(AbstractController.java:1082)
> 	at org.jboss.dependency.plugins.AbstractController.resolveContexts(AbstractController.java:984)
> 	at org.jboss.dependency.plugins.AbstractController.change(AbstractController.java:822)
> 	at org.jboss.dependency.plugins.AbstractController.change(AbstractController.java:553)
> 	at org.jboss.deployers.plugins.deployers.DeployersImpl.process(DeployersImpl.java:781)
> 	at org.jboss.deployers.plugins.main.MainDeployerImpl.process(MainDeployerImpl.java:702)
> 	at org.jboss.system.server.profileservice.repository.MainDeployerAdapter.process(MainDeployerAdapter.java:117)
> 	at org.jboss.system.server.profileservice.hotdeploy.HDScanner.scan(HDScanner.java:362)
> 	at org.jboss.system.server.profileservice.hotdeploy.HDScanner.run(HDScanner.java:255)
> 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
> 	at java.util.concurrent.FutureTask$Sync.innerRunAndReset(FutureTask.java:317)
> 	at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:150)
> 	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:98)
> 	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.runPeriodic(ScheduledThreadPoolExecutor.java:181)
> 	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:205)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
> 	at java.lang.Thread.run(Thread.java:619)
> Caused by: java.lang.IllegalArgumentException: Can not set static javassist.util.proxy.MethodFilter
field hello.Message_$$_javassist_14._method_filter to org.hibernate.proxy.pojo.javassist.JavassistLazyInitializer$1
> 	at sun.reflect.UnsafeFieldAccessorImpl.throwSetIllegalArgumentException(UnsafeFieldAccessorImpl.java:146)
> 	at sun.reflect.UnsafeFieldAccessorImpl.throwSetIllegalArgumentException(UnsafeFieldAccessorImpl.java:150)
> 	at sun.reflect.UnsafeStaticObjectFieldAccessorImpl.set(UnsafeStaticObjectFieldAccessorImpl.java:61)
> 	at java.lang.reflect.Field.set(Field.java:657)
> 	at javassist.util.proxy.ProxyFactory.setField(ProxyFactory.java:354)
> 	... 100 more
> This is due to the fact, that xworks-core-2.1.6.jar that is a part of Struts 2.1.8 is
delivered with javassist code inside, that conflicts with the one inside of JBoss.
> Please help to resolve the problem, since Struts 2.1.8 does not work with previous versions
of xworks.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (WW-3340) ognl-2.7.3 has a blocker issue

2009-11-26T08:44:13Z


    [ https://issues.apache.org/struts/browse/WW-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47115#action_47115
] 

Andrei Ivanov commented on WW-3340:
-----------------------------------

Please don't forget about the ognl version that's being used and its blocker issue.
It seems that ognl doesn't have an active maintainer anymore.

> ognl-2.7.3 has a blocker issue
> ------------------------------
>
>                 Key: WW-3340
>                 URL: https://issues.apache.org/struts/browse/WW-3340
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.1.8
>            Reporter: Andrei Ivanov
>            Assignee: Lukasz Lenart
>            Priority: Critical
>             Fix For: 2.2.0
>
>
> Because of WW-3197, Struts2 now depends on ognl-2.7.3, which has a blocker issue: http://jira.opensymphony.com/browse/OGNL-149
> Also, xwork-core-2.1.6.jar from the struts-2.1.8.1-all.zip contains javaassist and ognl,
so the ognl classes come from 2 jars.
> It also contains relocated classes from commons-lang and asm.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WW-3341) Dispatcher catches Exceptions silently since 2.1.1

2009-11-26T04:46:14Z


     [ https://issues.apache.org/struts/browse/WW-3341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Nicolas Berthet updated WW-3341:
--------------------------------

    Description: 
Trying to migrate from 2.0.x to 2.1.8.1, I noticed that the exception handling from the Dispatcher
changed.

Before :
The dispatcher threw a ServletException and it was propagated through the stack

Since 2.1.1 :
The dispatcher catch all Exceptions and call sendError

The problem is that the exception will not go up through the stack as it was the case before,
so nobody in the stack (j2ee filters) will notice this exception (unless checking requests
attributes, which is not a good way).

If you use a javax.servlet.Filter for things such as open-session-in-view, you will not notice
the exception, and maybe fail to rollback your current transaction, same for exception tracing
filters, etc...

It is a severe non-backward-compatible change, it was not mentionned in any of the changelogs.
It seems it has introduced by revision 602665, seems to be related to the fix for WW-218.

>From Dispatcher.serviceAction javadoc...
"All other errors are reported by throwing a ServletException."

The exception handling has to be clarified, I think propagating a ServletException is more
correct as it relies on the container and allow filters to take it into account. 

  was:
Trying to migrate from 2.0.x to 2.1.8.1, I noticed that the exception handling from the Dispatcher
changed.

Before :
The dispatcher threw a ServletException and it was propagated through the stack

Since 2.1.1 :
The dispatcher catch all Exceptions and call sendError

The problem is that the exception will not go up through the stack as it was the case before,
so nobody in the stack (j2ee filters) will notice this exception (unless checking requests
attributes, which is not a good way).

If you use a javax.servlet.Filter for things such as open-session-in-view, you will not notice
the exception, and maybe fail to rollback your current transaction, same for exception tracing
filters, etc...

It is a severe non-backward-compatible change, it was not mentionned in any of the changelogs.
It seems it has introduced by revision 602665, seems to be related to the fix for WW-218.

The exception handling has to be clarified, I think propagating a ServletException is more
correct as it relies on the container and allow filters to take it into account.


> Dispatcher catches Exceptions silently since 2.1.1
> --------------------------------------------------
>
>                 Key: WW-3341
>                 URL: https://issues.apache.org/struts/browse/WW-3341
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.1.1, 2.1.2, 2.1.3, 2.1.4, 2.1.5, 2.1.6, 2.1.8
>            Reporter: Nicolas Berthet
>            Priority: Critical
>
> Trying to migrate from 2.0.x to 2.1.8.1, I noticed that the exception handling from the
Dispatcher changed.
> Before :
> The dispatcher threw a ServletException and it was propagated through the stack
> Since 2.1.1 :
> The dispatcher catch all Exceptions and call sendError
> The problem is that the exception will not go up through the stack as it was the case
before, so nobody in the stack (j2ee filters) will notice this exception (unless checking
requests attributes, which is not a good way).
> If you use a javax.servlet.Filter for things such as open-session-in-view, you will not
notice the exception, and maybe fail to rollback your current transaction, same for exception
tracing filters, etc...
> It is a severe non-backward-compatible change, it was not mentionned in any of the changelogs.
It seems it has introduced by revision 602665, seems to be related to the fix for WW-218.
> From Dispatcher.serviceAction javadoc...
> "All other errors are reported by throwing a ServletException."
> The exception handling has to be clarified, I think propagating a ServletException is
more correct as it relies on the container and allow filters to take it into account. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Created: (WW-3341) Dispatcher catches Exceptions silently since 2.1.1

2009-11-26T04:08:13Z

Dispatcher catches Exceptions silently since 2.1.1
--------------------------------------------------

Key: WW-3341
URL: https://issues.apache.org/struts/browse/WW-3341
Project: Struts 2
Issue Type: Bug
Affects Versions: 2.1.8, 2.1.6, 2.1.5, 2.1.4, 2.1.3, 2.1.2, 2.1.1
Reporter: Nicolas Berthet
Priority: Critical

Trying to migrate from 2.0.x to 2.1.8.1, I noticed that the exception handling from the Dispatcher
changed.

Before :
The dispatcher threw a ServletException and it was propagated through the stack

Since 2.1.1 :
The dispatcher catch all Exceptions and call sendError

The problem is that the exception will not go up through the stack as it was the case before,
so nobody in the stack (j2ee filters) will notice this exception (unless checking requests
attributes, which is not a good way).

If you use a javax.servlet.Filter for things such as open-session-in-view, you will not notice
the exception, and maybe fail to rollback your current transaction, same for exception tracing
filters, etc...

It is a severe non-backward-compatible change, it was not mentionned in any of the changelogs.
It seems it has introduced by revision 602665, seems to be related to the fix for WW-218.

The exception handling has to be clarified, I think propagating a ServletException is more
correct as it relies on the container and allow filters to take it into account.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (WW-3340) ognl-2.7.3 has a blocker issue

2009-11-25T22:24:13Z


    [ https://issues.apache.org/struts/browse/WW-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47114#action_47114
] 

Lukasz Lenart commented on WW-3340:
-----------------------------------

Yes, you're right! I excluded javassist from xwork and included it in struts2

Regards
--
Lukasz

> ognl-2.7.3 has a blocker issue
> ------------------------------
>
>                 Key: WW-3340
>                 URL: https://issues.apache.org/struts/browse/WW-3340
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.1.8
>            Reporter: Andrei Ivanov
>            Assignee: Lukasz Lenart
>            Priority: Critical
>             Fix For: 2.2.0
>
>
> Because of WW-3197, Struts2 now depends on ognl-2.7.3, which has a blocker issue: http://jira.opensymphony.com/browse/OGNL-149
> Also, xwork-core-2.1.6.jar from the struts-2.1.8.1-all.zip contains javaassist and ognl,
so the ognl classes come from 2 jars.
> It also contains relocated classes from commons-lang and asm.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (WW-3340) ognl-2.7.3 has a blocker issue

2009-11-25T22:02:13Z


    [ https://issues.apache.org/struts/browse/WW-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47113#action_47113
] 

Musachy Barroso commented on WW-3340:
-------------------------------------

ognl is already excluded from shading in xwork core pom.xml, but javassist is not

> ognl-2.7.3 has a blocker issue
> ------------------------------
>
>                 Key: WW-3340
>                 URL: https://issues.apache.org/struts/browse/WW-3340
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.1.8
>            Reporter: Andrei Ivanov
>            Assignee: Lukasz Lenart
>            Priority: Critical
>             Fix For: 2.2.0
>
>
> Because of WW-3197, Struts2 now depends on ognl-2.7.3, which has a blocker issue: http://jira.opensymphony.com/browse/OGNL-149
> Also, xwork-core-2.1.6.jar from the struts-2.1.8.1-all.zip contains javaassist and ognl,
so the ognl classes come from 2 jars.
> It also contains relocated classes from commons-lang and asm.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.