From issues-return-33365-archive-asf-public=cust-asf.ponee.io@struts.apache.org Mon Jun 3 07:49:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 84B0A180763 for ; Mon, 3 Jun 2019 09:49:04 +0200 (CEST) Received: (qmail 22620 invoked by uid 500); 3 Jun 2019 07:49:03 -0000 Mailing-List: contact issues-help@struts.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@struts.apache.org Delivered-To: mailing list issues@struts.apache.org Received: (qmail 22520 invoked by uid 99); 3 Jun 2019 07:49:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Jun 2019 07:49:02 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 72DCDE2B65 for ; Mon, 3 Jun 2019 07:49:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 173EB245C3 for ; Mon, 3 Jun 2019 07:49:01 +0000 (UTC) Date: Mon, 3 Jun 2019 07:49:01 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@struts.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (WW-4999) Can't get OgnlValueStack log even if enable logMissingProperties MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/WW-4999?page=3Dcom.atlassian.ji= ra.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1685431= 3#comment-16854313 ]=20 ASF subversion and git services commented on WW-4999: ----------------------------------------------------- Commit a16cd4fca62e5df43b9afb045443f6e581d4a41e in struts's branch refs/hea= ds/master from Yasser Zamani [ https://gitbox.apache.org/repos/asf?p=3Dstruts.git;h=3Da16cd4f ] test not throw exception on top missing property (WW-4999) instead continue to next objects in stack Also tests not skip returned null values by user method (cherry picked from commit d4dd338) > Can't get OgnlValueStack log even if enable logMissingProperties > ---------------------------------------------------------------- > > Key: WW-4999 > URL: https://issues.apache.org/jira/browse/WW-4999 > Project: Struts 2 > Issue Type: Bug > Components: Value Stack > Affects Versions: 2.5.17 > Reporter: Quincy Qu > Assignee: Yasser Zamani > Priority: Major > Fix For: 2.5.21, 2.6 > > > I'm in devMode, enabled=C2=A0logMissingProperties and expect to see missi= ng property warning in the log. I was surprised that I can't get the missin= g property log even if=C2=A0logMissingProperties is set true. The applicati= on run smoothly and skip the missing property - as expected though. > In another run, I enabled both=C2=A0logMissingProperties and=C2=A0throwEx= ceptionOnFailure. This time the application crash at the missing property a= nd I can get both logs and exception. > After I dive deeper using debugger, I convince myself the config is good,= since devMode and=C2=A0logMissingProperties are true at runtime in OgnlVal= ueStack. > I was confused, why we can't get missing property log without throwing Og= nlException?=C2=A0 > Are we able to enter handleOgnlException(String expr, boolean throwExcept= ionOnFailure, OgnlException e)=C2=A0 at all if=C2=A0throwExceptionOnFailure= is false, in which my expected log is written? -- This message was sent by Atlassian JIRA (v7.6.3#76005)