struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4999) Can't get OgnlValueStack log even if enable logMissingProperties
Date Mon, 03 Jun 2019 07:52:00 GMT

    [ https://issues.apache.org/jira/browse/WW-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854319#comment-16854319
] 

Hudson commented on WW-4999:
----------------------------

FAILURE: Integrated in Jenkins build Struts-master-JDK8 #256 (See [https://builds.apache.org/job/Struts-master-JDK8/256/])
fix logMissingProperties (WW-4999) (yasserzamani: rev b657a272d1d2ae93dc5fd0a1b7f81d6ae1772e89)
* (edit) core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java
* (edit) core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java
* (edit) core/src/main/java/com/opensymphony/xwork2/ognl/accessor/CompoundRootAccessor.java
not log user exceptions as missing properties (WW-4999) (yasserzamani: rev 382124cfd2c3eb2f757e6faaf9a7a58f5e002765)
* (edit) core/src/main/java/com/opensymphony/xwork2/ognl/accessor/CompoundRootAccessor.java
* (edit) core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java
* (edit) core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java
test not throw exception on top missing property (WW-4999) (yasserzamani: rev a16cd4fca62e5df43b9afb045443f6e581d4a41e)
* (edit) core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java
decouple logMissingProperties from devMode (WW-4999) (yasserzamani: rev eca9c34645882b7d28b5b2dab42c0c3b4a0b10a3)
* (edit) core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java
* (edit) core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java
test false for logMissingProperties (WW-4999) (yasserzamani: rev 704e41c6e802972def971c1223a3aa522e525bdb)
* (edit) core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java


> Can't get OgnlValueStack log even if enable logMissingProperties
> ----------------------------------------------------------------
>
>                 Key: WW-4999
>                 URL: https://issues.apache.org/jira/browse/WW-4999
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Value Stack
>    Affects Versions: 2.5.17
>            Reporter: Quincy Qu
>            Assignee: Yasser Zamani
>            Priority: Major
>             Fix For: 2.5.21, 2.6
>
>
> I'm in devMode, enabled logMissingProperties and expect to see missing property warning
in the log. I was surprised that I can't get the missing property log even if logMissingProperties
is set true. The application run smoothly and skip the missing property - as expected though.
> In another run, I enabled both logMissingProperties and throwExceptionOnFailure. This
time the application crash at the missing property and I can get both logs and exception.
> After I dive deeper using debugger, I convince myself the config is good, since devMode
and logMissingProperties are true at runtime in OgnlValueStack.
> I was confused, why we can't get missing property log without throwing OgnlException? 
> Are we able to enter handleOgnlException(String expr, boolean throwExceptionOnFailure,
OgnlException e)  at all if throwExceptionOnFailure is false, in which my expected log is
written?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message