struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (WW-4999) Can't get OgnlValueStack log even if enable logMissingProperties
Date Mon, 03 Jun 2019 07:49:01 GMT


ASF subversion and git services commented on WW-4999:

Commit a16cd4fca62e5df43b9afb045443f6e581d4a41e in struts's branch refs/heads/master from
Yasser Zamani
[;h=a16cd4f ]

test not throw exception on top missing property (WW-4999)

instead continue to next objects in stack

Also tests not skip returned null values by user method

(cherry picked from commit d4dd338)

> Can't get OgnlValueStack log even if enable logMissingProperties
> ----------------------------------------------------------------
>                 Key: WW-4999
>                 URL:
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Value Stack
>    Affects Versions: 2.5.17
>            Reporter: Quincy Qu
>            Assignee: Yasser Zamani
>            Priority: Major
>             Fix For: 2.5.21, 2.6
> I'm in devMode, enabled logMissingProperties and expect to see missing property warning
in the log. I was surprised that I can't get the missing property log even if logMissingProperties
is set true. The application run smoothly and skip the missing property - as expected though.
> In another run, I enabled both logMissingProperties and throwExceptionOnFailure. This
time the application crash at the missing property and I can get both logs and exception.
> After I dive deeper using debugger, I convince myself the config is good, since devMode
and logMissingProperties are true at runtime in OgnlValueStack.
> I was confused, why we can't get missing property log without throwing OgnlException? 
> Are we able to enter handleOgnlException(String expr, boolean throwExceptionOnFailure,
OgnlException e)  at all if throwExceptionOnFailure is false, in which my expected log is

This message was sent by Atlassian JIRA

View raw message