From issues-return-33344-archive-asf-public=cust-asf.ponee.io@struts.apache.org Thu May 30 12:10:09 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 03ADD180771 for ; Thu, 30 May 2019 14:10:07 +0200 (CEST) Received: (qmail 61208 invoked by uid 500); 30 May 2019 12:10:07 -0000 Mailing-List: contact issues-help@struts.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@struts.apache.org Delivered-To: mailing list issues@struts.apache.org Received: (qmail 61102 invoked by uid 99); 30 May 2019 12:10:06 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 May 2019 12:10:06 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A47EAE2CC3 for ; Thu, 30 May 2019 12:10:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4F5EE245E3 for ; Thu, 30 May 2019 12:10:04 +0000 (UTC) Date: Thu, 30 May 2019 12:10:04 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@struts.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (WW-4999) Can't get OgnlValueStack log even if enable logMissingProperties MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/WW-4999?page=3Dcom.atlassian.ji= ra.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1685180= 2#comment-16851802 ]=20 ASF GitHub Bot commented on WW-4999: ------------------------------------ yasserzamani commented on pull request #358: fix logMissingProperties (WW-4= 999) URL: https://github.com/apache/struts/pull/358 =20 =20 Moves checking OgnlValueStack.THROW_EXCEPTION_ON_FAILURE outside loop be= cause it shouldn't throw exception on first failure while is trying all roo= t objects. =20 Returns on first successful call because it's not rational and is confus= ing user to skip when user method successfully returns null as an actual re= sult. =20 Fixes WW-4999 via honoring (devMode && logMissingProperties) for OgnlVal= ueStack.THROW_EXCEPTION_ON_FAILURE and REPORT_ERRORS_ON_NO_PROP. =20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Can't get OgnlValueStack log even if enable logMissingProperties > ---------------------------------------------------------------- > > Key: WW-4999 > URL: https://issues.apache.org/jira/browse/WW-4999 > Project: Struts 2 > Issue Type: Bug > Components: Value Stack > Affects Versions: 2.5.17 > Reporter: Quincy Qu > Priority: Major > Fix For: 2.5.21, 2.6 > > > I'm in devMode, enabled=C2=A0logMissingProperties and expect to see missi= ng property warning in the log. I was surprised that I can't get the missin= g property log even if=C2=A0logMissingProperties is set true. The applicati= on run smoothly and skip the missing property - as expected though. > In another run, I enabled both=C2=A0logMissingProperties and=C2=A0throwEx= ceptionOnFailure. This time the application crash at the missing property a= nd I can get both logs and exception. > After I dive deeper using debugger, I convince myself the config is good,= since devMode and=C2=A0logMissingProperties are true at runtime in OgnlVal= ueStack. > I was confused, why we can't get missing property log without throwing Og= nlException?=C2=A0 > Are we able to enter handleOgnlException(String expr, boolean throwExcept= ionOnFailure, OgnlException e)=C2=A0 at all if=C2=A0throwExceptionOnFailure= is false, in which my expected log is written? -- This message was sent by Atlassian JIRA (v7.6.3#76005)