From issues-return-32980-archive-asf-public=cust-asf.ponee.io@struts.apache.org Tue Jan 22 10:59:09 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 14041180634 for ; Tue, 22 Jan 2019 10:59:08 +0100 (CET) Received: (qmail 5481 invoked by uid 500); 22 Jan 2019 09:59:08 -0000 Mailing-List: contact issues-help@struts.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@struts.apache.org Delivered-To: mailing list issues@struts.apache.org Received: (qmail 5471 invoked by uid 99); 22 Jan 2019 09:59:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Jan 2019 09:59:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B4FA018078A for ; Tue, 22 Jan 2019 09:59:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id epk3bmojqShY for ; Tue, 22 Jan 2019 09:59:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id C1CD75F535 for ; Tue, 22 Jan 2019 09:35:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 05A69E0C57 for ; Tue, 22 Jan 2019 09:35:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id BCD5025689 for ; Tue, 22 Jan 2019 09:35:00 +0000 (UTC) Date: Tue, 22 Jan 2019 09:35:00 +0000 (UTC) From: =?utf-8?Q?Sebastian_G=C3=B6tz_=28JIRA=29?= To: issues@struts.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (WW-5005) Struts2 convention plugin lacks Java 11 support MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/WW-5005?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian G=C3=B6tz updated WW-5005: ------------------------------- Description:=20 As discussed in the mailing list, the convention plugin is uncapable of ana= lysing web applications that have classes compiled with class versions high= er than 52. This blocks users that compile their web app projects with Java= 9, 10 or 11. Excerpt from the mailing list discussion: I have taken a look at the struts-2-5-x branch in github. There is a global= property in the {{struts-parent}} of that defines the version for ASM: {{5.2}} The {{struts-master}} pom of the current github *master branch* has: {{7.0}} But when I look into {{DefaultClassFinder$InfoBuildingVisitor}} class (line= 461) of the *master branch* there is still ASM 5 used: {{public class InfoBuildingVisitor extends ClassVisitor {}} {{=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 private Info info;}} {{=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 private ClassFinder classFind= er;}} {{=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 public InfoBuildingVisitor(Cla= ssFinder classFinder) {}} =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 *{{supe= r(Opcodes.ASM5);}}* {{=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 this.= classFinder =3D classFinder;}} \{{=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 }}} So first step would be to change this coupling to ASM's version 7 API and c= heck how this affects=C2=A0classes compiled with Java 8 or below. was: As discussed in the mailing list, the convention plugin is uncapable of ana= lysing web applications that have classes compiled with class versions high= er than 52. This blocks users that compile the web app projects with Java 9= , 10 or 11. Excerpt from the mailing list discussion: I have taken a look at the struts-2-5-x branch in github. There is a global= property in the {{struts-parent}} of that defines the version for ASM: =20 {{5.2}} =20 The {{struts-master}} pom of the current github *master branch* has: =20 {{7.0}} =20 But when I look into {{DefaultClassFinder$InfoBuildingVisitor}} class (lin= e 461) of the *master branch* there is still ASM 5 used: =20 {{public class InfoBuildingVisitor extends ClassVisitor {}} {{=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 private Info info;}} {{=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 private ClassFinder classFinde= r;}} {{=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 public InfoBuildingVisitor(Cla= ssFinder classFinder) {}} =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 *{{super= (Opcodes.ASM5);}}* {{=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 this.c= lassFinder =3D classFinder;}} {{=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 }}} =20 So first step would be to change this coupling to ASM's version 7 API and = check how this affects=C2=A0classes compiled with Java 8 or below. > Struts2 convention plugin lacks Java 11 support > ----------------------------------------------- > > Key: WW-5005 > URL: https://issues.apache.org/jira/browse/WW-5005 > Project: Struts 2 > Issue Type: New Feature > Components: Plugin - Convention > Affects Versions: 2.5.20, 2.6 > Reporter: Sebastian G=C3=B6tz > Priority: Major > > As discussed in the mailing list, the convention plugin is uncapable of a= nalysing web applications that have classes compiled with class versions hi= gher than 52. This blocks users that compile their web app projects with Ja= va 9, 10 or 11. > Excerpt from the mailing list discussion: > I have taken a look at the struts-2-5-x branch in github. There is a glob= al property in the {{struts-parent}} of that defines the version for ASM: > {{5.2}} > The {{struts-master}} pom of the current github *master branch* has: > {{7.0}} > But when I look into {{DefaultClassFinder$InfoBuildingVisitor}} class (li= ne 461) of the *master branch* there is still ASM 5 used: > {{public class InfoBuildingVisitor extends ClassVisitor {}} > {{=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 private Info info;}} > {{=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 private ClassFinder classFi= nder;}} > {{=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 public InfoBuildingVisitor(C= lassFinder classFinder) {}} > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 *{{su= per(Opcodes.ASM5);}}* > {{=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 thi= s.classFinder =3D classFinder;}} > \{{=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 }}} > So first step would be to change this coupling to ASM's version 7 API and= check how this affects=C2=A0classes compiled with Java 8 or below. -- This message was sent by Atlassian JIRA (v7.6.3#76005)