From issues-return-32916-archive-asf-public=cust-asf.ponee.io@struts.apache.org Sun Jan 6 21:50:06 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A5393180636 for ; Sun, 6 Jan 2019 21:50:05 +0100 (CET) Received: (qmail 39341 invoked by uid 500); 6 Jan 2019 20:50:04 -0000 Mailing-List: contact issues-help@struts.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@struts.apache.org Delivered-To: mailing list issues@struts.apache.org Received: (qmail 39331 invoked by uid 99); 6 Jan 2019 20:50:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 06 Jan 2019 20:50:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 37D7C180EC1 for ; Sun, 6 Jan 2019 20:50:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.251 X-Spam-Level: X-Spam-Status: No, score=-109.251 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id djtgG04SeYAA for ; Sun, 6 Jan 2019 20:50:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id EE0D95F57A for ; Sun, 6 Jan 2019 20:50:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DC660E2639 for ; Sun, 6 Jan 2019 20:50:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2AF152546C for ; Sun, 6 Jan 2019 20:50:00 +0000 (UTC) Date: Sun, 6 Jan 2019 20:50:00 +0000 (UTC) From: "Hudson (JIRA)" To: issues@struts.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (WW-4972) Switch to latest freemarker version when defining incompatible_improvements MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/WW-4972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735328#comment-16735328 ] Hudson commented on WW-4972: ---------------------------- SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #249 (See [https://builds.apache.org/job/Struts-master-JDK7/249/]) WW-4972 Switches incompatible_improvements to VERSION_2_3_28 (lukaszlenart: rev 796c15ee673247fe6c0c23da0b4e29a6ec4bb29d) * (edit) core/src/main/resources/template/simple/scripting-events.ftl * (edit) core/src/main/resources/template/simple/radiomap.ftl * (edit) core/src/main/java/org/apache/struts2/views/freemarker/FreemarkerManager.java WW-4972 Uses built-in auto escaping instead of escaping each parameter (lukaszlenart: rev 3d20e80950d3c66759e70c650662aac573c66cc6) * (edit) core/src/main/resources/template/simple/css.ftl * (edit) core/src/main/resources/template/xhtml/control.ftl * (edit) core/src/main/java/org/apache/struts2/components/UIBean.java * (edit) core/src/main/resources/template/simple/optgroup.ftl * (edit) core/src/main/resources/template/simple/debug.ftl * (edit) core/src/main/resources/template/simple/form-common.ftl * (edit) core/src/main/resources/template/simple/form.ftl * (edit) core/src/main/resources/template/simple/submit.ftl * (edit) apps/showcase/src/main/resources/template/ajaxErrorContainers/controlfooter.ftl * (edit) core/src/main/resources/template/simple/actionerror.ftl * (edit) core/src/main/resources/template/simple/text.ftl * (edit) plugins/config-browser/src/main/resources/config-browser/validatorDetails.ftl * (edit) core/src/main/resources/template/simple/textarea.ftl * (edit) core/src/main/resources/template/simple/reset.ftl * (edit) core/src/main/resources/template/xhtml/controlheader.ftl * (edit) core/src/main/resources/template/xhtml/controlfooter.ftl * (edit) core/src/main/resources/template/xhtml/controlheader-core.ftl * (edit) plugins/config-browser/src/main/resources/config-browser/showConfig.ftl * (edit) core/src/test/resources/org/apache/struts2/views/jsp/ui/Radio-6.txt * (edit) apps/showcase/src/main/resources/template/ajaxErrorContainers/controlheader-core.ftl * (edit) core/src/main/resources/template/simple/password.ftl * (edit) apps/showcase/src/main/webapp/WEB-INF/tags/non-ui/actionPrefix/methodPrefix.ftl * (edit) core/src/main/resources/org/apache/struts2/dispatcher/error.ftl * (edit) core/src/main/resources/template/simple/select.ftl * (edit) apps/showcase/src/main/webapp/WEB-INF/tags/non-ui/actionPrefix/actionPrefix.ftl * (edit) core/src/main/resources/template/simple/hidden.ftl * (edit) core/src/main/java/org/apache/struts2/views/freemarker/FreemarkerManager.java * (edit) core/src/main/resources/template/simple/scripting-events.ftl * (edit) core/src/main/resources/template/simple/doubleselect.ftl * (edit) core/src/main/resources/template/simple/inputtransferselect.ftl * (edit) core/src/main/resources/template/css_xhtml/checkbox.ftl * (edit) core/src/main/resources/template/simple/file.ftl * (edit) core/src/main/resources/template/xhtml/tooltip.ftl * (edit) core/src/main/resources/template/simple/dynamic-attributes.ftl * (edit) core/src/main/resources/template/xhtml/form-close.ftl * (edit) core/src/main/resources/template/simple/fielderror.ftl * (edit) core/src/main/resources/template/simple/combobox.ftl * (edit) core/src/main/resources/template/simple/checkbox.ftl * (edit) core/src/main/resources/template/simple/token.ftl * (edit) core/src/main/resources/template/simple/optiontransferselect.ftl * (edit) core/src/main/resources/template/xhtml/checkbox.ftl * (edit) core/src/main/resources/template/simple/label.ftl * (edit) core/src/main/resources/template/simple/radiomap.ftl * (edit) core/src/main/resources/template/simple/a-close.ftl * (edit) core/src/test/java/org/apache/struts2/views/jsp/ui/ActionErrorTagTest.java * (edit) plugins/config-browser/src/main/resources/config-browser/actionNames.ftl * (edit) apps/showcase/src/main/webapp/WEB-INF/tags/non-ui/actionPrefix/redirectActionPrefix.ftl * (edit) core/src/main/resources/template/simple/common-attributes.ftl * (edit) apps/showcase/src/main/webapp/WEB-INF/person/list-people.ftl * (edit) core/src/main/resources/template/xhtml/form.ftl * (edit) core/src/main/resources/template/css_xhtml/controlheader-core.ftl * (edit) core/src/main/resources/template/css_xhtml/label.ftl * (edit) apps/showcase/src/main/resources/template/ajaxErrorContainers/actionerror.ftl * (edit) core/src/main/resources/template/simple/actionmessage.ftl * (edit) core/src/main/resources/template/simple/checkboxlist.ftl * (edit) core/src/main/resources/template/css_xhtml/controlfooter.ftl WW-4972 Uses proper statement to escape JS related events (lukaszlenart: rev 35497649baf9d3ed98f66d8165a415f2c88561b3) * (edit) core/src/main/resources/template/xhtml/tooltip.ftl * (edit) core/src/main/resources/template/xhtml/form.ftl * (edit) core/src/main/resources/template/simple/form-common.ftl * (edit) core/src/main/resources/template/simple/scripting-events.ftl WW-4972 Adds two simple test cases to cover incompatible improvements (lukaszlenart: rev 6f05603ab030356d07b41e2e171937ba968c6aca) * (edit) core/src/test/java/org/apache/struts2/views/freemarker/FreemarkerManagerTest.java WW-4972 Adds another test case to cover escaping (lukaszlenart: rev 0ecb482a111c55d5a5b5bb804c35b1686335ba0b) * (add) core/src/test/resources/org/apache/struts2/views/freemarker/incompatible-improvements.ftl * (edit) core/src/test/java/org/apache/struts2/views/freemarker/FreemarkerManagerTest.java > Switch to latest freemarker version when defining incompatible_improvements > --------------------------------------------------------------------------- > > Key: WW-4972 > URL: https://issues.apache.org/jira/browse/WW-4972 > Project: Struts 2 > Issue Type: Improvement > Components: Core Results > Reporter: Lukasz Lenart > Assignee: Lukasz Lenart > Priority: Major > Fix For: 2.6 > > > Right now Struts fallbacks into {{VERSION_2_3_0}} when defining a FreeMarker manager, it would be better to use the latest version and allow users to switch back to the previous version on demand. > There is already a method {{getFreemarkerVersion}} in the FreeMarker Manager that need to be adjusted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)