struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4996) Refactor DefaultTypeConverterCreator to use ObjectFactory#buildConverter
Date Sun, 06 Jan 2019 05:58:00 GMT

    [ https://issues.apache.org/jira/browse/WW-4996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735082#comment-16735082
] 

ASF GitHub Bot commented on WW-4996:
------------------------------------

yasserzamani commented on pull request #297: [WW-4996] Refactor DefaultTypeConverterCreator
to use ObjectFactory#buildConverter
URL: https://github.com/apache/struts/pull/297
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Refactor DefaultTypeConverterCreator to use ObjectFactory#buildConverter
> ------------------------------------------------------------------------
>
>                 Key: WW-4996
>                 URL: https://issues.apache.org/jira/browse/WW-4996
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Lukasz Lenart
>            Assignee: Lukasz Lenart
>            Priority: Minor
>             Fix For: 2.6
>
>
> Right now {{DefaultTypeConverterCreator}} doesn't use {{ObjectFactory#buildConverter()}}
method which is a bit misleading. Also the class name is misleading as this is a default Struts
implementation so it should be named {{StrutsTypeConverterCreator}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message