struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4995) Enhancement for s:set tag to improve tag body whitespace control.
Date Fri, 21 Dec 2018 20:30:00 GMT

    [ https://issues.apache.org/jira/browse/WW-4995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16727035#comment-16727035
] 

Hudson commented on WW-4995:
----------------------------

SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #243 (See [https://builds.apache.org/job/Struts-master-JDK7/243/])
WW-4995 Add trimBody attribute to set tag (aleksandr.7m: rev cd434da6f0f28153d5446e1f7849bd4740da4023)
* (edit) core/src/main/java/org/apache/struts2/views/jsp/SetTag.java
* (edit) core/src/test/java/org/apache/struts2/views/jsp/SetTagTest.java
* (edit) core/src/main/java/org/apache/struts2/components/Set.java


> Enhancement for s:set tag to improve tag body whitespace control.
> -----------------------------------------------------------------
>
>                 Key: WW-4995
>                 URL: https://issues.apache.org/jira/browse/WW-4995
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core Tags
>    Affects Versions: 2.5.18
>         Environment: All environments.
>            Reporter: James Chaplin
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 2.5.19
>
>
> Hello Apache Struts Team.
> The current s:set tag performs an automatic _trim()_ on any body content used (when using
the <s:set>something</s:set> style with a body).
> The current behaviour limits white-space control for the text body passed to the s:set
tag (and makes assigning a single-or-muliple-character whitespace set - e.g. "  " impossible
via the tag body)..
> A proposed improvement is to introduce two optional attributes to the s:set tag which
will permit the following:
>  * Allow an override to prevent the trim() from happening (helps to preserve existing
whitespace)..
>  * Allow the optional removal of all line-breaks from the tag body content (to allow
vertical collapsing of tag body content without impacting anything else).
> There is a PR available with a proposed implementation for the enhancement.  I believe
having this additional flexibility will be beneficial for some JSP content generation scenarios.
> Please review and advise if this minor enhancement can be considered for inclusion in
2.5.19 (and then ported forward for 2.6).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message