From issues-return-32647-archive-asf-public=cust-asf.ponee.io@struts.apache.org Sun Nov 18 12:49:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C615718066C for ; Sun, 18 Nov 2018 12:49:05 +0100 (CET) Received: (qmail 49615 invoked by uid 500); 18 Nov 2018 11:49:04 -0000 Mailing-List: contact issues-help@struts.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@struts.apache.org Delivered-To: mailing list issues@struts.apache.org Received: (qmail 49605 invoked by uid 99); 18 Nov 2018 11:49:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 18 Nov 2018 11:49:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 52226C1DF4 for ; Sun, 18 Nov 2018 11:49:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id PuzSmE55WDwl for ; Sun, 18 Nov 2018 11:49:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 3497761CAF for ; Sun, 18 Nov 2018 11:49:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 2DD89E2613 for ; Sun, 18 Nov 2018 11:49:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6843421E7F for ; Sun, 18 Nov 2018 11:49:00 +0000 (UTC) Date: Sun, 18 Nov 2018 11:49:00 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@struts.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (WW-4977) Fixing flaky test in Jsr168DispatcherTest and Jsr286DispatcherTest MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/WW-4977?page=3Dcom.atlassian.ji= ra.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1669087= 6#comment-16690876 ]=20 ASF subversion and git services commented on WW-4977: ----------------------------------------------------- Commit 299d91e52bb39112921079b808bbeefee3a4c0f4 in struts's branch refs/hea= ds/master from [~yasser.zamani] [ https://gitbox.apache.org/repos/asf?p=3Dstruts.git;h=3D299d91e ] Merge pull request #263 from OrDTesters/JsrDispatcherTestFix [WW-4977] Fixing flaky test in Jsr168DispatcherTest and Jsr286DispatcherTes= t. > Fixing flaky test in Jsr168DispatcherTest and Jsr286DispatcherTest > ------------------------------------------------------------------ > > Key: WW-4977 > URL: https://issues.apache.org/jira/browse/WW-4977 > Project: Struts 2 > Issue Type: Bug > Components: Plugin - Portlet > Reporter: OrDTesters > Priority: Minor > Fix For: 2.6 > > > testRender_ok and testProcessAction_ok in Jsr168DispatcherTest have test-= order dependencies and fail when they are run after testModeChangeUsingPort= letWidgets. Similarly, testRender_ok and testProcessAction_ok in Jsr286Disp= atcherTest also have this problem. > =C2=A0 > These tests can be fixed by adding the entry \{STRUTS_ALWAYS_SELECT_FULL_= NAMESPACE=3D=E2=80=9Ctrue=E2=80=9D} to initParams in testModeChangeUsingPor= tletWidgets, as shown in the following pull request. The fix will enable th= e tests in these classes to now pass in any order. > (*to be replaced with a link to pull request when a pull request is made*= ) > =C2=A0 > Without the fix, the tests will get an error. More specifically, the erro= r from Jsr168DispatcherTest.testProcessAction_ok is shown below. Let me kno= w if you want to discuss more. > =C2=A0=C2=A0 > {code:java} > org.jmock.core.DynamicMockError: mockActionProxyFactory: unexpected invoc= ation > Invoked: mockActionProxyFactory.createActionProxy("", "testAction", null,= <{com.opensymphony.xwork2.dispatcher.HttpServletRequest=3Dorg.apache.strut= s2.dispatcher.StrutsRequestWrapper@6063f37, application=3D{viewNamespace=3D= /view, struts.mapper.alwaysSelectFullNamespace=3Dtrue}, com.opensymphony.xw= ork2.ActionContext.locale=3Den_US, com.opensymphony.xwork2.dispatcher.HttpS= ervletResponse=3Dorg.apache.struts2.portlet.servlet.PortletServletResponse@= 42036f8, struts.portlet.modeActionMap=3D{help=3DActionMapping{name=3D'defau= lt', namespace=3D'', method=3D'null', extension=3D'null', params=3D{}, resu= lt=3Dnull}, preview=3DActionMapping{name=3D'default', namespace=3D'', metho= d=3D'null', extension=3D'null', params=3D{}, result=3Dnull}, edit=3DActionM= apping{name=3D'default', namespace=3D'', method=3D'null', extension=3D'null= ', params=3D{}, result=3Dnull}, about=3DActionMapping{name=3D'default', nam= espace=3D'', method=3D'null', extension=3D'null', params=3D{}, result=3Dnul= l}, edit_defaults=3DActionMapping{name=3D'default', namespace=3D'', method= =3D'null', extension=3D'null', params=3D{}, result=3Dnull}, config=3DAction= Mapping{name=3D'default', namespace=3D'', method=3D'null', extension=3D'nul= l', params=3D{}, result=3Dnull}, view=3DActionMapping{name=3D'default', nam= espace=3D'/view', method=3D'null', extension=3D'null', params=3D{}, result= =3Dnull}, print=3DActionMapping{name=3D'default', namespace=3D'', method=3D= 'null', extension=3D'null', params=3D{}, result=3Dnull}}, struts.portlet.po= rtletNamespace=3D, struts.portlet.modeNamespaceMap=3D{help=3D, preview=3D, = edit=3D, about=3D, edit_defaults=3D, config=3D, view=3D/view, print=3D}, co= m.opensymphony.xwork2.ActionContext.application=3D{viewNamespace=3D/view, s= truts.mapper.alwaysSelectFullNamespace=3Dtrue}, attr=3DAttributeMap {reques= t=3D{}, session=3D{}, application=3D{viewNamespace=3D/view, struts.mapper.a= lwaysSelectFullNamespace=3Dtrue}}, struts.portlet.request=3Dnull, com.opens= ymphony.xwork2.dispatcher.ServletContext=3Dorg.apache.struts2.portlet.servl= et.PortletServletContext@5ef8d5e5, struts.portlet.defaultActionForMode=3DAc= tionMapping{name=3D'default', namespace=3D'/view', method=3D'null', extensi= on=3D'null', params=3D{}, result=3Dnull}, struts.portlet.phase=3DACTION_PHA= SE, com.opensymphony.xwork2.ActionContext.session=3D{}, struts.portlet.cont= ext=3Dnull, session=3D{}, request=3D{}, struts.portlet.config=3Dnull, strut= s.actionMapping=3DActionMapping{name=3D'testAction', namespace=3D'', method= =3D'null', extension=3D'action', params=3D{}, result=3Dnull}, parameters=3D= {struts.portlet.mode=3D[Ljava.lang.String;@22a2de19, struts.portlet.action= =3D[Ljava.lang.String;@72a34d12}, com.opensymphony.xwork2.ActionContext.par= ameters=3D{struts.portlet.mode=3Dview, struts.portlet.action=3D/view/testAc= tion}, struts.portlet.response=3DmockActionResponse}>) > Allowed: > expected once: createActionProxy( eq("/view"), eq("testAction"), null, an= instance of java.util.Map ), returns =C2=A0 > {code} > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)