struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4963) Implement new Aware interfaces that are using withXxxx pattern instead of setters
Date Mon, 22 Oct 2018 11:01:00 GMT

    [ https://issues.apache.org/jira/browse/WW-4963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16658881#comment-16658881
] 

Hudson commented on WW-4963:
----------------------------

SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #193 (See [https://builds.apache.org/job/Struts-master-JDK7/193/])
WW-4963 Implements new SessionAware interface that uses withSession (lukaszlenart: rev d38efae5f09776e45dd0e0faaa8bf1cf2ab04dad)
* (edit) core/src/main/java/org/apache/struts2/interceptor/ServletConfigInterceptor.java
* (edit) core/src/test/java/org/apache/struts2/interceptor/ServletConfigInterceptorTest.java
* (edit) core/src/main/java/org/apache/struts2/interceptor/SessionAware.java
* (add) core/src/main/java/org/apache/struts2/action/SessionAware.java
WW-4963 Implements new ServletRequestAware interface that uses (lukaszlenart: rev 3820eae31f9db2016ac8d9576ed2346cda41fc9b)
* (edit) core/src/main/java/org/apache/struts2/interceptor/ServletConfigInterceptor.java
* (edit) core/src/main/java/org/apache/struts2/interceptor/ServletRequestAware.java
* (edit) core/src/test/java/org/apache/struts2/interceptor/ServletConfigInterceptorTest.java
* (add) core/src/main/java/org/apache/struts2/action/ServletRequestAware.java
WW-4963 Implements new ServletResponseAware interface that uses (lukaszlenart: rev e0fb8031ce99dcb893dbc0b223845235eca7721a)
* (edit) core/src/main/java/org/apache/struts2/interceptor/ServletConfigInterceptor.java
* (add) core/src/main/java/org/apache/struts2/action/ServletResponseAware.java
* (edit) core/src/main/java/org/apache/struts2/interceptor/ServletResponseAware.java
* (edit) core/src/test/java/org/apache/struts2/interceptor/ServletConfigInterceptorTest.java
WW-4963 Implements new ApplicationAware interface that uses (lukaszlenart: rev dc7138ee2ea42194ee51cc886b1598021d536f0f)
* (edit) core/src/main/java/org/apache/struts2/interceptor/ApplicationAware.java
* (add) core/src/main/java/org/apache/struts2/action/ApplicationAware.java
* (edit) core/src/test/java/org/apache/struts2/interceptor/ServletConfigInterceptorTest.java
* (edit) core/src/main/java/org/apache/struts2/interceptor/ServletConfigInterceptor.java
WW-4963 Implements new PrincipalAware interface that uses (lukaszlenart: rev 384d418039998db6957b49cec806a7a0b2fd03a7)
* (edit) core/src/main/java/org/apache/struts2/interceptor/PrincipalAware.java
* (edit) plugins/portlet/src/main/java/org/apache/struts2/portlet/interceptor/PortletAwareInterceptor.java
* (edit) core/src/test/java/org/apache/struts2/interceptor/ServletConfigInterceptorTest.java
* (add) core/src/main/java/org/apache/struts2/action/PrincipalAware.java
* (edit) core/src/main/java/org/apache/struts2/interceptor/ServletConfigInterceptor.java
WW-4963 Implements new BundleContextAware interface that uses (lukaszlenart: rev 01016b458e7af42b8f645fa6d35c6e929e3fa4c0)
* (edit) plugins/osgi/src/main/java/org/apache/struts2/osgi/interceptor/OsgiInterceptor.java
* (edit) plugins/osgi/src/test/java/org/apache/struts2/osgi/interceptor/OsgiInterceptorTest.java
* (edit) bundles/demo/src/main/java/actions/osgi/BundlesAction.java
* (add) plugins/osgi/src/main/java/org/apache/struts2/osgi/action/BundleContextAware.java
* (edit) plugins/osgi/src/main/java/org/apache/struts2/osgi/interceptor/BundleContextAware.java
WW-4963 Implements new CookiesAware interface that uses withCookies (lukaszlenart: rev 23e9c88135116e420348b2f9867a81f0de2c63e6)
* (add) core/src/main/java/org/apache/struts2/action/CookiesAware.java
* (edit) core/src/main/java/org/apache/struts2/interceptor/CookieInterceptor.java
* (edit) core/src/main/java/org/apache/struts2/interceptor/CookiesAware.java
* (edit) core/src/test/java/org/apache/struts2/interceptor/CookieInterceptorTest.java
WW-4963 Implements new PortletContextAware interface that uses (lukaszlenart: rev 42245be546c8f8db57ca1b129022ed5a5c05ae89)
* (edit) plugins/portlet/src/main/java/org/apache/struts2/portlet/interceptor/PortletContextAware.java
* (add) plugins/portlet/src/main/java/org/apache/struts2/portlet/action/PortletContextAware.java
* (edit) plugins/portlet/src/main/java/org/apache/struts2/portlet/interceptor/PortletAwareInterceptor.java
WW-4963 Implements new PortletPreferencesAware interface that uses (lukaszlenart: rev f59860026c890f0e2dcc3edea8a41f0e989027f9)
* (edit) plugins/portlet/src/main/java/org/apache/struts2/portlet/interceptor/PortletAwareInterceptor.java
* (edit) plugins/portlet/src/main/java/org/apache/struts2/portlet/interceptor/PortletPreferencesAware.java
* (add) plugins/portlet/src/main/java/org/apache/struts2/portlet/action/PortletPreferencesAware.java
WW-4963 Implements new PortletRequestAware interface that uses (lukaszlenart: rev ec4a44567d6470ed1a9f457d857e8ce4ac4c3e09)
* (edit) plugins/portlet/src/test/java/org/apache/struts2/portlet/interceptor/PortletAwareInterceptorTest.java
* (edit) plugins/portlet/src/main/java/org/apache/struts2/portlet/interceptor/PortletAwareInterceptor.java
* (add) plugins/portlet/src/main/java/org/apache/struts2/portlet/action/PortletRequestAware.java
* (edit) plugins/portlet/src/main/java/org/apache/struts2/portlet/interceptor/PortletRequestAware.java
WW-4963 Implements new PortletResponseAware interface with a test that (lukaszlenart: rev
5428252d5789c701174949d130e3e44cc7f99013)
* (add) plugins/portlet/src/main/java/org/apache/struts2/portlet/action/PortletResponseAware.java
* (edit) plugins/portlet/src/main/java/org/apache/struts2/portlet/interceptor/PortletResponseAware.java
* (edit) plugins/portlet/src/main/java/org/apache/struts2/portlet/interceptor/PortletAwareInterceptor.java
* (edit) plugins/portlet/src/test/java/org/apache/struts2/portlet/interceptor/PortletAwareInterceptorTest.java
WW-4963 Implements new ParametersAware interface that uses (lukaszlenart: rev 56fc731670167878e6b42fdd3a113e62dc871a1d)
* (add) core/src/main/java/org/apache/struts2/action/ParametersAware.java
* (edit) core/src/main/java/org/apache/struts2/interceptor/HttpParametersAware.java
* (edit) core/src/main/java/org/apache/struts2/interceptor/ServletConfigInterceptor.java
* (edit) core/src/main/java/org/apache/struts2/interceptor/RequestAware.java
* (edit) core/src/test/java/org/apache/struts2/interceptor/ServletConfigInterceptorTest.java
* (edit) core/src/main/java/org/apache/struts2/interceptor/ParameterAware.java
WW-4963 Implements new ServiceAware interface that uses withServices (lukaszlenart: rev 8cf787b39c1077f8db47c7f1bd7d91bfcc78c222)
* (edit) plugins/osgi/src/main/java/org/apache/struts2/osgi/interceptor/ServiceAware.java
* (add) plugins/osgi/src/test/java/org/apache/struts2/osgi/action/ServiceAction.java
* (edit) plugins/osgi/src/main/java/org/apache/struts2/osgi/interceptor/OsgiInterceptor.java
* (add) plugins/osgi/src/main/java/org/apache/struts2/osgi/action/ServiceAware.java
* (edit) plugins/osgi/src/test/java/org/apache/struts2/osgi/interceptor/OsgiInterceptorTest.java
WW-4963 Implements new ServletContextAware interface and fixes actions (lukaszlenart: rev
b608549933bd2a6fa954ec35beae11519a6632a2)
* (edit) core/src/test/java/org/apache/struts2/interceptor/ServletConfigInterceptorTest.java
* (edit) core/src/main/java/org/apache/struts2/util/ServletContextAware.java
* (edit) core/src/main/java/org/apache/struts2/interceptor/ServletConfigInterceptor.java
* (add) core/src/main/java/org/apache/struts2/action/ServletContextAware.java
* (edit) apps/showcase/src/main/java/org/apache/struts2/showcase/source/ViewSourceAction.java
* (edit) bundles/admin/src/main/java/org/apache/struts2/osgi/admin/actions/BundlesAction.java


> Implement new Aware interfaces that are using withXxxx pattern instead of setters
> ---------------------------------------------------------------------------------
>
>                 Key: WW-4963
>                 URL: https://issues.apache.org/jira/browse/WW-4963
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core Actions
>            Reporter: Lukasz Lenart
>            Assignee: Lukasz Lenart
>            Priority: Major
>             Fix For: 2.6
>
>
> In matter of security I wonder if we should stop using setters in internal API. Like
in {{SessionAware}} interface we use {{setSession()}} and each actions must implement this
method. Then we have a logic to avoid mapping incoming values to {{setSession()}} to permit
injecting values into Session.
> Instead of {{setSession()}} we can use {{withSession()}} or {{applySession()}} - the
same can be applied to any *Aware interface.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message