From issues-return-32189-archive-asf-public=cust-asf.ponee.io@struts.apache.org Mon Jun 18 10:45:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3F24D180663 for ; Mon, 18 Jun 2018 10:45:04 +0200 (CEST) Received: (qmail 22067 invoked by uid 500); 18 Jun 2018 08:45:03 -0000 Mailing-List: contact issues-help@struts.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@struts.apache.org Delivered-To: mailing list issues@struts.apache.org Received: (qmail 22057 invoked by uid 99); 18 Jun 2018 08:45:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Jun 2018 08:45:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id D3A0A180156 for ; Mon, 18 Jun 2018 08:45:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id j8xOEYKTkkvO for ; Mon, 18 Jun 2018 08:45:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 736185F4AE for ; Mon, 18 Jun 2018 08:45:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BE4BDE03A4 for ; Mon, 18 Jun 2018 08:45:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 232112183B for ; Mon, 18 Jun 2018 08:45:00 +0000 (UTC) Date: Mon, 18 Jun 2018 08:45:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@struts.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (WW-4769) Make SecurityMethodAccess excluded classes & packages definitions immutable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/WW-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515495#comment-16515495 ] ASF GitHub Bot commented on WW-4769: ------------------------------------ lukaszlenart closed pull request #232: WW-4769 add unit tests to verify immutable collections URL: https://github.com/apache/struts/pull/232 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/core/src/test/java/com/opensymphony/xwork2/ognl/OgnlUtilTest.java b/core/src/test/java/com/opensymphony/xwork2/ognl/OgnlUtilTest.java index 87578a7a3..3b3c8ae01 100644 --- a/core/src/test/java/com/opensymphony/xwork2/ognl/OgnlUtilTest.java +++ b/core/src/test/java/com/opensymphony/xwork2/ognl/OgnlUtilTest.java @@ -821,6 +821,51 @@ public void testAccessContext() throws Exception { assertSame(that, root); } + public void testGetExcludedPackageNames() { + // Getter should return an immutable collection + OgnlUtil util = new OgnlUtil(); + util.setExcludedPackageNames("java.lang,java.awt"); + assertEquals(util.getExcludedPackageNames().size(), 2); + try { + util.getExcludedPackageNames().clear(); + } + catch (Exception ex) { + assertTrue(ex instanceof UnsupportedOperationException); + } finally { + assertEquals(util.getExcludedPackageNames().size(), 2); + } + } + + public void testGetExcludedClasses() { + // Getter should return an immutable collection + OgnlUtil util = new OgnlUtil(); + util.setExcludedClasses("java.lang.Runtime,java.lang.ProcessBuilder,java.net.URL"); + assertEquals(util.getExcludedClasses().size(), 3); + try { + util.getExcludedClasses().clear(); + } + catch (Exception ex) { + assertTrue(ex instanceof UnsupportedOperationException); + } finally { + assertEquals(util.getExcludedClasses().size(), 3); + } + } + + public void testGetExcludedPackageNamePatterns() { + // Getter should return an immutable collection + OgnlUtil util = new OgnlUtil(); + util.setExcludedPackageNamePatterns("java.lang."); + assertEquals(util.getExcludedPackageNamePatterns().size(), 1); + try { + util.getExcludedPackageNamePatterns().clear(); + } + catch (Exception ex) { + assertTrue(ex instanceof UnsupportedOperationException); + } finally { + assertEquals(util.getExcludedPackageNamePatterns().size(), 1); + } + } + public static class Email { String address; ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Make SecurityMethodAccess excluded classes & packages definitions immutable > --------------------------------------------------------------------------- > > Key: WW-4769 > URL: https://issues.apache.org/jira/browse/WW-4769 > Project: Struts 2 > Issue Type: Improvement > Components: Core > Affects Versions: 2.5.10 > Reporter: Lukasz Lenart > Assignee: Lukasz Lenart > Priority: Major > Fix For: 2.5.12 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)