From issues-return-32013-archive-asf-public=cust-asf.ponee.io@struts.apache.org Fri Mar 23 21:22:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D959518064D for ; Fri, 23 Mar 2018 21:22:03 +0100 (CET) Received: (qmail 77122 invoked by uid 500); 23 Mar 2018 20:22:02 -0000 Mailing-List: contact issues-help@struts.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@struts.apache.org Delivered-To: mailing list issues@struts.apache.org Received: (qmail 77106 invoked by uid 99); 23 Mar 2018 20:22:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Mar 2018 20:22:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 39175C1340 for ; Fri, 23 Mar 2018 20:22:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id EXWcx8LvpRvS for ; Fri, 23 Mar 2018 20:22:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 580B960D45 for ; Fri, 23 Mar 2018 20:22:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 901E5E0DB3 for ; Fri, 23 Mar 2018 20:22:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3064C214E1 for ; Fri, 23 Mar 2018 20:22:00 +0000 (UTC) Date: Fri, 23 Mar 2018 20:22:00 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@struts.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (WW-4865) Struts s:checkbox conversion fails to List MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/WW-4865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16411997#comment-16411997 ] ASF subversion and git services commented on WW-4865: ----------------------------------------------------- Commit 8eced2493cd0a910cb843c9819997007f723c2e1 in struts's branch refs/heads/master from [~aleksandr-m] [ https://gitbox.apache.org/repos/asf?p=struts.git;h=8eced24 ] WW-4865 Change submitUnchecked type to Boolean > Struts s:checkbox conversion fails to List > --------------------------------------------------- > > Key: WW-4865 > URL: https://issues.apache.org/jira/browse/WW-4865 > Project: Struts 2 > Issue Type: Bug > Components: Core, Core Tags > Affects Versions: 2.5.13 > Reporter: Burton Rhodes > Priority: Minor > Fix For: 2.6 > > Original Estimate: 24h > Remaining Estimate: 24h > > Struts is not converted correctly to List when only one checkbox element is present and checkbox is not checked. > [Given] > 1) Mapping s:checkbox to a List > 2) there is only one checkbox in the list > 3) the checkbox is not checked when the form is submitted. > [Result] > Input invalid > The issue is caused by the checkbox tag using the "submit unchecked values" design pattern. As a result, the code base tries to convert the value of the single unchecked element to false (rather than not setting any value of the List). > Fix: Allow the developer to choose if the "submit unchecked values" is to be implemented. Add a new parameter to the s:checkbox tag ("requiredValue"). Default of requiredValue=true for backwards compatibility. When set to false, no hidden input values will be displayed in the view. This flexibility might be needed in other scenarios as well. > Pull Request: https://github.com/apache/struts/pull/169 -- This message was sent by Atlassian JIRA (v7.6.3#76005)