struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefaan Dutry (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4546) unclosed instantiation of PrintWriter
Date Thu, 01 Feb 2018 19:59:00 GMT

    [ https://issues.apache.org/jira/browse/WW-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349177#comment-16349177
] 

Stefaan Dutry commented on WW-4546:
-----------------------------------

Given that the printwriter being talked about is the one from the HttpServletResponse, it
should by no means be closed inside the action.

> unclosed instantiation of PrintWriter 
> --------------------------------------
>
>                 Key: WW-4546
>                 URL: https://issues.apache.org/jira/browse/WW-4546
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.3.24
>            Reporter: songwanging
>            Priority: Minor
>             Fix For: 2.5.x
>
>
> In method execute() of class XSLTResult.java (src\core\src\main\java\org\apache\struts2\views\xslt\XSLTResult.java).
> The instantiation of PrintWriter should be closed after all writing is done.
> {code:java}
>   public void execute(ActionInvocation invocation) throws Exception {
> 	…
>  	PrintWriter writer = response.getWriter();
> ...
>  writer.flush(); // ...and flush...
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message