From issues-return-31738-archive-asf-public=cust-asf.ponee.io@struts.apache.org Wed Jan 31 14:25:09 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 66727180662 for ; Wed, 31 Jan 2018 14:25:09 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 5611B160C35; Wed, 31 Jan 2018 13:25:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9E27A160C25 for ; Wed, 31 Jan 2018 14:25:08 +0100 (CET) Received: (qmail 89707 invoked by uid 500); 31 Jan 2018 13:25:07 -0000 Mailing-List: contact issues-help@struts.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@struts.apache.org Delivered-To: mailing list issues@struts.apache.org Received: (qmail 89697 invoked by uid 99); 31 Jan 2018 13:25:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Jan 2018 13:25:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 48749D9FE7 for ; Wed, 31 Jan 2018 13:25:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id BvtqgH1WUWZB for ; Wed, 31 Jan 2018 13:25:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 3C1F25FAC4 for ; Wed, 31 Jan 2018 13:25:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 11048E0230 for ; Wed, 31 Jan 2018 13:25:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 70C942410E for ; Wed, 31 Jan 2018 13:25:00 +0000 (UTC) Date: Wed, 31 Jan 2018 13:25:00 +0000 (UTC) From: "Lukasz Lenart (JIRA)" To: issues@struts.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (WW-4741) Http Sessions forcefully created for all requests using I18nInterceptor with default Storage value. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/WW-4741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart resolved WW-4741. ------------------------------- Resolution: Fixed > Http Sessions forcefully created for all requests using I18nInterceptor with default Storage value. > --------------------------------------------------------------------------------------------------- > > Key: WW-4741 > URL: https://issues.apache.org/jira/browse/WW-4741 > Project: Struts 2 > Issue Type: Bug > Affects Versions: 2.5.10 > Reporter: Adam Greenfield > Assignee: Lukasz Lenart > Priority: Major > Fix For: 2.5.15 > > > Changes made in WW-4730 for store and read functions cause an httpSession to be created for every request that uses I18nInterceptor when storage = Storage.SESSION. > Current code checks for > {noformat}Map session = invocation.getInvocationContext().getSession(){noformat} > to be null and then calls > {noformat}ServletActionContext.getRequest().getSession(){noformat} > (notice how the second one references the HttpServletRequest. The HttpServletRequest Session and and the InvocationContext session are different. The request's session can be null, even if the InvocationContext's session is not). > Calling .getSession() in this manner forcefully creates a session. > An appropriate check here might be > {noformat}HttpSession httpSession = ServletActionContext.getRequest().getSession(false); > if(httpSession != null) { > ... // get sessionId and synchronize on it > } > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)