Mailing-List: contact issues-help@struts.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@struts.apache.org
Date: Mon, 18 Dec 2017 19:19:00 +0000 (UTC)
From: "Augusto Souza (JIRA)" <jira@apache.org>
To: issues@struts.apache.org
Message-ID: <JIRA.13040981.1486475055000.485410.1513624740472@Atlassian.JIRA>
In-Reply-To: <JIRA.13040981.1486475055000@Atlassian.JIRA>
References: <JIRA.13040981.1486475055000@Atlassian.JIRA> <JIRA.13040981.1486475055582@jira-lw-us.apache.org>
Subject: [jira] [Comment Edited] (WW-4742) Problem with escape when the key
 from getText has no value
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Mon, 18 Dec 2017 19:19:06 -0000


    [ https://issues.apache.org/jira/browse/WW-4742?page=3Dcom.atlassian.ji=
ra.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1629550=
1#comment-16295501 ]=20

Augusto Souza edited comment on WW-4742 at 12/18/17 7:18 PM:
-------------------------------------------------------------

[~lukaszlenart], I'm working in the same project/problem related by [~mtsba=
rbosa].=20
Its enough if change the scape order, first escapeHtml4, and after escapeEc=
maScript.

In the version 2.5.10.1 the code works like this:
{code:java}
msg =3D defaultMessage; // Test xpto' and xpt=C3=B3
msg =3D StringEscapeUtils.escapeEcmaScript(msg); // Test xpto\' and xpt\u00=
F3
msg =3D StringEscapeUtils.escapeHtml4(msg); // Test xpto\' and xpt\u00F3
{code}
Note that in the above example escapeHtml4 doesn't even make sense.

My proposed solution to avoid special characters problems is:
{code:java}
msg =3D defaultMessage; // Teste xpto' and xpt=C3=B3
msg =3D StringEscapeUtils.escapeHtml4(msg); // Teste xpto' and xpt&oacute;
msg =3D StringEscapeUtils.escapeEcmaScript(msg); // Teste xpto\' and xpt&oa=
cute;
{code}

I hope you consider this solution, thanks


was (Author: augustosouza):
[~lukaszlenart], I'm working in the same project/problem related by [~mtsba=
rbosa].=20
Its enough if change the scape order, first escapeHtml4, and after escapeEc=
maScript.

In the version 2.5.10.1 the code works like this:
{code:java}
msg =3D defaultMessage; // Test xpto' and xpt=C3=B3
msg =3D StringEscapeUtils.escapeEcmaScript(msg); // Test xpto\' and xpt\u00=
F3
msg =3D StringEscapeUtils.escapeHtml4(msg); // Test xpto\' and xpt\u00F3
{code}
Note that in the above example escapeHtml4 doesn't even make sense.

My purpose to avoid special characters problems is:
{code:java}
msg =3D defaultMessage; // Teste xpto' and xpt=C3=B3
msg =3D StringEscapeUtils.escapeHtml4(msg); // Teste xpto' and xpt&oacute;
msg =3D StringEscapeUtils.escapeEcmaScript(msg); // Teste xpto\' and xpt&oa=
cute;
{code}

I hope you consider this solution, thanks


> Problem with escape when the key from getText has no value
> ----------------------------------------------------------
>
>                 Key: WW-4742
>                 URL: https://issues.apache.org/jira/browse/WW-4742
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Tags
>    Affects Versions: 2.5.8, 2.5.10
>            Reporter: Mateus Carvalho
>            Assignee: Lukasz Lenart
>            Priority: Minor
>             Fix For: 2.6
>
>
> When using an encoding like ISO-8859-1 and having the following situation=
:
> {code:title=3Dmessage.ftl|borderStyle=3Dsolid}
> ...
> <@s.text name=3D"Obrigat=C3=B3rio - not mapped word in any dictionary" />
> ...
> {code}
> We have the following output after update 2.5.8:
> {code}
> Obrigat\u00F3rio - not mapped word in any dictionary
> {code}
> After careful look at the source code and issues from the 2.5.8 I found t=
he problem happens just in one added line on WW-4712, the following part of=
 the code:
> {code:title=3DTextProviderHelper.java|borderStyle=3Dsolid}
> ...
> public static String getText(String key, String defaultMessage, List<Obje=
ct> args, ValueStack stack, boolean searchStack) {
> ...
> //This escape causes the problem
> msg =3D StringEscapeUtils.escapeEcmaScript(msg);
> ...
> }
> ...
> {code}


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)