struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4871) Decimal converters should avoid loss of user's data caused by rounding
Date Thu, 09 Nov 2017 17:19:00 GMT

    [ https://issues.apache.org/jira/browse/WW-4871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246085#comment-16246085
] 

Hudson commented on WW-4871:
----------------------------

SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #54 (See [https://builds.apache.org/job/Struts-master-JDK7/54/])
WW-4871 Fixes StringConverter and improves it's tests (yasser.zamani: rev 8af1d014cbd3b5b3e1e524dbcf8b554b7a6b954c)
* (edit) core/src/main/java/com/opensymphony/xwork2/conversion/impl/StringConverter.java
* (edit) core/src/test/java/com/opensymphony/xwork2/conversion/impl/StringConverterTest.java
WW-4871 Reverts setMinimumFractionDigits(1) to pass rest tests (yasser.zamani: rev 69d6287566f23dcfded5fdcf8f25ac14f9c257e3)
* (edit) core/src/main/java/com/opensymphony/xwork2/conversion/impl/StringConverter.java
WW-4871 Fixes previous unit tests after setMinimumFractionDigits(1) (yasser.zamani: rev 3514e4f68287dc7e36875dc878fa9a0bc7e1ee01)
* (edit) core/src/test/java/com/opensymphony/xwork2/conversion/impl/StringConverterTest.java
* (edit) core/src/main/java/com/opensymphony/xwork2/conversion/impl/StringConverter.java
WW-4871 Fixes max fraction digits to bigger than max precision (yasser.zamani: rev 86bb7fced47e9735554d15b87c3b6a77c3c9d128)
* (edit) core/src/main/java/com/opensymphony/xwork2/conversion/impl/StringConverter.java
* (edit) core/src/test/java/com/opensymphony/xwork2/conversion/impl/StringConverterTest.java
WW-4871 Makes NumberConverter's test harder (yasser.zamani: rev f01475f08ca6d7f0915e841ac8144ef99a091f3c)
* (edit) core/src/test/java/com/opensymphony/xwork2/conversion/impl/NumberConverterTest.java
WW-4871 Fixes max fraction digits to Integer.MAX_VALUE (yasser.zamani: rev 888f2fc8e0e8dc3087a2ee787727933b63df4040)
* (edit) core/src/main/java/com/opensymphony/xwork2/conversion/impl/StringConverter.java
WW-4871 Drops setMinimumFractionDigits (yasser.zamani: rev 66ae66141362e3fd1c3db26149e15619f6c20fcb)
* (edit) core/src/main/java/com/opensymphony/xwork2/conversion/impl/StringConverter.java
* (edit) core/src/test/java/com/opensymphony/xwork2/conversion/impl/StringConverterTest.java
* (edit) core/src/test/resources/org/apache/struts2/views/jsp/ui/Select-3.txt
* (edit) core/src/test/java/com/opensymphony/xwork2/validator/DoubleRangeFieldValidatorTest.java
WW-4871 Fixes java.text.NumberFormat.format's float to double (yasser.zamani: rev 8b7c68171e8bfe16ea57eb6ec232778f1502e067)
* (edit) core/src/main/java/com/opensymphony/xwork2/conversion/impl/StringConverter.java
* (edit) core/src/test/java/com/opensymphony/xwork2/conversion/impl/StringConverterTest.java
WW-4871 Documents our manual jdk fix by a TODO (yasser.zamani: rev b60425e5348ad0b4e503e442594417d93dd61856)
* (edit) core/src/main/java/com/opensymphony/xwork2/conversion/impl/StringConverter.java
WW-4871 Tests if StringConverter changes float input parameter (yasser.zamani: rev e0d83b840f64eb7581134c925d70cc472914d50c)
* (edit) core/src/test/java/com/opensymphony/xwork2/conversion/impl/StringConverterTest.java
WW-4871 Removes assignment to value parameter (yasser.zamani: rev a5db2881308cfccf52edf165447188ba09124772)
* (edit) core/src/main/java/com/opensymphony/xwork2/conversion/impl/StringConverter.java
* (edit) core/src/test/java/com/opensymphony/xwork2/conversion/impl/StringConverterTest.java


> Decimal converters should avoid loss of user's data caused by rounding
> ----------------------------------------------------------------------
>
>                 Key: WW-4871
>                 URL: https://issues.apache.org/jira/browse/WW-4871
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.5.12, 2.5.13
>            Reporter: Yasser Zamani
>             Fix For: 2.5.14
>
>
> For example in following jsp:
> {code:xml}
> <s:form>
> <s:hidden name="myDecimal"/>
> <s:submit/>
> </s:form>
> {code}
> User loses decimal digits when posts back because of converter's locale based rounding.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message