struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4713) Drop "searchValueStack" attribute from tag <s:text/>
Date Fri, 10 Nov 2017 20:45:00 GMT

    [ https://issues.apache.org/jira/browse/WW-4713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248016#comment-16248016
] 

ASF GitHub Bot commented on WW-4713:
------------------------------------

sdutry opened a new pull request #182: WW-4713 Drop searchValueStack attribute from tag <s:text/>
URL: https://github.com/apache/struts/pull/182
 
 
   Should the method in the TextProviderHelper class also be removed?
   It does not seem to have any remaining references in this project.
   
   https://github.com/apache/struts/blob/6e96f11debc4fa52c65a12b28fea82b514b96abd/core/src/main/java/org/apache/struts2/util/TextProviderHelper.java#L66

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Drop "searchValueStack" attribute from tag <s:text/>
> ----------------------------------------------------
>
>                 Key: WW-4713
>                 URL: https://issues.apache.org/jira/browse/WW-4713
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core Tags
>    Affects Versions: 2.5.8
>            Reporter: Lukasz Lenart
>            Assignee: Stefaan Dutry
>             Fix For: 2.5.x
>
>
> This attribute is only used to evaluate a {{defaultMessage}} against a ValueStack which
is useless in most cases as the {{defaultMessage}} should be a static text, not an expression.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message