struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amaury (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4870) StringConverter from OGNL 3.1.15 in Struts 2.5.13
Date Fri, 13 Oct 2017 08:07:00 GMT

    [ https://issues.apache.org/jira/browse/WW-4870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16203180#comment-16203180
] 

Amaury commented on WW-4870:
----------------------------

I do though too this code is to be reworked but this is not easily doable in some project
context, especially when the case can happen in multiple FTL.
As it is, the legacy code is submitted to potential regression when 2.5.13 is applied. Security
client team want to push fast Struts version upgrade to production. We'll feedback our client
team with your answer.
With all respect however, I don't understand why there is such a conversion only in this version
? Should the decimal conversion be the role of the presentation layer application side ?

Thank you for your support

> StringConverter from OGNL 3.1.15 in Struts 2.5.13
> -------------------------------------------------
>
>                 Key: WW-4870
>                 URL: https://issues.apache.org/jira/browse/WW-4870
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.5.13
>            Reporter: Amaury
>             Fix For: 2.5.14
>
>
> Hi Apache / Struts 2 team,
> We've just discovered a bug with the new version 2.5.13 of Struts 2, mainly in OGNL dependency.
This is not the case with 2.5.10.
> *Scenario*: we have a boolean method in a "if" condition statement in FTL view. This
method takes on argument which is a String ID in the format "X.Y" (ex: "1.1).
> *Result obtained during the OGNL parsing*: StringConverter is called according to the
"locale" of the browser and apparently with "fr_FR" locale, the "X.Y" is converted to decimal
format "X,Y" which is wrong since we want to stick with our ID as it arrives.
> It seems with en_US locale, the decimal conversion doesn't happen.
> *Result expected*: the ID "X.Y" goes to the "if" statement as it is, not converted in
fr_Fr locale.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message