Mailing-List: contact issues-help@struts.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@struts.apache.org
Date: Thu, 7 Sep 2017 07:23:00 +0000 (UTC)
From: "Lukasz Lenart (JIRA)" <jira@apache.org>
To: issues@struts.apache.org
Message-ID: <JIRA.13099252.1504279540000.47260.1504768980426@Atlassian.JIRA>
In-Reply-To: <JIRA.13099252.1504279540000@Atlassian.JIRA>
References: <JIRA.13099252.1504279540000@Atlassian.JIRA> <JIRA.13099252.1504279540680@jira-lw-us.apache.org>
Subject: [jira] [Commented] (WW-4848) The if test can accidently incorrectly
 assign a new value to an object
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 07 Sep 2017 07:23:06 -0000


    [ https://issues.apache.org/jira/browse/WW-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156607#comment-16156607 ] 

Lukasz Lenart commented on WW-4848:
-----------------------------------

It's an expression so OGNL evaluates the expression and then it tries convert it to desire type - that's why it works but I assume it should return {{false}} (0 means false)

> The if test can accidently incorrectly assign a new value to an object
> ----------------------------------------------------------------------
>
>                 Key: WW-4848
>                 URL: https://issues.apache.org/jira/browse/WW-4848
>             Project: Struts 2
>          Issue Type: Bug
>            Reporter: Alan Comeau
>            Priority: Minor
>             Fix For: 2.5.14
>
>
> The {{s:if}} tag has the side effect of assigning to an existing object
> if the comparison is badly formed using {{=}} instead of {{==}}
> {code:html}
> <s:if test="user.id = 0">  
>   //at this point the user.id is now 0 not its original value
> </s:if>
> {code}
> even though this is clearly badly formed, the test should not assign anything to the object


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)