struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mitth'raw'nuruodo (JIRA)" <>
Subject [jira] [Commented] (WW-4849) ObjectFactory constructor signature change breaks extensions
Date Sun, 10 Sep 2017 23:45:00 GMT


Mitth'raw'nuruodo commented on WW-4849:

OK, if this change was really necessary, then:

- it should have been listed in the release notes as a breaking change;
- the documentation for how to write a custom object factory should have been updated;
- there should have been a transitional period, with the no-arg constructor present but deprecated,
so that third parties could update their code;
- ideally, critical security patches should have been released separately.

Should I assume, then, that the correct way to override {{ObjectFactory}} no longer requires
a default no-arg constructor in the subclass, and submit a pull request to the Guice project
on that basis?

> ObjectFactory constructor signature change breaks extensions
> ------------------------------------------------------------
>                 Key: WW-4849
>                 URL:
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.5.13
>            Reporter: Mitth'raw'nuruodo
>             Fix For: 2.5.14
> Commit {{6f91d0776a545c911ca4f2875ed9976614711ef9}} changed the signature of the {{ObjectFactory}}
constructor, breaking all classes that extend {{ObjectFactory}} (as per
This affects eg the [{{guice-servlet}} Struts plugin|].
> This was not listed on the [2.5.13 version notes|]
as a breaking change, and breaking changes should preferably be avoided in critical security

This message was sent by Atlassian JIRA

View raw message