struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mitth'raw'nuruodo (JIRA)" <>
Subject [jira] [Commented] (WW-4849) ObjectFactory constructor signature change breaks extensions
Date Thu, 07 Sep 2017 22:46:00 GMT


Mitth'raw'nuruodo commented on WW-4849:

"The note about default constructor in this document is very old (from 2006)." - If it can
be updated to reflect the true requirements, I'd be happy to submit an appropriate pull request
to the Guice project.

"Unit test doesn't do whole initialization / injection cycle." - Can you elaborate on this?
What would I need to add to eg {{SpringObjectFactoryTest}} to test this comprehensively?

> ObjectFactory constructor signature change breaks extensions
> ------------------------------------------------------------
>                 Key: WW-4849
>                 URL:
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.5.13
>            Reporter: Mitth'raw'nuruodo
>             Fix For: 2.5.14
> Commit {{6f91d0776a545c911ca4f2875ed9976614711ef9}} changed the signature of the {{ObjectFactory}}
constructor, breaking all classes that extend {{ObjectFactory}} (as per
This affects eg the [{{guice-servlet}} Struts plugin|].
> This was not listed on the [2.5.13 version notes|]
as a breaking change, and breaking changes should preferably be avoided in critical security

This message was sent by Atlassian JIRA

View raw message